Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update copy of transaction in transaction list #2139

Conversation

svetoslav-nikol0v
Copy link
Contributor

Description:

Update a copy of the uncompleted transaction in the transaction list after the transaction has been frozen.

Fixes #2138

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

Signed-off-by: svetoslav-nikol0v <svetoslav.nikolov@limechain.tech>
Copy link

codecov bot commented Feb 15, 2024

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (8210a60) 84.21% compared to head (0c6b7d2) 84.34%.
Report is 8 commits behind head on develop.

Files Patch % Lines
src/account/AccountUpdateTransaction.js 77.77% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #2139      +/-   ##
===========================================
+ Coverage    84.21%   84.34%   +0.12%     
===========================================
  Files          305      305              
  Lines        76202    76219      +17     
===========================================
+ Hits         64171    64284     +113     
+ Misses       12031    11935      -96     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: svetoslav-nikol0v <svetoslav.nikolov@limechain.tech>
Signed-off-by: svetoslav-nikol0v <svetoslav.nikolov@limechain.tech>
Copy link

sonarcloud bot commented Feb 19, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
3.6% Duplication on New Code (required ≤ 3%)

See analysis details on SonarCloud

Copy link
Contributor

@agadzhalov agadzhalov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@svetoslav-nikol0v svetoslav-nikol0v merged commit c43fad1 into develop Feb 20, 2024
8 of 9 checks passed
@svetoslav-nikol0v svetoslav-nikol0v deleted the 2138-unable-to-deserialize-a-transaction-after-serialization-and-freezing branch February 20, 2024 08:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unable to deserialize a transaction after serialization and freezing
2 participants