Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: inability to create and execute freeze transaction #2171

Merged

Conversation

svetoslav-nikol0v
Copy link
Contributor

Description:

  • execute() method of FreezeTransaction added
  • FreezeType exported

Fixes #2135

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

Signed-off-by: svetoslav-nikol0v <svetoslav.nikolov@limechain.tech>
Signed-off-by: svetoslav-nikol0v <svetoslav.nikolov@limechain.tech>
@codecov-commenter
Copy link

codecov-commenter commented Feb 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.48%. Comparing base (0feddb2) to head (16941df).

❗ Current head 16941df differs from pull request most recent head feda4c6. Consider uploading reports for the commit feda4c6 to get more accurate results

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #2171      +/-   ##
===========================================
+ Coverage    84.33%   84.48%   +0.14%     
===========================================
  Files          305      305              
  Lines        76228    76240      +12     
===========================================
+ Hits         64289    64408     +119     
+ Misses       11939    11832     -107     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: svetoslav-nikol0v <svetoslav.nikolov@limechain.tech>
Copy link

sonarcloud bot commented Feb 28, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Copy link
Contributor

@agadzhalov agadzhalov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@agadzhalov agadzhalov merged commit 841655f into develop Mar 7, 2024
7 checks passed
@agadzhalov agadzhalov deleted the 2135-inability-to-create-and-execute-freeze-transaction branch March 7, 2024 12:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Inability to create and execute Freeze Transaction
3 participants