fix: do not instantiate logger inside a method #2195
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This PR removes the problematic instantiation of a logger inside a method that is invoked repeatedly.
Related issue(s):
Fixes #2194
Notes for reviewer:
I couldn't run the integration tests as there were no instruction in the README. I saw errors when I ran
task test
locally:Error: Failed to construct client for IntegrationTestEnv
However, please let me know if anything else I should test/modify.
Checklist