Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update: add a new getter to the TransferTransaction class #2214

Conversation

svetoslav-nikol0v
Copy link
Contributor

Description:

A new getter was added to the TransferTransaction class.

Fixes #2190

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

@codecov-commenter
Copy link

codecov-commenter commented Mar 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.50%. Comparing base (7682060) to head (bdbd18e).

❗ Current head bdbd18e differs from pull request most recent head a3d4684. Consider uploading reports for the commit a3d4684 to get more accurate results

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #2214      +/-   ##
===========================================
+ Coverage    78.24%   84.50%   +6.25%     
===========================================
  Files          266      305      +39     
  Lines        66766    76292    +9526     
===========================================
+ Hits         52243    64467   +12224     
+ Misses       14523    11825    -2698     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: svetoslav-nikol0v <svetoslav.nikolov@limechain.tech>
@svetoslav-nikol0v svetoslav-nikol0v force-pushed the 2190-transfer-transaction-isapproved-flag-is-missing-on-current-transfers-getters branch from d537f33 to a3d4684 Compare March 19, 2024 12:47
Copy link

sonarcloud bot commented Mar 19, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Copy link
Contributor

@agadzhalov agadzhalov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@svetoslav-nikol0v svetoslav-nikol0v merged commit f067bbb into main Apr 15, 2024
7 checks passed
@svetoslav-nikol0v svetoslav-nikol0v deleted the 2190-transfer-transaction-isapproved-flag-is-missing-on-current-transfers-getters branch April 15, 2024 12:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Transfer Transaction: isApproved flag is missing on current transfers getters
3 participants