Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
package
statements removed from protocols, since in strict mode the whole namespace is exported instead of the package, and keeping the packages would have required changes in all js files that import protocols.Had to rename one
ConsensusService
->MirrorConsensusService
, as there were two different entities namedConsensusService
.This mostly solves #267, apart from #268. I.e. with this patch, the only thing that remains polluting the global scope is:
which comes from
google/protobuf/wrappers.proto
(see #268).