Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor PlatformState into a singleton #11771

Open
Tracked by #10988
imalygin opened this issue Feb 27, 2024 · 1 comment
Open
Tracked by #10988

Refactor PlatformState into a singleton #11771

imalygin opened this issue Feb 27, 2024 · 1 comment
Labels
Platform Tickets pertaining to the platform

Comments

@imalygin
Copy link
Member

imalygin commented Feb 27, 2024

Currently, PlatformState is an instance of MerkleLeaf and it deviates from the idea of having only three types in the Merkle tree (KV storage, queue, and singleton). It should be refactored to a singleton.

When this ticket is complete, PlatformState will be migrated to the protobuf format and accessed through the State API only.

PlatformState contains several fields to be deleted:

epochHash - we no longer support emergency reconnect
nextEpochHash - same
uptimeData - currently not utilized for anything. This is a part of a feature that was not fully implemented, and it's implementation should be reconsidered separately

The unit tests associated with this change are NOT part of this ticket. This ticket will NOT result in a mergable PR. Criteria of Done for this ticket is getting informal signoffs on the draft PR so that unit tests can be updated (another ticket) without rework.

@imalygin imalygin self-assigned this Apr 9, 2024
@imalygin
Copy link
Member Author

imalygin commented May 6, 2024

Blocked by #13084

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Platform Tickets pertaining to the platform
Projects
None yet
Development

No branches or pull requests

2 participants