-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: 13135 Added PlatformState protobuf representation #349
feat: 13135 Added PlatformState protobuf representation #349
Conversation
145c149
to
75049c9
Compare
899555f
to
69ac2fc
Compare
f6f6194
to
8ead05f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks @imalygin
39010c2
to
d208126
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Apologies for the delay, this took a bit more thought and rework than expected; partly a lot of description was in pseudo-requirements so that took some thought to understand.
Signed-off-by: Ivan Malygin <ivan@swirldslabs.com>
Signed-off-by: Ivan Malygin <ivan@swirldslabs.com> Co-authored-by: Joseph Sinclair <121976561+jsync-swirlds@users.noreply.github.com>
Updated the documentation according to the guidelines. Moved platform_state.proto to platform/state directory. Updated the documentation according to the guidelines. Signed-off-by: Ivan Malygin <ivan@swirldslabs.com>
…d_mode` and updated its order. Signed-off-by: Ivan Malygin <ivan@swirldslabs.com>
…ancient_threshold`. Signed-off-by: Ivan Malygin <ivan@swirldslabs.com>
… from `ConsensusSnapshot`, as these fields duplicate fields in `PlatformState` and mean exactly the same thing. Signed-off-by: Ivan Malygin <ivan@swirldslabs.com>
Signed-off-by: Ivan Malygin <ivan@swirldslabs.com>
Signed-off-by: Ivan Malygin <ivan@swirldslabs.com> Co-authored-by: Joseph Sinclair <121976561+jsync-swirlds@users.noreply.github.com>
c959af0
to
f1f4dd1
Compare
…put it back to `ConsensusSnapshot` Signed-off-by: Ivan Malygin <ivan@swirldslabs.com>
…ormState` and put it back to `ConsensusSnapshot` Signed-off-by: Ivan Malygin <ivan@swirldslabs.com>
111bad5
to
b8e1110
Compare
Signed-off-by: Ivan Malygin <ivan@swirldslabs.com>
…h_round_mode` to the set of deprecated fields. Signed-off-by: Ivan Malygin <ivan@swirldslabs.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, just one item to resolve in a follow-up PR.
Co-authored-by: Joseph S. <121976561+jsync-swirlds@users.noreply.github.com> Signed-off-by: Ivan Malygin <ivan@swirldslabs.com>
d277420
to
dd4b50c
Compare
Description:
This PR adds representation of
com.swirlds.platform.state.PlatformState
object. It's a prerequisite for hashgraph/hedera-services#11771Related issue(s):
Fixes # hashgraph/hedera-services#13135
Related # hashgraph/hedera-services#11771