Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: 13135 Added PlatformState protobuf representation #349

Merged
merged 22 commits into from
Jul 3, 2024

Conversation

imalygin
Copy link
Member

@imalygin imalygin commented May 8, 2024

Description:

This PR adds representation of com.swirlds.platform.state.PlatformState object. It's a prerequisite for hashgraph/hedera-services#11771

Related issue(s):

Fixes # hashgraph/hedera-services#13135

Related # hashgraph/hedera-services#11771

@imalygin imalygin requested review from a team as code owners May 8, 2024 21:47
@imalygin imalygin force-pushed the 13135-add-platform-state branch 2 times, most recently from 145c149 to 75049c9 Compare May 8, 2024 21:58
@imalygin imalygin requested a review from a team as a code owner May 8, 2024 23:17
@imalygin imalygin requested a review from kfa-aguda May 8, 2024 23:17
@imalygin imalygin force-pushed the 13135-add-platform-state branch 2 times, most recently from f6f6194 to 8ead05f Compare May 8, 2024 23:24
iwsimon
iwsimon previously approved these changes May 9, 2024
Copy link
Contributor

@iwsimon iwsimon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks @imalygin

@imalygin imalygin force-pushed the 13135-add-platform-state branch 5 times, most recently from 39010c2 to d208126 Compare May 9, 2024 22:19
Copy link
Member

@jsync-swirlds jsync-swirlds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apologies for the delay, this took a bit more thought and rework than expected; partly a lot of description was in pseudo-requirements so that took some thought to understand.

platform/state/platform_state.proto Outdated Show resolved Hide resolved
platform/state/platform_state.proto Outdated Show resolved Hide resolved
jsync-swirlds
jsync-swirlds previously approved these changes May 10, 2024
platform/state/platform_state.proto Outdated Show resolved Hide resolved
platform/state/platform_state.proto Outdated Show resolved Hide resolved
platform/state/platform_state.proto Outdated Show resolved Hide resolved
platform/state/platform_state.proto Outdated Show resolved Hide resolved
platform/state/platform_state.proto Outdated Show resolved Hide resolved
platform/state/platform_state.proto Outdated Show resolved Hide resolved
platform/state/platform_state.proto Outdated Show resolved Hide resolved
platform/state/platform_state.proto Outdated Show resolved Hide resolved
platform/state/platform_state.proto Outdated Show resolved Hide resolved
platform/state/platform_state.proto Show resolved Hide resolved
platform/state/platform_state.proto Outdated Show resolved Hide resolved
platform/state/platform_state.proto Outdated Show resolved Hide resolved
platform/state/platform_state.proto Outdated Show resolved Hide resolved
platform/state/platform_state.proto Outdated Show resolved Hide resolved
platform/state/platform_state.proto Outdated Show resolved Hide resolved
imalygin and others added 3 commits June 11, 2024 16:10
Signed-off-by: Ivan Malygin <ivan@swirldslabs.com>
Signed-off-by: Ivan Malygin <ivan@swirldslabs.com>
Co-authored-by: Joseph Sinclair <121976561+jsync-swirlds@users.noreply.github.com>
Updated the documentation according to the guidelines.

Moved platform_state.proto to platform/state directory.
Updated the documentation according to the guidelines.

Signed-off-by: Ivan Malygin <ivan@swirldslabs.com>
…d_mode` and updated its order.

Signed-off-by: Ivan Malygin <ivan@swirldslabs.com>
…ancient_threshold`.

Signed-off-by: Ivan Malygin <ivan@swirldslabs.com>
… from `ConsensusSnapshot`, as these fields duplicate fields in `PlatformState` and mean exactly the same thing.

Signed-off-by: Ivan Malygin <ivan@swirldslabs.com>
Signed-off-by: Ivan Malygin <ivan@swirldslabs.com>
Signed-off-by: Ivan Malygin <ivan@swirldslabs.com>
Co-authored-by: Joseph Sinclair <121976561+jsync-swirlds@users.noreply.github.com>
…put it back to `ConsensusSnapshot`

Signed-off-by: Ivan Malygin <ivan@swirldslabs.com>
…ormState` and put it back to `ConsensusSnapshot`

Signed-off-by: Ivan Malygin <ivan@swirldslabs.com>
Signed-off-by: Ivan Malygin <ivan@swirldslabs.com>
platform/state/platform_state.proto Outdated Show resolved Hide resolved
platform/state/platform_state.proto Show resolved Hide resolved
platform/state/platform_state.proto Show resolved Hide resolved
platform/state/platform_state.proto Show resolved Hide resolved
…h_round_mode` to the set of deprecated fields.

Signed-off-by: Ivan Malygin <ivan@swirldslabs.com>
jsync-swirlds
jsync-swirlds previously approved these changes Jul 1, 2024
Copy link
Member

@jsync-swirlds jsync-swirlds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just one item to resolve in a follow-up PR.

Co-authored-by: Joseph S. <121976561+jsync-swirlds@users.noreply.github.com>
Signed-off-by: Ivan Malygin <ivan@swirldslabs.com>
@Neeharika-Sompalli Neeharika-Sompalli merged commit 54b258d into hashgraph:main Jul 3, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

8 participants