Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Skip transactions older than the software version #13527

Merged
merged 7 commits into from
May 28, 2024
Merged

fix: Skip transactions older than the software version #13527

merged 7 commits into from
May 28, 2024

Conversation

mhess-swl
Copy link
Member

Closes #13487

@mhess-swl
Skip transactions older than the software version
7a6b8ae 
Signed-off-by: Matt Hess <matt.hess@swirldslabs.com>
@mhess-swl mhess-swl added this to the v0.50 milestone May 25, 2024
@mhess-swl mhess-swl self-assigned this May 25, 2024
@mhess-swl mhess-swl requested a review from a team as a code owner May 25, 2024 00:10
@mhess-swl mhess-swl changed the title Skip transactions older than the software version bug: Skip transactions older than the software version May 25, 2024
@mhess-swl mhess-swl changed the title bug: Skip transactions older than the software version fix: Skip transactions older than the software version May 25, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented May 25, 2024 •
edited

Node: Unit Test Results

  2 322 files  ±0    2 322 suites  ±0   2h 49m 27s ⏱️ - 5m 55s
119 371 tests +1  119 302 ✅ +1  69 💤 ±0  0 ❌ ±0 
127 914 runs  +1  127 845 ✅ +1  69 💤 ±0  0 ❌ ±0 

Results for commit a4bb316. ± Comparison against base commit 99545d7.

This pull request removes 999 and adds 757 tests. Note that renamed tests count towards both. 

  
             IssuerDN: CN=s-aaaa
            SubjectDN: CN=s-aaaa
           Final Date: Fri Jan 01 00:00:00 UTC 2100
           Public Key: RSA Public Key [2e:28:bc:1e:d3:83:25:92:8e:cb:98:b1:b6:84:06:9c:d5:d8:14:d5],[56:66:d1:a4]
           Start Date: Sat Jan 01 00:00:00 UTC 2000
         SerialNumber: 12482092706667292405
        modulus: c1a0ff5d2372b53d12d12bb87dd03f5…
   Address[id=0,nickname=7o64LfYD,selfName=aaaa,weight=1000,hostnameInternal=127.0.0.1,portInternalIpv4=37609,hostnameExternal=64.21.88.46,portExternalIpv4=37609,sigPublicKey=<null>,agreePublicKey=<null>,sigCert=com.swirlds.platform.crypto.SerializableX509Certificate@32e3d46e,agreeCert=com.swirlds.platform.crypto.SerializableX509Certificate@6b24093,memo=C9v0EClP],
…

com.hedera.node.app.grpc.impl.netty.GrpcServiceBuilderTest ‑ [4] 

com.hedera.node.app.grpc.impl.netty.GrpcServiceBuilderTest ‑ [6] 

com.hedera.node.app.grpc.impl.netty.GrpcServiceBuilderTest ‑ [7]   
  
com.hedera.node.app.state.merkle.StateMetadataTest ‑ [11] 

com.hedera.node.app.state.merkle.StateMetadataTest ‑ [203] Some Legal Characters 

com.hedera.node.app.state.merkle.StateMetadataTest ‑ [395] 
 Some Legal Characters
com.hedera.node.app.state.recordcache.RecordCacheImplTest$ReceiptQueryTests ‑ [100] TOKEN_HAS_NO_KYC_KEY
com.hedera.node.app.state.recordcache.RecordCacheImplTest$ReceiptQueryTests ‑ [101] INVALID_NODE_ID
com.hedera.node.app.state.recordcache.RecordCacheImplTest$ReceiptQueryTests ‑ [102] UPDATE_FILE_ID_DOES_NOT_MATCH_PREPARED
com.hedera.node.app.state.recordcache.RecordCacheImplTest$ReceiptQueryTests ‑ [103] CONTRACT_HAS_NO_AUTO_RENEW_ACCOUNT
…

♻️ This comment has been updated with latest results.

@github-actions GitHub Actions
Copy link

github-actions bot commented May 25, 2024 •
edited

Node: HAPI Test (Restart) Results

3 tests   3 ✅  6m 13s ⏱️
3 suites  0 💤
3 files    0 ❌

Results for commit a4bb316.

♻️ This comment has been updated with latest results.

@github-actions GitHub Actions
Copy link

github-actions bot commented May 25, 2024 •
edited

Node: HAPI Test (Misc) Results

 51 files   51 suites   24m 8s ⏱️
357 tests 357 ✅ 0 💤 0 ❌
374 runs  374 ✅ 0 💤 0 ❌

Results for commit a4bb316.

♻️ This comment has been updated with latest results.

@github-actions GitHub Actions
Copy link

github-actions bot commented May 25, 2024 •
edited

Node: HAPI Test (Node Death Reconnect) Results

3 tests   3 ✅  6m 16s ⏱️
3 suites  0 💤
3 files    0 ❌

Results for commit a4bb316.

♻️ This comment has been updated with latest results.

@github-actions GitHub Actions
Copy link

github-actions bot commented May 25, 2024 •
edited

Node: HAPI Test (Token) Results

 20 files   20 suites   6m 20s ⏱️
257 tests 257 ✅ 0 💤 0 ❌
260 runs  260 ✅ 0 💤 0 ❌

Results for commit a4bb316.

♻️ This comment has been updated with latest results.

@github-actions GitHub Actions
Copy link

github-actions bot commented May 25, 2024 •
edited

Node: HAPI Test (Crypto) Results

 23 files   23 suites   12m 38s ⏱️
350 tests 350 ✅ 0 💤 0 ❌
356 runs  356 ✅ 0 💤 0 ❌

Results for commit a4bb316.

♻️ This comment has been updated with latest results.

@github-actions GitHub Actions
Copy link

github-actions bot commented May 25, 2024 •
edited

Node: HAPI Test (Time Consuming) Results

19 tests   19 ✅  22m 5s ⏱️
 4 suites   0 💤
 4 files     0 ❌

Results for commit a4bb316.

♻️ This comment has been updated with latest results.

@github-actions GitHub Actions
Copy link

github-actions bot commented May 25, 2024 •
edited

Node: HAPI Test (Smart Contract) Results

 67 files   67 suites   23m 16s ⏱️
593 tests 593 ✅ 0 💤 0 ❌
620 runs  620 ✅ 0 💤 0 ❌

Results for commit a4bb316.

♻️ This comment has been updated with latest results.

povolev15
povolev15 previously approved these changes May 28, 2024
View reviewed changes
Copy link
Contributor

@povolev15 povolev15 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM TY @mhess-swl

@mhess-swl
Don't publish records to the record stream
863183d 
Signed-off-by: Matt Hess <matt.hess@swirldslabs.com>
tinker-michaelj
tinker-michaelj approved these changes May 28, 2024
View reviewed changes
Copy link
Collaborator

@tinker-michaelj tinker-michaelj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, tyvm @mhess-swl !

@mhess-swl mhess-swl merged commit d92fafb into develop May 28, 2024
44 of 45 checks passed
@mhess-swl mhess-swl deleted the 13487_skip-older-txns branch May 28, 2024 21:14
mhess-swl added a commit that referenced this pull request May 28, 2024
@mhess-swl
cherry-pick: Skip transactions older than the software version (#13527)
f677acb 
Signed-off-by: Matt Hess <matt.hess@swirldslabs.com>
@OlegMazurov OlegMazurov mentioned this pull request May 29, 2024
Closed
mhess-swl added a commit that referenced this pull request May 30, 2024
@mhess-swl @kimbor
fix: cherry-pick: Skip transactions older than the software version (#…
a44fb78 
…13527) (#13563)

Signed-off-by: Matt Hess <matt.hess@swirldslabs.com>
Co-authored-by: Kim Rader <kim.rader@swirldslabs.com>
bilyana-gospodinova pushed a commit that referenced this pull request Jun 13, 2024
@mhess-swl @bilyana-gospodinova
fix: Skip transactions older than the software version (#13527)
7627d79 
Signed-off-by: Matt Hess <matt.hess@swirldslabs.com>
Signed-off-by: Bilyana Gospodinova <bilyana.gospodinova14@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tinker-michaelj tinker-michaelj tinker-michaelj approved these changes

@povolev15 povolev15 povolev15 left review comments

@Neeharika-Sompalli Neeharika-Sompalli Awaiting requested review from Neeharika-Sompalli Neeharika-Sompalli is a code owner automatically assigned from hashgraph/hedera-base

Assignees

@mhess-swl mhess-swl

Labels
None yet
Projects
None yet
Milestone
v0.50
Development

Successfully merging this pull request may close these issues.

Transactions from a previous software version should be skipped
3 participants
@mhess-swl @povolev15 @tinker-michaelj