Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: cherry-pick: Skip transactions older than the software version (#13527) #13563

Merged
merged 2 commits into from
May 30, 2024
Merged

fix: cherry-pick: Skip transactions older than the software version (#13527) #13563

merged 2 commits into from
May 30, 2024

Conversation

mhess-swl
Copy link
Member

Cherry-pick of #13487 to release/0.50

@mhess-swl
cherry-pick: Skip transactions older than the software version (#13527)
f677acb 
Signed-off-by: Matt Hess <matt.hess@swirldslabs.com>
@mhess-swl mhess-swl self-assigned this May 28, 2024
@mhess-swl mhess-swl requested a review from a team as a code owner May 28, 2024 21:28
@mhess-swl mhess-swl changed the title cherry-pick: Skip transactions older than the software version (#13527) fix: cherry-pick: Skip transactions older than the software version (#13527) May 28, 2024
tinker-michaelj
tinker-michaelj approved these changes May 28, 2024
View reviewed changes
Copy link
Collaborator

@tinker-michaelj tinker-michaelj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, ty @mhess-swl !

@github-actions GitHub Actions
Copy link

github-actions bot commented May 28, 2024 •
edited
Loading

Node: HAPI Test (Restart) Results

2 tests   2 ✅  5m 19s ⏱️
2 suites  0 💤
2 files    0 ❌

Results for commit 3712b7c.

♻️ This comment has been updated with latest results.

@github-actions GitHub Actions
Copy link

github-actions bot commented May 28, 2024 •
edited
Loading

Node: HAPI Test (Node Death Reconnect) Results

2 tests   2 ✅  6m 37s ⏱️
2 suites  0 💤
2 files    0 ❌

Results for commit 3712b7c.

♻️ This comment has been updated with latest results.

@github-actions GitHub Actions
Copy link

github-actions bot commented May 28, 2024 •
edited
Loading

Node: HAPI Test (Token) Results

235 tests   233 ✅  19m 13s ⏱️
 17 suites    2 💤
 17 files      0 ❌

Results for commit 3712b7c.

♻️ This comment has been updated with latest results.

@github-actions GitHub Actions
Copy link

github-actions bot commented May 28, 2024 •
edited
Loading

Node: HAPI Test (Misc) Results

457 tests   447 ✅  40m 52s ⏱️
 77 suites   10 💤
 77 files      0 ❌

Results for commit 3712b7c.

♻️ This comment has been updated with latest results.

@github-actions GitHub Actions
Copy link

github-actions bot commented May 28, 2024 •
edited
Loading

Node: HAPI Test (Crypto) Results

335 tests   335 ✅  37m 18s ⏱️
 25 suites    0 💤
 25 files      0 ❌

Results for commit 3712b7c.

♻️ This comment has been updated with latest results.

@github-actions GitHub Actions
Copy link

github-actions bot commented May 28, 2024 •
edited
Loading

Node: HAPI Test (Time Consuming) Results

21 tests   21 ✅  54m 29s ⏱️
 3 suites   0 💤
 3 files     0 ❌

Results for commit 3712b7c.

♻️ This comment has been updated with latest results.

@github-actions GitHub Actions
Copy link

github-actions bot commented May 28, 2024 •
edited
Loading

Node: HAPI Test (Smart Contract) Results

592 tests   591 ✅  1h 21m 18s ⏱️
 63 suites    1 💤
 63 files      0 ❌

Results for commit 3712b7c.

♻️ This comment has been updated with latest results.

@github-actions GitHub Actions
Copy link

github-actions bot commented May 28, 2024 •
edited
Loading

Node: Unit Test Results

  2 270 files  ±0    2 270 suites  ±0   2h 12m 42s ⏱️ - 1h 6m 34s
112 362 tests +1  112 295 ✅ +1  67 💤 ±0  0 ❌ ±0 
120 825 runs  +1  120 758 ✅ +1  67 💤 ±0  0 ❌ ±0 

Results for commit 3712b7c. ± Comparison against base commit ae86107.

♻️ This comment has been updated with latest results.

@mhess-swl mhess-swl merged commit a44fb78 into release/0.50 May 30, 2024
43 checks passed
@mhess-swl mhess-swl deleted the 13487_versions-cherry-pick branch May 30, 2024 17:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kimbor kimbor kimbor approved these changes

@povolev15 povolev15 povolev15 approved these changes

@tinker-michaelj tinker-michaelj tinker-michaelj approved these changes

Assignees

@mhess-swl mhess-swl

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@mhess-swl @kimbor @povolev15 @tinker-michaelj