Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Properly handle old events in handleConsensusRound #6333

Closed
nickpoorman opened this issue May 1, 2023 · 4 comments · Fixed by #6663
Closed

Properly handle old events in handleConsensusRound #6333

nickpoorman opened this issue May 1, 2023 · 4 comments · Fixed by #6663
Assignees
Milestone

Comments

@nickpoorman
Copy link
Contributor

Once Platform team has implemented the pre-requisite for HIP-721: Add software version to events, we need to properly handle old events in handleConsensusRound.

By looking at the new software version contained in the events, when Services processes an event, it should determine if the event was generated by a previous version of the software, and if so, the transaction should fail and the user should get an error along the lines of "Please Retry" when they fetch the receipt for the transaction.

This needs to be done for mono-service and non-mono-service workflows.

@nickpoorman
Copy link
Contributor Author

nickpoorman commented May 12, 2023

As discussed on the Modularization call when @rbair23 was going over the new preHandle workflow, we'll need to figure out:

  1. Who gets charged for these failed transactions?
  2. What error do we want to put on the receipt so the user knows to retry the transaction again?
  3. Should this get checked in preHandle or only checked in handle?

@Neeharika-Sompalli
Copy link
Member

Changes are done, and need some other parts of this issue to be completed for testing the feature

@nickpoorman
Copy link
Contributor Author

Once preConsensus event stream is done, we can E2E test this.

@mhess-swl
Copy link
Member

mhess-swl commented May 24, 2023

Still waiting on #5682 before we can E2E test this. We need to check with @cody-littley on the timeline for that issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

3 participants