New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Handle old events #6663
Handle old events #6663
Conversation
Signed-off-by: Neeharika-Sompalli <neeharika.sompalli@swirldslabs.com>
Signed-off-by: Neeharika-Sompalli <neeharika.sompalli@swirldslabs.com>
Signed-off-by: Neeharika-Sompalli <neeharika.sompalli@swirldslabs.com>
Signed-off-by: Neeharika-Sompalli <neeharika.sompalli@swirldslabs.com>
Signed-off-by: Neeharika-Sompalli <neeharika.sompalli@swirldslabs.com>
...de/hedera-mono-service/src/main/java/com/hedera/node/app/service/mono/txns/ProcessLogic.java
Outdated
Show resolved
Hide resolved
...service/src/main/java/com/hedera/node/app/service/mono/state/logic/StandardProcessLogic.java
Outdated
Show resolved
Hide resolved
...service/src/main/java/com/hedera/node/app/service/mono/state/logic/StandardProcessLogic.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One comment on log.info()
, otherwise this all makes sense to me!
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## develop #6663 +/- ##
==============================================
+ Coverage 0 90.72% +90.72%
- Complexity 0 17701 +17701
==============================================
Files 0 1408 +1408
Lines 0 51076 +51076
Branches 0 5170 +5170
==============================================
+ Hits 0 46341 +46341
- Misses 0 3729 +3729
- Partials 0 1006 +1006
☔ View full report in Codecov by Sentry. |
Signed-off-by: Neeharika-Sompalli <neeharika.sompalli@swirldslabs.com>
Signed-off-by: Neeharika-Sompalli <neeharika.sompalli@swirldslabs.com>
Signed-off-by: Neeharika-Sompalli <neeharika.sompalli@swirldslabs.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All makes sense to me!
577ff19
Signed-off-by: Neeharika-Sompalli <neeharika.sompalli@swirldslabs.com>
…33-discard-old-events
SonarCloud Quality Gate failed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Fixes #6333
handleConsensusRound
BUSY
status to the TransactionReceipt and store in RecordCacheTesting: