Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle old events #6663

Merged
merged 21 commits into from May 24, 2023
Merged

Handle old events #6663

merged 21 commits into from May 24, 2023

Conversation

Neeharika-Sompalli
Copy link
Member

@Neeharika-Sompalli Neeharika-Sompalli commented May 18, 2023

Fixes #6333

  • Added a check to validate the software version of the event in handleConsensusRound
  • If the version is older add a BUSY status to the TransactionReceipt and store in RecordCache

Testing:

  • Unit Tests
  • End to End Tests

Signed-off-by: Neeharika-Sompalli <neeharika.sompalli@swirldslabs.com>
Signed-off-by: Neeharika-Sompalli <neeharika.sompalli@swirldslabs.com>
Signed-off-by: Neeharika-Sompalli <neeharika.sompalli@swirldslabs.com>
Signed-off-by: Neeharika-Sompalli <neeharika.sompalli@swirldslabs.com>
Signed-off-by: Neeharika-Sompalli <neeharika.sompalli@swirldslabs.com>
@github-actions
Copy link

github-actions bot commented May 18, 2023

Node: Unit Test Results

    1 408 files      1 408 suites   1h 17m 42s ⏱️
  98 615 tests   98 608 ✔️ 7 💤 0
103 780 runs  103 773 ✔️ 7 💤 0

Results for commit 692f9ef.

♻️ This comment has been updated with latest results.

@github-actions
Copy link

github-actions bot commented May 18, 2023

Node: Integration Test Results

    4 files      4 suites   13m 20s ⏱️
170 tests 170 ✔️ 0 💤 0
172 runs  172 ✔️ 0 💤 0

Results for commit 692f9ef.

♻️ This comment has been updated with latest results.

@github-actions
Copy link

github-actions bot commented May 18, 2023

Node: E2E Test Results

    1 files      1 suites   18m 19s ⏱️
310 tests 310 ✔️ 0 💤 0
328 runs  328 ✔️ 0 💤 0

Results for commit 692f9ef.

♻️ This comment has been updated with latest results.

Signed-off-by: Neeharika-Sompalli <neeharika.sompalli@swirldslabs.com>
Signed-off-by: Neeharika-Sompalli <neeharika.sompalli@swirldslabs.com>
Copy link
Collaborator

@tinker-michaelj tinker-michaelj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One comment on log.info(), otherwise this all makes sense to me!

@codecov
Copy link

codecov bot commented May 22, 2023

Codecov Report

Patch coverage: 94.11% and project coverage change: +90.72 🎉

Comparison is base (25fdbf6) 0.00% compared to head (577ff19) 90.72%.

❗ Current head 577ff19 differs from pull request most recent head 692f9ef. Consider uploading reports for the commit 692f9ef to get more accurate results

Additional details and impacted files
@@              Coverage Diff               @@
##             develop    #6663       +/-   ##
==============================================
+ Coverage           0   90.72%   +90.72%     
- Complexity         0    17701    +17701     
==============================================
  Files              0     1408     +1408     
  Lines              0    51076    +51076     
  Branches           0     5170     +5170     
==============================================
+ Hits               0    46341    +46341     
- Misses             0     3729     +3729     
- Partials           0     1006     +1006     
Impacted Files Coverage Δ
...service/mono/state/logic/StandardProcessLogic.java 96.82% <83.33%> (ø)
...e/mono/context/properties/SerializableSemVers.java 97.08% <95.23%> (ø)
.../app/workflows/handle/AdaptedMonoProcessLogic.java 85.36% <100.00%> (ø)
...era/node/app/service/mono/records/RecordCache.java 100.00% <100.00%> (ø)
...edera/node/app/service/mono/txns/ProcessLogic.java 100.00% <100.00%> (ø)

... and 1403 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Signed-off-by: Neeharika-Sompalli <neeharika.sompalli@swirldslabs.com>
Signed-off-by: Neeharika-Sompalli <neeharika.sompalli@swirldslabs.com>
Signed-off-by: Neeharika-Sompalli <neeharika.sompalli@swirldslabs.com>
Signed-off-by: Neeharika-Sompalli <neeharika.sompalli@swirldslabs.com>
Signed-off-by: Neeharika-Sompalli <neeharika.sompalli@swirldslabs.com>
Copy link
Collaborator

@tinker-michaelj tinker-michaelj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All makes sense to me!

mhess-swl
mhess-swl previously approved these changes May 23, 2023
Signed-off-by: Neeharika-Sompalli <neeharika.sompalli@swirldslabs.com>
mhess-swl
mhess-swl previously approved these changes May 23, 2023
@sonarcloud
Copy link

sonarcloud bot commented May 24, 2023

SonarCloud Quality Gate failed.    Quality Gate failed

Bug B 1 Bug
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

95.0% 95.0% Coverage
0.0% 0.0% Duplication

Copy link
Collaborator

@tinker-michaelj tinker-michaelj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Neeharika-Sompalli Neeharika-Sompalli merged commit dad10e1 into develop May 24, 2023
14 of 16 checks passed
@Neeharika-Sompalli Neeharika-Sompalli deleted the 6333-discard-old-events branch May 24, 2023 17:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Properly handle old events in handleConsensusRound
7 participants