Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Retire old security model for smart contracts #6767

Closed
david-bakin-sl opened this issue May 24, 2023 · 1 comment · Fixed by #7055
Closed

Retire old security model for smart contracts #6767

david-bakin-sl opened this issue May 24, 2023 · 1 comment · Fixed by #7055
Assignees
@david-bakin-sl
Milestone
v0.39

Comments

@david-bakin-sl
Copy link
Member

When new and improved security model introduced there was a "grandfather" period for older contracts, to give contract owners (development organizations) time to adjust to the new model. That period is ending, so turn off the old security model.
@david-bakin-sl david-bakin-sl self-assigned this May 24, 2023
@david-bakin-sl david-bakin-sl added this to the v0.39 milestone May 24, 2023
This was referenced May 24, 2023
Closed
Merged
@david-bakin-sl david-bakin-sl mentioned this issue Jun 6, 2023
Merged
2 tasks
david-bakin-sl added a commit that referenced this issue Jun 12, 2023
@david-bakin-sl @stoqnkpL
Retire old security model for smart contracts by changing HAPI signat…
666b607 
…ure-check block limit to LOW (#6960)

- Set `contracts.maxNumWithHapiSigsSuccess` to `0` to disable old security model.
- Ensure (appropriate) unit tests check both low and high limits.
    * In fact the unit tests don't test this feature at all, just have to be corrected for mockability.
- "Fix" BDD tests by ... making them pass for the V1 security model
    - ⮕ Does **not** have new BDD tests for the V2 security model to _replace_ the ones that now really only work for the V1 security model
      - There are some of those created when the V2 security model was created but there needs to be a more comprehensive set
    - ⮕ Does **not** confirm that _negative_ tests in the same affected suites (or elsewhere for that matter) return failure (that is, the transaction returns failure so the test returns success) _for the right reason_.
      - I.e., some of them may now be failing due to a V2 security model violation and _not_ because of the reason they're _supposed_ to fail

Addresses #6767 

Signed-off-by: David Bakin <117694041+david-bakin-sl@users.noreply.github.com>
Signed-off-by: Stoyan Panayotov <stoyan.panayotov@limechain.tech>
Co-authored-by: Stoyan Panayotov <stoyan.panayotov@limechain.tech>
@david-bakin-sl david-bakin-sl mentioned this issue Jun 12, 2023
Merged
2 tasks
@david-bakin-sl david-bakin-sl linked a pull request Jun 12, 2023 that will close this issue
Cherry pick to 0.39: Retire old security model for smart contracts by changing HAPI signature-check block limit to LOW #7055
Merged
2 tasks
@david-bakin-sl
Copy link
Member Author

(see that comment right above "david-bakin-sl linked a pull request yesterday that will close this issue"? well, that PR was merged and it didn't close this issue. what's up with that, Github? closing it manually)

edward-swirldslabs pushed a commit that referenced this issue Jun 14, 2023
@david-bakin-sl @stoqnkpL @edward-swirldslabs
Retire old security model for smart contracts by changing HAPI signat…
dd06a77 
…ure-check block limit to LOW (#6960)

- Set `contracts.maxNumWithHapiSigsSuccess` to `0` to disable old security model.
- Ensure (appropriate) unit tests check both low and high limits.
    * In fact the unit tests don't test this feature at all, just have to be corrected for mockability.
- "Fix" BDD tests by ... making them pass for the V1 security model
    - ⮕ Does **not** have new BDD tests for the V2 security model to _replace_ the ones that now really only work for the V1 security model
      - There are some of those created when the V2 security model was created but there needs to be a more comprehensive set
    - ⮕ Does **not** confirm that _negative_ tests in the same affected suites (or elsewhere for that matter) return failure (that is, the transaction returns failure so the test returns success) _for the right reason_.
      - I.e., some of them may now be failing due to a V2 security model violation and _not_ because of the reason they're _supposed_ to fail

Addresses #6767 

Signed-off-by: David Bakin <117694041+david-bakin-sl@users.noreply.github.com>
Signed-off-by: Stoyan Panayotov <stoyan.panayotov@limechain.tech>
Co-authored-by: Stoyan Panayotov <stoyan.panayotov@limechain.tech>
agadzhalov pushed a commit that referenced this issue Jun 26, 2023
@david-bakin-sl @stoqnkpL @agadzhalov
Retire old security model for smart contracts by changing HAPI signat…
570f93c 
…ure-check block limit to LOW (#6960)

- Set `contracts.maxNumWithHapiSigsSuccess` to `0` to disable old security model.
- Ensure (appropriate) unit tests check both low and high limits.
    * In fact the unit tests don't test this feature at all, just have to be corrected for mockability.
- "Fix" BDD tests by ... making them pass for the V1 security model
    - ⮕ Does **not** have new BDD tests for the V2 security model to _replace_ the ones that now really only work for the V1 security model
      - There are some of those created when the V2 security model was created but there needs to be a more comprehensive set
    - ⮕ Does **not** confirm that _negative_ tests in the same affected suites (or elsewhere for that matter) return failure (that is, the transaction returns failure so the test returns success) _for the right reason_.
      - I.e., some of them may now be failing due to a V2 security model violation and _not_ because of the reason they're _supposed_ to fail

Addresses #6767

Signed-off-by: David Bakin <117694041+david-bakin-sl@users.noreply.github.com>
Signed-off-by: Stoyan Panayotov <stoyan.panayotov@limechain.tech>
Co-authored-by: Stoyan Panayotov <stoyan.panayotov@limechain.tech>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@david-bakin-sl david-bakin-sl

Labels
None yet
Projects
Smart Contract Sprint Board
Archived in project
Milestone
v0.39
1 participant
@david-bakin-sl