Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sec/sync metric isn't being populated with SAP enabled #7612

Closed
alittley opened this issue Jul 19, 2023 · 2 comments · Fixed by #7613
Closed

sec/sync metric isn't being populated with SAP enabled #7612

alittley opened this issue Jul 19, 2023 · 2 comments · Fixed by #7613
Assignees
@alittley
Labels
Bug An error that causes the feature to behave differently than what was expected based on design.
Milestone
v0.41

Comments

@alittley
Copy link
Contributor

alittley commented Jul 19, 2023 •
edited

  • figure out why sec/sync isn't showing any results with SAP enabled
@alittley alittley added the Bug An error that causes the feature to behave differently than what was expected based on design. label Jul 19, 2023
@alittley alittley self-assigned this Jul 19, 2023
@alittley alittley added this to the v0.41 milestone Jul 19, 2023
@alittley
Copy link
Contributor Author

Bug introduced in #6607

@alittley
Copy link
Contributor Author

The bug is that SyncMetrics are being constructed twice: once in SwirldsPlatform, and once in AbstractGossip

@alittley alittley mentioned this issue Jul 19, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@alittley alittley

Labels
Bug An error that causes the feature to behave differently than what was expected based on design.
Projects
None yet
Milestone
v0.41
Development

Successfully merging a pull request may close this issue.

Fix sync metric bug hashgraph/hedera-services
1 participant
@alittley