Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

5931 gossip encapsulation #6607

Merged
merged 34 commits into from May 22, 2023
Merged

5931 gossip encapsulation #6607

merged 34 commits into from May 22, 2023

Conversation

cody-littley
Copy link
Contributor

Closes #5931

@cody-littley
Added skeleton gossip classes.
6844548 
Signed-off-by: Cody Littley <cody@swirldslabs.com>
@cody-littley
Incremental progress
1061fb1 
Signed-off-by: Cody Littley <cody@swirldslabs.com>
@cody-littley cody-littley self-assigned this May 15, 2023
@cody-littley
Add files that were forgotton.
ed038be 
Signed-off-by: Cody Littley <cody@swirldslabs.com>
@cody-littley
Merge branch 'develop' into 005931-gossip-construction-2
729318f 
Signed-off-by: Cody Littley <cody@swirldslabs.com>
@cody-littley
added TODO
fa4ac74 
Signed-off-by: Cody Littley <cody@swirldslabs.com>
@cody-littley
Incremental progress.
e88ac38 
Signed-off-by: Cody Littley <cody@swirldslabs.com>
@cody-littley
Merge branch 'develop' into 005931-gossip-construction-2
dbc0ffe 
Signed-off-by: Cody Littley <cody@swirldslabs.com>
@cody-littley
Incremental progress
1448331 
Signed-off-by: Cody Littley <cody@swirldslabs.com>
@cody-littley
Cleanup.
a73a15c 
Signed-off-by: Cody Littley <cody@swirldslabs.com>
@cody-littley
Remove ping transaction.
ced0750 
Signed-off-by: Cody Littley <cody@swirldslabs.com>
@cody-littley
Encapsulate some reconnect stuff.
2fcf271 
Signed-off-by: Cody Littley <cody@swirldslabs.com>
@cody-littley
Move more junk into the gossip classes.
4f91d2a 
Signed-off-by: Cody Littley <cody@swirldslabs.com>
@cody-littley
Make last variables final.
db969e5 
Signed-off-by: Cody Littley <cody@swirldslabs.com>
@cody-littley
Fix nullptr
c2e54b9 
Signed-off-by: Cody Littley <cody@swirldslabs.com>
@cody-littley
Normalize argument order.
4e21fb7 
Signed-off-by: Cody Littley <cody@swirldslabs.com>
@github-actions
Copy link

github-actions bot commented May 16, 2023 •
edited

Node: Unit Test Results

    1 408 files      1 408 suites   1h 7m 14s ⏱️
  98 607 tests   98 600 ✔️ 7 💤 0 ❌
103 772 runs  103 765 ✔️ 7 💤 0 ❌

Results for commit a42b026.

♻️ This comment has been updated with latest results.

@github-actions
Copy link

github-actions bot commented May 16, 2023 •
edited

Node: E2E Test Results

    1 files      1 suites   17m 46s ⏱️
310 tests 310 ✔️ 0 💤 0 ❌
328 runs  328 ✔️ 0 💤 0 ❌

Results for commit a42b026.

♻️ This comment has been updated with latest results.

@cody-littley
misc cleanup
e0f7503 
Signed-off-by: Cody Littley <cody@swirldslabs.com>
@github-actions
Copy link

github-actions bot commented May 16, 2023 •
edited

Node: Integration Test Results

    4 files      4 suites   13m 44s ⏱️
170 tests 170 ✔️ 0 💤 0 ❌
172 runs  172 ✔️ 0 💤 0 ❌

Results for commit a42b026.

♻️ This comment has been updated with latest results.

@github-actions
Copy link

github-actions bot commented May 16, 2023 •
edited

Platform: JUnit Test Report

     524 files           1 errors  523 suites   17m 34s ⏱️
13 823 tests 13 787 ✔️ 36 💤 0 ❌
15 808 runs  15 772 ✔️ 36 💤 0 ❌

Results for commit a42b026.

♻️ This comment has been updated with latest results.

@cody-littley
Fixed flaky unit test.
45527fc 
Signed-off-by: Cody Littley <cody@swirldslabs.com>
@cody-littley
Fix bug, cleanup
3768eaa 
Signed-off-by: Cody Littley <cody@swirldslabs.com>
@codecov
Copy link

codecov bot commented May 17, 2023 •
edited

Codecov Report

Patch coverage has no change and project coverage change: +22.70 🎉

Comparison is base (a92eb10) 68.05% compared to head (a42b026) 90.76%.

Additional details and impacted files 
@@              Coverage Diff               @@
##             develop    #6607       +/-   ##
==============================================
+ Coverage      68.05%   90.76%   +22.70%     
+ Complexity     22736    17698     -5038     
==============================================
  Files           2111     1408      -703     
  Lines         137666    51027    -86639     
  Branches        7861     5163     -2698     
==============================================
- Hits           93694    46316    -47378     
+ Misses         42421     3707    -38714     
+ Partials        1551     1004      -547

see 939 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@cody-littley
Split single node sync into its own class.
179b6a9 
Signed-off-by: Cody Littley <cody@swirldslabs.com>
@cody-littley
Merge branch 'develop' into 005931-gossip-construction-2
3e52c65 
Signed-off-by: Cody Littley <cody@swirldslabs.com>
@cody-littley
Fix startup sequence.
0e592ca 
Signed-off-by: Cody Littley <cody@swirldslabs.com>
@cody-littley
Fixed more startup stuff.
3e99e9a 
Signed-off-by: Cody Littley <cody@swirldslabs.com>
@cody-littley
Cleanup.
ae72f6d 
Signed-off-by: Cody Littley <cody@swirldslabs.com>
@cody-littley
Merge branch 'develop' into 005931-gossip-construction-2
27e16c1 
Signed-off-by: Cody Littley <cody@swirldslabs.com>
@cody-littley
Made suggested changes.
33a38f8 
Signed-off-by: Cody Littley <cody@swirldslabs.com>
edward-swirldslabs
edward-swirldslabs reviewed May 19, 2023
View reviewed changes
platform-sdk/swirlds-platform-core/src/main/java/com/swirlds/platform/PlatformConstructor.java Outdated Show resolved Hide resolved
platform-sdk/swirlds-platform-core/src/main/java/com/swirlds/platform/SwirldsPlatform.java Outdated Show resolved Hide resolved
platform-sdk/swirlds-platform-core/src/main/java/com/swirlds/platform/SwirldsPlatform.java Outdated Show resolved Hide resolved
platform-sdk/swirlds-platform-core/src/main/java/com/swirlds/platform/SwirldsPlatform.java Show resolved Hide resolved
platform-sdk/swirlds-platform-core/src/main/java/com/swirlds/platform/SwirldsPlatform.java Show resolved Hide resolved
...k/swirlds-platform-core/src/main/java/com/swirlds/platform/gossip/chatter/ChatterGossip.java Show resolved Hide resolved
...k/swirlds-platform-core/src/main/java/com/swirlds/platform/gossip/sync/LegacySyncGossip.java Show resolved Hide resolved
...irlds-platform-core/src/main/java/com/swirlds/platform/gossip/sync/SingleNodeSyncGossip.java Outdated Show resolved Hide resolved
alittley
alittley reviewed May 19, 2023
View reviewed changes
platform-sdk/sdk/settings.txt Outdated Show resolved Hide resolved
...k/swirlds-platform-core/src/main/java/com/swirlds/platform/gossip/chatter/ChatterGossip.java Outdated Show resolved Hide resolved
...form-sdk/swirlds-platform-core/src/main/java/com/swirlds/platform/gossip/AbstractGossip.java Outdated Show resolved Hide resolved
...form-sdk/swirlds-platform-core/src/main/java/com/swirlds/platform/gossip/AbstractGossip.java Outdated Show resolved Hide resolved
...form-sdk/swirlds-platform-core/src/main/java/com/swirlds/platform/gossip/AbstractGossip.java Outdated Show resolved Hide resolved
...irlds-platform-core/src/main/java/com/swirlds/platform/gossip/sync/SingleNodeSyncGossip.java Show resolved Hide resolved
...form-sdk/swirlds-platform-core/src/main/java/com/swirlds/platform/gossip/AbstractGossip.java Show resolved Hide resolved
.../swirlds-platform-core/src/main/java/com/swirlds/platform/reconnect/ReconnectController.java Outdated Show resolved Hide resolved
platform-sdk/swirlds-platform-core/src/main/java/com/swirlds/platform/SwirldsPlatform.java Show resolved Hide resolved
...s-unit-tests/common/swirlds-common-test/src/test/java/com/swirlds/common/test/UnitTests.java Outdated Show resolved Hide resolved
@cody-littley
Made suggested changes.
9459ab9 
Signed-off-by: Cody Littley <cody@swirldslabs.com>
@cody-littley
Fixed behavior with just one node.
c24e020 
Signed-off-by: Cody Littley <cody@swirldslabs.com>
alittley
alittley requested changes May 22, 2023
View reviewed changes
...form-sdk/swirlds-platform-core/src/main/java/com/swirlds/platform/gossip/AbstractGossip.java Outdated Show resolved Hide resolved
...form-sdk/swirlds-platform-core/src/main/java/com/swirlds/platform/gossip/AbstractGossip.java Outdated Show resolved Hide resolved
...form-sdk/swirlds-platform-core/src/main/java/com/swirlds/platform/gossip/AbstractGossip.java Outdated Show resolved Hide resolved
...form-sdk/swirlds-platform-core/src/main/java/com/swirlds/platform/gossip/AbstractGossip.java Outdated Show resolved Hide resolved
...k/swirlds-platform-core/src/main/java/com/swirlds/platform/gossip/sync/LegacySyncGossip.java Outdated Show resolved Hide resolved
...irlds-platform-core/src/main/java/com/swirlds/platform/gossip/sync/SingleNodeSyncGossip.java Outdated Show resolved Hide resolved
...irlds-platform-core/src/main/java/com/swirlds/platform/gossip/sync/SingleNodeSyncGossip.java Outdated Show resolved Hide resolved
platform-sdk/swirlds-platform-core/src/main/java/com/swirlds/platform/SwirldsPlatform.java Outdated Show resolved Hide resolved
@alittley alittley self-requested a review May 22, 2023 14:52
@edward-swirldslabs edward-swirldslabs mentioned this pull request May 22, 2023
Merged
lpetrovic05
lpetrovic05 previously approved these changes May 22, 2023
View reviewed changes
poulok
poulok previously approved these changes May 22, 2023
View reviewed changes
@cody-littley
Merge branch 'develop' into 005931-gossip-construction-2
fdbd95a 
Signed-off-by: Cody Littley <cody@swirldslabs.com>
@cody-littley
Made suggested changes
a42b026 
Signed-off-by: Cody Littley <cody@swirldslabs.com>
@sonarcloud
Copy link

sonarcloud bot commented May 22, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@sonarcloud
Copy link

sonarcloud bot commented May 22, 2023

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

2.4% 2.4% Coverage
6.3% 6.3% Duplication

@cody-littley cody-littley merged commit 6057902 into develop May 22, 2023
22 of 25 checks passed
@cody-littley cody-littley deleted the 005931-gossip-construction-2 branch May 22, 2023 21:01
@alittley alittley mentioned this pull request Jul 19, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@imalygin imalygin imalygin approved these changes

@alittley alittley alittley approved these changes

@edward-swirldslabs edward-swirldslabs edward-swirldslabs approved these changes

@lpetrovic05 lpetrovic05 lpetrovic05 left review comments

@poulok poulok poulok left review comments

@timo0 timo0 Awaiting requested review from timo0 timo0 is a code owner automatically assigned from hashgraph/platform-base

@deepak-swirlds deepak-swirlds Awaiting requested review from deepak-swirlds deepak-swirlds is a code owner automatically assigned from hashgraph/platform-data

Assignees

@cody-littley cody-littley

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Cleanup instantiation of gossip
6 participants
@cody-littley @imalygin @lpetrovic05 @poulok @alittley @edward-swirldslabs