Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

EmergencyReconnect isn't compatible with current PlatformStatus state machine #7688

Closed
alittley opened this issue Jul 25, 2023 · 0 comments · Fixed by #7725
Closed

EmergencyReconnect isn't compatible with current PlatformStatus state machine #7688

alittley opened this issue Jul 25, 2023 · 0 comments · Fixed by #7725
Assignees
@alittley
Labels
Bug An error that causes the feature to behave differently than what was expected based on design.
Milestone
v0.42

Comments

@alittley
Copy link
Contributor

alittley commented Jul 25, 2023 •
edited

The PlatformStatus state machine was built with the assumption that a reconnect will only occur from the BEHIND status.

In the case of an emergency reconnect, the reconnecting node doesn't consider itself to be "behind", so an IllegalPlatformStatusException is thrown when a ReconnectCompleteAction is processed from the OBSERVING status
@alittley alittley added the Bug An error that causes the feature to behave differently than what was expected based on design. label Jul 25, 2023
@alittley alittley added this to the v0.41 milestone Jul 25, 2023
@alittley alittley self-assigned this Jul 25, 2023
@alittley alittley mentioned this issue Jul 27, 2023
Merged
@poulok poulok mentioned this issue Jul 31, 2023
Closed
@poulok poulok modified the milestones: v0.41, v0.42 Aug 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@alittley alittley

Labels
Bug An error that causes the feature to behave differently than what was expected based on design.
Projects
None yet
Milestone
v0.42
Development

Successfully merging a pull request may close this issue.

Consider emergency reconnect in PlatformStatus system hashgraph/hedera-services
2 participants
@poulok @alittley