Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consider emergency reconnect in PlatformStatus system #7725

Merged
merged 6 commits into from Aug 4, 2023
Merged

Consider emergency reconnect in PlatformStatus system #7725

merged 6 commits into from Aug 4, 2023

Conversation

alittley
Copy link
Contributor

@alittley
Consider emergency reconnect in PlatformStatus system
56c6fe0 
Signed-off-by: Austin Littley <austin@swirldslabs.com>
@alittley alittley self-assigned this Jul 27, 2023
@alittley alittley added this to the v0.42 milestone Jul 27, 2023
@github-actions
Copy link

github-actions bot commented Jul 27, 2023 •
edited

Node: Unit Test Results

    1 592 files      1 592 suites   15m 2s ⏱️
103 144 tests 103 135 ✔️ 9 💤 0 ❌
109 544 runs  109 535 ✔️ 9 💤 0 ❌

Results for commit 47e94cc.

♻️ This comment has been updated with latest results.

@alittley alittley marked this pull request as ready for review July 27, 2023 20:23
@alittley alittley requested review from a team as code owners July 27, 2023 20:23
@github-actions
Copy link

github-actions bot commented Jul 27, 2023 •
edited

Node: E2E Test Results

    1 files      1 suites   17m 48s ⏱️
310 tests 310 ✔️ 0 💤 0 ❌
328 runs  328 ✔️ 0 💤 0 ❌

Results for commit 47e94cc.

♻️ This comment has been updated with latest results.

@github-actions
Copy link

github-actions bot commented Jul 27, 2023 •
edited

Node: Integration Test Results

278 tests   278 ✔️  32m 33s ⏱️
    5 suites      0 💤
    5 files        0 ❌

Results for commit 47e94cc.

♻️ This comment has been updated with latest results.

@github-actions
Copy link

github-actions bot commented Jul 27, 2023 •
edited

Platform: JUnit Test Report

     551 files           1 errors  550 suites   23m 40s ⏱️
14 051 tests 14 024 ✔️ 27 💤 0 ❌
16 101 runs  16 074 ✔️ 27 💤 0 ❌

Results for commit 47e94cc.

♻️ This comment has been updated with latest results.

@codecov
Copy link

codecov bot commented Jul 31, 2023 •
edited

Codecov Report

❗ No coverage uploaded for pull request base (develop@f1e0bed). Click here to learn what that means.
Patch has no changes to coverable lines.

❗ Current head 34651a8 differs from pull request most recent head 47e94cc. Consider uploading reports for the commit 47e94cc to get more accurate results

Additional details and impacted files 
@@            Coverage Diff             @@
##             develop    #7725   +/-   ##
==========================================
  Coverage           ?   89.12%           
  Complexity         ?    20257           
==========================================
  Files              ?     1609           
  Lines              ?    60727           
  Branches           ?     6414           
==========================================
  Hits               ?    54125           
  Misses             ?     5214           
  Partials           ?     1388

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@alittley
Merge branch 'develop' into 07688-emergency-reconnect-status
3904a4e 
Signed-off-by: Austin Littley <austin@swirldslabs.com>
@alittley
Adjust javadoc
47e94cc 
Signed-off-by: Austin Littley <austin@swirldslabs.com>
@sonarcloud
Copy link

sonarcloud bot commented Aug 2, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@sonarcloud
Copy link

sonarcloud bot commented Aug 2, 2023

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

91.3% 91.3% Coverage
49.7% 49.7% Duplication

idea Catch issues before they fail your Quality Gate with our IDE extension sonarlint SonarLint

@alittley alittley requested a review from poulok August 3, 2023 14:46
@alittley alittley merged commit d90c876 into develop Aug 4, 2023
14 of 15 checks passed
@alittley alittley deleted the 07688-emergency-reconnect-status branch August 4, 2023 16:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cody-littley cody-littley cody-littley approved these changes

@edward-swirldslabs edward-swirldslabs edward-swirldslabs approved these changes

@timo0 timo0 Awaiting requested review from timo0 timo0 is a code owner automatically assigned from hashgraph/platform-base

@deepak-swirlds deepak-swirlds Awaiting requested review from deepak-swirlds deepak-swirlds is a code owner automatically assigned from hashgraph/platform-data

@lpetrovic05 lpetrovic05 Awaiting requested review from lpetrovic05

@poulok poulok Awaiting requested review from poulok

Assignees

@alittley alittley

Labels
None yet
Projects
None yet
Milestone
v0.42
Development

Successfully merging this pull request may close these issues.

EmergencyReconnect isn't compatible with current PlatformStatus state machine
4 participants
@alittley @cody-littley @poulok @edward-swirldslabs