Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Protobuf migration #883

Closed
1 task done
donaldthibeau opened this issue Dec 16, 2020 · 0 comments
Closed
1 task done

Protobuf migration #883

donaldthibeau opened this issue Dec 16, 2020 · 0 comments
Assignees
Milestone

Comments

@donaldthibeau
Copy link
Contributor

donaldthibeau commented Dec 16, 2020

Requirements

  • Maintain protobuf as a standalone repo as a single source of truth. This makes it easier to consume via embedding withinn broader services repo.
  • Set one tag for the protobuf repo which automates update to preview net and a second tag which updates to locations like maven.
  • This will allow for both single source of truth as well as the ability to push into more consumable locations.

Decision 1/7/2021:

  • The hedera-protobuf repo will be used as the single source of truth for all hedera protobuf files including HAPI and mirror node
  • This allows the aggregation of multiple components, independent reviews not tied to services code, and accessible for all languages
  • hedera-services repo will reference the hedera-protobuf repository for protobufs and will not be referenced within the hedera-services repo

TODO:

  • Proposal on the structure of the hedera-protobuf repo for both HAPI and mirror node protobufs
@donaldthibeau donaldthibeau added Bug An error that causes the feature to behave differently than what was expected based on design. and removed Bug An error that causes the feature to behave differently than what was expected based on design. labels Dec 16, 2020
@noshmody noshmody added this to the Hedera 0.12.0 milestone Jan 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

7 participants