Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Externalize language-agnostic *.proto in a new repo to be single-source-of-truth #942

Closed
tinker-michaelj opened this issue Jan 8, 2021 · 1 comment

Comments

@tinker-michaelj
Copy link
Collaborator

tinker-michaelj commented Jan 8, 2021

Summary
The only officially published protobuf assets are in the hapi-proto/ directory of the hashgraph/hedera-services repo and the com.hedera.hashgraph:hedera-protobuf-java-api:* artifacts deployed to Maven Central.

However, the correctness of these *.proto files depend on Java-specific protobuf options, such as,

option java_package = "com.hederahashgraph.api.proto.java";
option java_multiple_files = true;

Therefore, for example, a Go developer cannot use these *.proto files as-is. (Other options may need to be added.)

Possible resolution

  • Repurpose the hashgraph/hedera-protobuf GitHub repository to be a source of *.proto files that work for all supported languages.
    • However, do not include any build system-related assets in this repo.
  • Adapt the Hedera Services codebase as needed to work with these protobufs.
@tinker-michaelj
Copy link
Collaborator Author

Effective duplicate of #883.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant