Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add memo field for file entity #962

Closed
donaldthibeau opened this issue Jan 14, 2021 · 1 comment · Fixed by #1066
Closed

Add memo field for file entity #962

donaldthibeau opened this issue Jan 14, 2021 · 1 comment · Fixed by #1066
Assignees
Milestone

Comments

@donaldthibeau
Copy link
Contributor

Summary
Each file entity should include an optional memo field of up to 100 bytes. Uniqueness is not guaranteed. The memo can only be changed by the admin keys on the file entity.

Memo field would be returned as part of file info.

@donaldthibeau
Copy link
Contributor Author

So to summarize, for an entity type of X we will say that for the CreateX transaction:
• TransactionBody contains a memo describing the create transaction. This goes in the receipt (and so in the record)
• XBody contains a memo that will be copied to the new entity
• If X is Schedule then the scheduled transaction will contain its own memo (or 2 memos if it is a Create transaction) which will have the described effects when it executes. (A CreateScheduled cannot contain another CreateScheduled, so there won't be further nested memos)
All the above is also true for an UpdateX transaction.
If that's the plan, then everything is current ok, except:
• TransactionBody should have a better comment (specifying length in bytes)
• CreateAccount needs another memo, to be similar to other Create transactions.
NOTE: Any CreateX transaction should have memos defined as a protobuf string, but any UpdateX transaction should define the memo as a StringValue. That is needed so that we can tell the difference between leaving it out (and so not changing it) vs. putting it in with an empty string (and so changing it to the empty string).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants