Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add memo to file entity type #1064

Closed
wants to merge 141 commits into from
Closed

Add memo to file entity type #1064

wants to merge 141 commits into from

Conversation

tinker-michaelj
Copy link
Collaborator

Related issue(s):

Summary of the change:

  • Add memo field to JFileInfo -> HFileMeta type, update serdes version.
  • Add memo syntax checks in file create/update transition logics.
  • Respect memo in create/update transition logic.
  • Incorporate memo size in fee calculations, refactoring to follow the new estimate pattern.

External impacts:
Will cause a very small increase in fees charged for some FileCreate and FileUpdate operations.

georgiyazovaliiski and others added 30 commits December 17, 2020 16:11
@georgiyazovaliiski
Foundations of transition logics
15dd644 
Signed-off-by: Georgi Yazovaliyski <georgi.yazovaliiski@gmail.com>
@georgiyazovaliiski
Merge branch 'feature/scheduled-txns/store-internal' into feature/sch…
d297fa1 
…eduled-txns/transition-logics
@georgiyazovaliiski
Transition Logics and Tests
605fd9a 
Signed-off-by: Georgi Yazovaliyski <georgi.yazovaliiski@gmail.com>
@georgiyazovaliiski
Cleanup
ecb0c02 
Signed-off-by: Georgi Yazovaliyski <georgi.yazovaliiski@gmail.com>
@georgiyazovaliiski
Key encoding check
a62dce5 
Signed-off-by: Georgi Yazovaliyski <georgi.yazovaliiski@gmail.com>
@georgiyazovaliiski
Merge branch 'feature/scheduled-txs/store/structure' into feature/sch…
dd00f59 
…eduled-txns/transition-logics
@georgiyazovaliiski
Logics change and unnecessary stuff removal
a2441f5 
Signed-off-by: Georgi Yazovaliyski <georgi.yazovaliiski@gmail.com>
@georgiyazovaliiski
Full test coverage
3c2396e 
Signed-off-by: Georgi Yazovaliyski <georgi.yazovaliiski@gmail.com>
@georgiyazovaliiski
Unit Testing and method refactoring
2cf84f5 
Signed-off-by: Georgi Yazovaliyski <georgi.yazovaliiski@gmail.com>
@failfmi
test: verify parameters
ab7df3f 
add additional tests for coverage

Signed-off-by: failfmi <oscurocalma@gmail.com>
@failfmi
test(create): remove any
5204e26 
Signed-off-by: failfmi <oscurocalma@gmail.com>
@georgiyazovaliiski
Full unit test coverage for Schedule Transition Logics
e8f76f9 
Signed-off-by: Georgi Yazovaliyski <georgi.yazovaliiski@gmail.com>
@georgiyazovaliiski
PR Comments resolution
a99d6d3 
Signed-off-by: Georgi Yazovaliyski <georgi.yazovaliiski@gmail.com>
@Daniel-K-Ivanov
resolve some comments from pr
287661b 
Signed-off-by: Daniel Ivanov <daniel.k.ivanov95@gmail.com>
@Daniel-K-Ivanov
resolve one more comment from PR
ebc2d34 
Signed-off-by: Daniel Ivanov <daniel.k.ivanov95@gmail.com>
@Daniel-K-Ivanov
resolve yet another comment from PR
40c2d5e 
Signed-off-by: Daniel Ivanov <daniel.k.ivanov95@gmail.com>
@georgiyazovaliiski
PR Comments resolution - Tests
e3f34dc 
Signed-off-by: Georgi Yazovaliyski <georgi.yazovaliiski@gmail.com>
@Daniel-K-Ivanov
resolve last comments
ca04d44 
Signed-off-by: Daniel Ivanov <daniel.k.ivanov95@gmail.com>
@georgiyazovaliiski @failfmi @Daniel-K-Ivanov
Feature: Scheduled Transactions - Transition Logics (#110)
5e84335 
Transition Logics for Create, Delete, Sign Scheduled Transaction Entity

Signed-off-by: Georgi Yazovaliyski <georgi.yazovaliiski@gmail.com>
Co-authored-by: failfmi <oscurocalma@gmail.com>
Co-authored-by: Daniel Ivanov <daniel.k.ivanov95@gmail.com>
@georgiyazovaliiski
Merge branch 'master' into transition-logics-new
7ee83b7 
# Conflicts:
#	hedera-node/src/main/java/com/hedera/services/context/AwareTransactionContext.java
#	hedera-node/src/main/java/com/hedera/services/context/TransactionContext.java
#	hedera-node/src/main/java/com/hedera/services/store/schedule/CompositeKey.java
#	hedera-node/src/main/java/com/hedera/services/store/schedule/HederaScheduleStore.java
#	hedera-node/src/main/java/com/hedera/services/txns/schedule/ScheduleCreateTransitionLogic.java
#	hedera-node/src/main/java/com/hedera/services/txns/schedule/ScheduleDeleteTransitionLogic.java
#	hedera-node/src/main/java/com/hedera/services/txns/schedule/ScheduleSignTransitionLogic.java
#	hedera-node/src/test/java/com/hedera/services/txns/schedule/ScheduleCreateTransitionLogicTest.java
#	hedera-node/src/test/java/com/hedera/services/txns/schedule/ScheduleDeleteTransitionLogicTest.java
#	hedera-node/src/test/java/com/hedera/services/txns/schedule/ScheduleSignTransitionLogicTest.java
@georgiyazovaliiski
Corrections and merge
b0e0c68 
Signed-off-by: Georgi Yazovaliyski <georgi.yazovaliiski@gmail.com>
@Daniel-K-Ivanov
add todo comments for the next PR
373a182 
Signed-off-by: Daniel Ivanov <daniel.k.ivanov95@gmail.com>
@georgiyazovaliiski
Merge branch 'feature/scheduled-txns/transition-logics-base' into fea…
b9bf721 
…ture/scheduled-transactions/tests-base

# Conflicts:
#	hedera-node/src/main/java/com/hedera/services/context/AwareTransactionContext.java
#	hedera-node/src/main/java/com/hedera/services/context/TransactionContext.java
#	hedera-node/src/main/java/com/hedera/services/store/schedule/CompositeKey.java
#	hedera-node/src/main/java/com/hedera/services/store/schedule/HederaScheduleStore.java
#	hedera-node/src/main/java/com/hedera/services/txns/schedule/ScheduleCreateTransitionLogic.java
#	hedera-node/src/main/java/com/hedera/services/txns/schedule/ScheduleDeleteTransitionLogic.java
#	hedera-node/src/main/java/com/hedera/services/txns/schedule/ScheduleSignTransitionLogic.java
#	hedera-node/src/test/java/com/hedera/services/txns/schedule/ScheduleCreateTransitionLogicTest.java
Merge branch 'feature/scheduled-txns/transition-logics-base' into sch…
023ccbb 
…ed-trans-logics
Initialize BodySigningSigFactory with accessor rather than accessor.g…
e02ee8e 
…etTxnBytes()

Signed-off-by: tinker-michaelj <michael.tinker@hedera.com>
Use SigFactoryCreator to create schedule-sensitive sig factories as a…
d13d949 
…ppropos

Signed-off-by: tinker-michaelj <michael.tinker@hedera.com>
Add scheduled flag to JKey
4c72fd0 
Signed-off-by: tinker-michaelj <michael.tinker@hedera.com>
Use a (schedule-aware) scoped sigProvider in expandSignatures and han…
31f1ac7 
…dleTransaction

Signed-off-by: tinker-michaelj <michael.tinker@hedera.com>
Expand scheduled txn req signers in ScheduleCreate otherParties with …
c1bcf14 
…isForScheduledTxn=true

Signed-off-by: tinker-michaelj <michael.tinker@hedera.com>
Initial negative EET spec (unparseable body) passing
1bc2a08 
Signed-off-by: tinker-michaelj <michael.tinker@hedera.com>
failfmi and others added 27 commits February 3, 2021 11:48
@failfmi
Merge branch 'schedule-develop' into feature/scheduled-txns/bdd-scena…
83ebe25 
…rios-list-base
@georgiyazovaliiski @failfmi @Daniel-K-Ivanov
Feature: Scheduled Transactions - BDD Scenarios (#146)
7b9fab1 
* BDD Scenarios for ScheduleCreate, ScheduleDelete, ScheduleSign and execution operations

Signed-off-by: Georgi Yazovaliyski <georgi.yazovaliiski@gmail.com>

Co-authored-by: failfmi <oscurocalma@gmail.com>
Co-authored-by: Daniel Ivanov <daniel.k.ivanov95@gmail.com>
Add other schedule specs to CI
f2a9a9e 
Signed-off-by: tinker-michaelj <michael.tinker@hedera.com>
Merge pull request #1043 from hashgraph/bdd-base
baf41ab 
BDD additions
Include exception message in failed op warning
9f2b4a7 
Signed-off-by: tinker-michaelj <michael.tinker@hedera.com>
Merge remote-tracking branch 'origin/master' into schedule-develop
064eea1
Set hapi-proto version to appropriate snapshot
7039b37 
Signed-off-by: tinker-michaelj <michael.tinker@hedera.com>
@Daniel-K-Ivanov
update eet
a1e86ba 
Signed-off-by: Daniel Ivanov <daniel.k.ivanov95@gmail.com>
@Daniel-K-Ivanov
update spec file
1ac0ccd 
Signed-off-by: Daniel Ivanov <daniel.k.ivanov95@gmail.com>
Merge pull request #1048 from LimeChain/docs/update-spec-and-eet
d7299a7 
Docs - Update EET and Spec file to latest version
@failfmi
fix(hapi-fees): schedule sign usage rbs calculation
0cdd92c 
Signed-off-by: failfmi <oscurocalma@gmail.com>
Merge pull request #1056 from LimeChain/fix/hapi-fees/schedule/sign/u…
d50e419 
…sage-rbs

Scheduled Transactions: Fix Sign op usage
Revert hapi-proto version to 0.12.0-SNAPSHOT
37f0411 
Signed-off-by: tinker-michaelj <michael.tinker@hedera.com>
Merge remote-tracking branch 'origin/master' into schedule-develop
ddf1b38
Restore sanity check enforcing increasing consensus time
a51d3ed 
Signed-off-by: tinker-michaelj <michael.tinker@hedera.com>
Merge branch 'schedule-develop' of github.com:hashgraph/hedera-servic…
c149aa5 
…es into schedule-develop
Initial cleanup under com.hedera.services.legacy
0e42909 
Signed-off-by: tinker-michaelj <michael.tinker@hedera.com>
Improve readability of IssListener output
ecb9eda 
Signed-off-by: tinker-michaelj <michael.tinker@hedera.com>
Update Dockerfile
6ff9b07 
Signed-off-by: tinker-michaelj <michael.tinker@hedera.com>
Merge branch '01061-M-FixDockerBuild' into 0962-M-AddFileMemo
9c3e7ba
Update JFileInfo -> HFileMeta serde for memo field
635cabd 
Signed-off-by: tinker-michaelj <michael.tinker@hedera.com>
Use NodeLocalProperties in StateView, minor cleanup
a2364f0 
Signed-off-by: tinker-michaelj <michael.tinker@hedera.com>
Refactor FileCreate resource usage
daedc24 
Signed-off-by: tinker-michaelj <michael.tinker@hedera.com>
Try with transfer progress to see OSSRH snapshot repo effects
7bd2a9b 
Signed-off-by: tinker-michaelj <michael.tinker@hedera.com>
Implement new-style FileUpdate usage estimator
0001c47 
Signed-off-by: tinker-michaelj <michael.tinker@hedera.com>
Try with explicit central repo
b1aa138 
Signed-off-by: tinker-michaelj <michael.tinker@hedera.com>
Cleanup usage tests
15c0b8d 
Signed-off-by: tinker-michaelj <michael.tinker@hedera.com>
@tinker-michaelj
Copy link
Collaborator Author

Will open to schedule-develop

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anighanta anighanta Awaiting requested review from anighanta

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add memo field for file entity
4 participants
@tinker-michaelj @georgiyazovaliiski @failfmi @Daniel-K-Ivanov