Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: enable last 2 tests from ContractCreateSuite #10050

Merged
merged 1 commit into from Nov 21, 2023

Conversation

MiroslavGatsanoga
Copy link
Collaborator

Description:

Related issue(s):

Notes for reviewer:

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

Signed-off-by: Miroslav Gatsanoga <miroslav.gatsanoga@limechain.tech>
Copy link

Node: Unit Test Results

    2 283 files  ±0      2 283 suites  ±0   1h 16m 54s ⏱️ - 3m 50s
118 361 tests ±0  118 327 ✔️ ±0  34 💤 ±0  0 ±0 
126 679 runs  ±0  126 645 ✔️ ±0  34 💤 ±0  0 ±0 

Results for commit 7fe8396. ± Comparison against base commit fe5882f.

Copy link

Node: E2E Test Results

    1 files  ±    0      1 suites  ±0   21m 40s ⏱️ + 21m 40s
310 tests +309  310 ✔️ +310  0 💤 ±0  0  - 1 
332 runs  +331  332 ✔️ +332  0 💤 ±0  0  - 1 

Results for commit 7fe8396. ± Comparison against base commit fe5882f.

This pull request removes 1 and adds 310 tests. Note that renamed tests count towards both.
EndToEndTests ‑ initializationError
EndToEndTests ‑ ADDRESS_BOOK_CONTROLCanUpdateADDRESS_BOOK
EndToEndTests ‑ ADDRESS_BOOK_CONTROLCanUpdateNODE_DETAILS
EndToEndTests ‑ AccountsGetPayerRecordsIfSoConfigured
EndToEndTests ‑ Acct57CanMakeSmallChanges
EndToEndTests ‑ Acct57CantMakeLargeChanges
EndToEndTests ‑ AddingSignaturesToExecutedTxFails
EndToEndTests ‑ AddingSignaturesToExecutedTxFailsWithLongTermEnabled
EndToEndTests ‑ AddingSignaturesToNonExistingTxFails
EndToEndTests ‑ AddingSignaturesToNonExistingTxFailsWithLongTermEnabled
EndToEndTests ‑ AddressAliasIdFuzzing
…

Copy link

codecov bot commented Nov 21, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (fe5882f) 65.45% compared to head (7fe8396) 65.45%.
Report is 1 commits behind head on develop.

Additional details and impacted files
@@            Coverage Diff             @@
##             develop   #10050   +/-   ##
==========================================
  Coverage      65.45%   65.45%           
+ Complexity     30210    30209    -1     
==========================================
  Files           3315     3315           
  Lines         126637   126637           
  Branches       13161    13161           
==========================================
  Hits           82885    82885           
+ Misses         40558    40557    -1     
- Partials        3194     3195    +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

Node: Integration Test Results

279 tests  ±0   279 ✔️ ±0   28m 4s ⏱️ -25s
    5 suites ±0       0 💤 ±0 
    5 files   ±0       0 ±0 

Results for commit 7fe8396. ± Comparison against base commit fe5882f.

Copy link

Node: HAPI Test Results

1 245 tests  ±0   913 ✔️ +2   1h 27m 43s ⏱️ - 6m 37s
   166 suites ±0   332 💤  - 2 
   166 files   ±0       0 ±0 

Results for commit 7fe8396. ± Comparison against base commit fe5882f.

@MiroslavGatsanoga MiroslavGatsanoga merged commit 170a0a3 into develop Nov 21, 2023
16 of 17 checks passed
@MiroslavGatsanoga MiroslavGatsanoga deleted the enable-contract-create-tests branch November 21, 2023 12:07
nickpoorman pushed a commit that referenced this pull request Nov 22, 2023
Signed-off-by: Miroslav Gatsanoga <miroslav.gatsanoga@limechain.tech>
Signed-off-by: Nick Poorman <nick@swirldslabs.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix blockTimestampChangesWithinFewSeconds from ContractCreateSuite
2 participants