Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gradle: fix 'hedera-protobufs' git pull #10061

Merged
merged 1 commit into from Nov 21, 2023

Conversation

jjohannes
Copy link
Collaborator

Description:

Fixes an issue introduced in #9651
If the branch is already checked out, the build wouldn't update it, because we only usedfetch.

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

Signed-off-by: Jendrik Johannes <jendrik.johannes@gmail.com>
Copy link

Node: Unit Test Results

    2 283 files  ±0      2 283 suites  ±0   1h 16m 11s ⏱️ +59s
118 366 tests ±0  118 332 ✔️ ±0  34 💤 ±0  0 ±0 
126 684 runs  ±0  126 650 ✔️ ±0  34 💤 ±0  0 ±0 

Results for commit 9dafb94. ± Comparison against base commit 7417fee.

Copy link

codecov bot commented Nov 21, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

❗ No coverage uploaded for pull request base (develop@7417fee). Click here to learn what that means.

Additional details and impacted files
@@            Coverage Diff             @@
##             develop   #10061   +/-   ##
==========================================
  Coverage           ?   65.27%           
  Complexity         ?    30195           
==========================================
  Files              ?     3325           
  Lines              ?   126812           
  Branches           ?    13185           
==========================================
  Hits               ?    82778           
  Misses             ?    40823           
  Partials           ?     3211           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

Node: E2E Test Results

    1 files      1 suites   22m 2s ⏱️
310 tests 310 ✔️ 0 💤 0
332 runs  332 ✔️ 0 💤 0

Results for commit 9dafb94.

Copy link

Node: Integration Test Results

279 tests   279 ✔️  28m 18s ⏱️
    5 suites      0 💤
    5 files        0

Results for commit 9dafb94.

Copy link

Node: HAPI Test Results

1 245 tests   968 ✔️  1h 38m 19s ⏱️
   166 suites  277 💤
   166 files        0

Results for commit 9dafb94.

@nathanklick nathanklick merged commit 87b9185 into develop Nov 21, 2023
16 of 17 checks passed
@nathanklick nathanklick deleted the fix-hedera-protobufs-git-pull branch November 21, 2023 20:31
nickpoorman pushed a commit that referenced this pull request Nov 22, 2023
Signed-off-by: Jendrik Johannes <jendrik.johannes@gmail.com>
Signed-off-by: Nick Poorman <nick@swirldslabs.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants