Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable DelegatePrecompileSuite tests #10071

Merged
merged 1 commit into from Nov 22, 2023

Conversation

mustafauzunn
Copy link
Collaborator

Description:

Enable DelegatePrecompileSuite tests

Related issue(s):

Fixes #10070

Notes for reviewer:

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

Signed-off-by: Mustafa Uzun <mustafa.uzun@limechain.tech>
@mustafauzunn mustafauzunn added the Limechain Work planned for the LimeChain team label Nov 22, 2023
@mustafauzunn mustafauzunn self-assigned this Nov 22, 2023
@mustafauzunn mustafauzunn requested review from a team as code owners November 22, 2023 07:56
Copy link

Node: Unit Test Results

    2 283 files  ±0      2 283 suites  ±0   42m 10s ⏱️ - 9m 46s
118 366 tests ±0  118 332 ✔️ ±0  34 💤 ±0  0 ±0 
126 684 runs  ±0  126 650 ✔️ ±0  34 💤 ±0  0 ±0 

Results for commit bfab296. ± Comparison against base commit 1783f9d.

Copy link

codecov bot commented Nov 22, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (1783f9d) 65.28% compared to head (bfab296) 65.28%.

Additional details and impacted files
@@            Coverage Diff             @@
##             develop   #10071   +/-   ##
==========================================
  Coverage      65.28%   65.28%           
  Complexity     30197    30197           
==========================================
  Files           3326     3326           
  Lines         126798   126798           
  Branches       13185    13185           
==========================================
+ Hits           82775    82777    +2     
+ Misses         40818    40816    -2     
  Partials        3205     3205           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

Node: E2E Test Results

    1 files  ±    0      1 suites  ±0   22m 3s ⏱️ + 22m 3s
310 tests +309  310 ✔️ +310  0 💤 ±0  0  - 1 
332 runs  +331  332 ✔️ +332  0 💤 ±0  0  - 1 

Results for commit bfab296. ± Comparison against base commit 1783f9d.

This pull request removes 1 and adds 310 tests. Note that renamed tests count towards both.
EndToEndTests ‑ initializationError
EndToEndTests ‑ ADDRESS_BOOK_CONTROLCanUpdateADDRESS_BOOK
EndToEndTests ‑ ADDRESS_BOOK_CONTROLCanUpdateNODE_DETAILS
EndToEndTests ‑ AccountsGetPayerRecordsIfSoConfigured
EndToEndTests ‑ Acct57CanMakeSmallChanges
EndToEndTests ‑ Acct57CantMakeLargeChanges
EndToEndTests ‑ AddingSignaturesToExecutedTxFails
EndToEndTests ‑ AddingSignaturesToExecutedTxFailsWithLongTermEnabled
EndToEndTests ‑ AddingSignaturesToNonExistingTxFails
EndToEndTests ‑ AddingSignaturesToNonExistingTxFailsWithLongTermEnabled
EndToEndTests ‑ AddressAliasIdFuzzing
…

Copy link

Node: Integration Test Results

279 tests  ±0   279 ✔️ ±0   29m 27s ⏱️ + 1m 13s
    5 suites ±0       0 💤 ±0 
    5 files   ±0       0 ±0 

Results for commit bfab296. ± Comparison against base commit 1783f9d.

Copy link
Collaborator

@tinker-michaelj tinker-michaelj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link

Node: HAPI Test Results

1 245 tests  ±0   971 ✔️ +3   1h 41m 39s ⏱️ + 9m 43s
   166 suites ±0   274 💤  - 3 
   166 files   ±0       0 ±0 

Results for commit bfab296. ± Comparison against base commit 1783f9d.

@mustafauzunn mustafauzunn merged commit ba617be into develop Nov 22, 2023
16 of 17 checks passed
@mustafauzunn mustafauzunn deleted the 10070-delegate-precompile-suite branch November 22, 2023 16:05
nickpoorman pushed a commit that referenced this pull request Nov 22, 2023
Signed-off-by: Mustafa Uzun <mustafa.uzun@limechain.tech>
Signed-off-by: Nick Poorman <nick@swirldslabs.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Limechain Work planned for the LimeChain team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix DelegatePrecompileSuite tests
2 participants