Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure ETH account creation is not throttled #10079

Merged
merged 1 commit into from Nov 22, 2023

Conversation

tinker-michaelj
Copy link
Collaborator

Description:

  • When running the _Eth variants of HapiSuite's, many payer accounts are created using auto-account creation; but in itest the default payer is not a superuser and could be throttled. This might explain failures like these?

Signed-off-by: Michael Tinker <michael.tinker@swirldslabs.com>
Copy link

Node: HAPI Test (Time Consuming) Results

21 tests     4 ✔️  6m 18s ⏱️
  2 suites  17 💤
  2 files      0

Results for commit 45231d5.

Copy link

Node: HAPI Test (Crypto) Results

211 tests   201 ✔️  18m 38s ⏱️
  22 suites    10 💤
  22 files        0

Results for commit 45231d5.

Copy link

Node: HAPI Test (Token) Results

190 tests   188 ✔️  19m 4s ⏱️
  13 suites      2 💤
  13 files        0

Results for commit 45231d5.

Copy link

Node: Unit Test Results

    2 283 files  ±0      2 283 suites  ±0   46m 35s ⏱️ + 2m 18s
118 366 tests ±0  118 332 ✔️ ±0  34 💤 ±0  0 ±0 
126 684 runs  ±0  126 650 ✔️ ±0  34 💤 ±0  0 ±0 

Results for commit 45231d5. ± Comparison against base commit 9bbab0b.

Copy link

codecov bot commented Nov 22, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

❗ No coverage uploaded for pull request base (develop@9bbab0b). Click here to learn what that means.

Additional details and impacted files
@@            Coverage Diff             @@
##             develop   #10079   +/-   ##
==========================================
  Coverage           ?   65.27%           
  Complexity         ?    30197           
==========================================
  Files              ?     3326           
  Lines              ?   126819           
  Branches           ?    13185           
==========================================
  Hits               ?    82785           
  Misses             ?    40824           
  Partials           ?     3210           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

Node: HAPI Test (Misc) Results

418 tests   273 ✔️  21m 5s ⏱️
  73 suites  145 💤
  73 files        0

Results for commit 45231d5.

Copy link

Node: E2E Test Results

    1 files      1 suites   23m 5s ⏱️
310 tests 310 ✔️ 0 💤 0
332 runs  332 ✔️ 0 💤 0

Results for commit 45231d5.

Copy link

Node: Integration Test Results

279 tests   279 ✔️  28m 8s ⏱️
    5 suites      0 💤
    5 files        0

Results for commit 45231d5.

Copy link

Node: HAPI Test (Smart Contract) Results

410 tests   306 ✔️  41m 6s ⏱️
  56 suites  104 💤
  56 files        0

Results for commit 45231d5.

Copy link
Member

@Neeharika-Sompalli Neeharika-Sompalli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !

@tinker-michaelj tinker-michaelj merged commit 77806d2 into develop Nov 22, 2023
24 of 25 checks passed
@tinker-michaelj tinker-michaelj deleted the use-genesis-for-eth-payer-creation branch November 22, 2023 16:11
nickpoorman pushed a commit that referenced this pull request Nov 22, 2023
Signed-off-by: Michael Tinker <michael.tinker@swirldslabs.com>
Signed-off-by: Nick Poorman <nick@swirldslabs.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants