Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Catch UncheckedIOException during PCES file copy. #10083

Merged
merged 1 commit into from Nov 22, 2023

Conversation

cody-littley
Copy link
Contributor

Related to #10082
Needs to be cherry picked to 0.44

Signed-off-by: Cody Littley <cody@swirldslabs.com>
@cody-littley cody-littley added this to the v0.45 milestone Nov 22, 2023
@cody-littley cody-littley self-assigned this Nov 22, 2023
@cody-littley cody-littley requested a review from a team as a code owner November 22, 2023 16:29
Copy link

Node: HAPI Test (Time Consuming) Results

21 tests     4 ✔️  6m 19s ⏱️
  2 suites  17 💤
  2 files      0

Results for commit c8e9a14.

Copy link

Node: Unit Test Results

    2 283 files  ±0      2 283 suites  ±0   45m 10s ⏱️ - 3m 25s
118 365 tests ±0  118 331 ✔️ ±0  34 💤 ±0  0 ±0 
126 683 runs  ±0  126 649 ✔️ ±0  34 💤 ±0  0 ±0 

Results for commit c8e9a14. ± Comparison against base commit 0bf0769.

Copy link

codecov bot commented Nov 22, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

❗ No coverage uploaded for pull request base (develop@ba617be). Click here to learn what that means.

Additional details and impacted files
@@            Coverage Diff             @@
##             develop   #10083   +/-   ##
==========================================
  Coverage           ?   65.28%           
  Complexity         ?    30205           
==========================================
  Files              ?     3328           
  Lines              ?   126886           
  Branches           ?    13188           
==========================================
  Hits               ?    82841           
  Misses             ?    40839           
  Partials           ?     3206           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

Node: HAPI Test (Token) Results

190 tests   188 ✔️  21m 51s ⏱️
  13 suites      2 💤
  13 files        0

Results for commit c8e9a14.

Copy link

Node: HAPI Test (Smart Contract) Results

410 tests   312 ✔️  45m 44s ⏱️
  56 suites    98 💤
  56 files        0

Results for commit c8e9a14.

Copy link

Node: HAPI Test (Crypto) Results

211 tests  ±0   201 ✔️ ±0   18m 40s ⏱️ -8s
  22 suites ±0     10 💤 ±0 
  22 files   ±0       0 ±0 

Results for commit c8e9a14. ± Comparison against base commit 0bf0769.

Copy link

Node: HAPI Test (Misc) Results

418 tests  ±0   273 ✔️ ±0   20m 5s ⏱️ - 2m 45s
  73 suites ±0   145 💤 ±0 
  73 files   ±0       0 ±0 

Results for commit c8e9a14. ± Comparison against base commit 0bf0769.

Copy link

Node: E2E Test Results

    1 files      1 suites   21m 52s ⏱️
310 tests 310 ✔️ 0 💤 0
332 runs  332 ✔️ 0 💤 0

Results for commit c8e9a14.

Copy link

Node: Integration Test Results

279 tests  ±0   279 ✔️ +1   28m 37s ⏱️ +24s
    5 suites ±0       0 💤 ±0 
    5 files   ±0       0  - 1 

Results for commit c8e9a14. ± Comparison against base commit 0bf0769.

@cody-littley cody-littley merged commit edc657a into develop Nov 22, 2023
24 of 25 checks passed
@cody-littley cody-littley deleted the 10082-catch-unchecked-io branch November 22, 2023 22:29
cody-littley added a commit that referenced this pull request Nov 22, 2023
Signed-off-by: Cody Littley <cody@swirldslabs.com>
poulok pushed a commit that referenced this pull request Nov 23, 2023
Signed-off-by: Cody Littley <cody@swirldslabs.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants