Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

9483 Added metrics for total space consumption by compaction level #10086

Merged
merged 4 commits into from Nov 28, 2023

Conversation

imalygin
Copy link
Member

Description:

This PR adds an additional set of metrics to estimate total space consumption in file storages per compaction level

Related issue(s):

Fixes #9483

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

Signed-off-by: Ivan Malygin <ivan@swirldslabs.com>
Copy link

github-actions bot commented Nov 22, 2023

Node: HAPI Test (Time Consuming) Results

21 tests  ±0     9 ✔️ ±0   25m 43s ⏱️ -6s
  2 suites ±0   12 💤 ±0 
  2 files   ±0     0 ±0 

Results for commit 1315a54. ± Comparison against base commit 0203ede.

♻️ This comment has been updated with latest results.

Signed-off-by: Ivan Malygin <ivan@swirldslabs.com>
Copy link

github-actions bot commented Nov 22, 2023

Node: Unit Test Results

    2 286 files  ±0      2 286 suites  ±0   47m 33s ⏱️ -18s
118 392 tests +3  118 358 ✔️ +3  34 💤 ±0  0 ±0 
126 764 runs  +3  126 730 ✔️ +3  34 💤 ±0  0 ±0 

Results for commit 1315a54. ± Comparison against base commit 0203ede.

♻️ This comment has been updated with latest results.

Copy link

codecov bot commented Nov 22, 2023

Codecov Report

Attention: 11 lines in your changes are missing coverage. Please review.

Comparison is base (0203ede) 63.13% compared to head (1315a54) 63.14%.

Files Patch % Lines
.../java/com/swirlds/merkledb/MerkleDbStatistics.java 75.67% 0 Missing and 9 partials ⚠️
...om/swirlds/merkledb/MerkleDbStatisticsUpdater.java 66.66% 2 Missing ⚠️
Additional details and impacted files
@@              Coverage Diff              @@
##             develop   #10086      +/-   ##
=============================================
+ Coverage      63.13%   63.14%   +0.01%     
- Complexity     30700    30710      +10     
=============================================
  Files           3327     3327              
  Lines         133875   133915      +40     
  Branches       13875    13879       +4     
=============================================
+ Hits           84523    84563      +40     
+ Misses         46022    46017       -5     
- Partials        3330     3335       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

github-actions bot commented Nov 22, 2023

Node: HAPI Test (Crypto) Results

211 tests  ±0   201 ✔️ ±0   17m 58s ⏱️ - 2m 34s
  22 suites ±0     10 💤 ±0 
  22 files   ±0       0 ±0 

Results for commit 1315a54. ± Comparison against base commit 0203ede.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented Nov 22, 2023

Node: HAPI Test (Misc) Results

418 tests  ±0   286 ✔️ ±0   21m 53s ⏱️ - 2m 47s
  73 suites ±0   132 💤 ±0 
  73 files   ±0       0 ±0 

Results for commit 1315a54. ± Comparison against base commit 0203ede.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented Nov 22, 2023

Node: HAPI Test (Token) Results

190 tests  ±0   188 ✔️ ±0   22m 2s ⏱️ + 2m 5s
  13 suites ±0       2 💤 ±0 
  13 files   ±0       0 ±0 

Results for commit 1315a54. ± Comparison against base commit 0203ede.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented Nov 22, 2023

Node: E2E Test Results

    1 files  ±    0      1 suites  ±0   20m 36s ⏱️ + 20m 36s
310 tests +309  310 ✔️ +310  0 💤 ±0  0  - 1 
332 runs  +331  332 ✔️ +332  0 💤 ±0  0  - 1 

Results for commit 1315a54. ± Comparison against base commit 0203ede.

This pull request removes 1 and adds 310 tests. Note that renamed tests count towards both.
EndToEndTests ‑ initializationError
EndToEndTests ‑ ADDRESS_BOOK_CONTROLCanUpdateADDRESS_BOOK
EndToEndTests ‑ ADDRESS_BOOK_CONTROLCanUpdateNODE_DETAILS
EndToEndTests ‑ AccountsGetPayerRecordsIfSoConfigured
EndToEndTests ‑ Acct57CanMakeSmallChanges
EndToEndTests ‑ Acct57CantMakeLargeChanges
EndToEndTests ‑ AddingSignaturesToExecutedTxFails
EndToEndTests ‑ AddingSignaturesToExecutedTxFailsWithLongTermEnabled
EndToEndTests ‑ AddingSignaturesToNonExistingTxFails
EndToEndTests ‑ AddingSignaturesToNonExistingTxFailsWithLongTermEnabled
EndToEndTests ‑ AddressAliasIdFuzzing
…

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented Nov 22, 2023

Node: Integration Test Results

279 tests  ±0   279 ✔️ ±0   28m 27s ⏱️ +33s
    5 suites ±0       0 💤 ±0 
    5 files   ±0       0 ±0 

Results for commit 1315a54. ± Comparison against base commit 0203ede.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented Nov 22, 2023

Node: HAPI Test (Smart Contract) Results

411 tests  ±0   318 ✔️ ±0   47m 42s ⏱️ + 4m 41s
  56 suites ±0     93 💤 ±0 
  56 files   ±0       0 ±0 

Results for commit 1315a54. ± Comparison against base commit 0203ede.

♻️ This comment has been updated with latest results.

artemananiev
artemananiev previously approved these changes Nov 27, 2023
Signed-off-by: Ivan Malygin <ivan@swirldslabs.com>
@imalygin imalygin merged commit a2e0e80 into develop Nov 28, 2023
24 of 25 checks passed
@imalygin imalygin deleted the 09483-total-size-metrics branch November 28, 2023 19:27
agadzhalov pushed a commit that referenced this pull request Dec 1, 2023
agadzhalov pushed a commit that referenced this pull request Dec 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

MerkleDb metrics for total file size at each compaction level
3 participants