Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

9975 Fix ScheduleExecutionSpecs methods that do not execute #10088

Merged
merged 1 commit into from Nov 29, 2023
Merged

9975 Fix ScheduleExecutionSpecs methods that do not execute #10088

merged 1 commit into from Nov 29, 2023

Conversation

jsync-swirlds
Copy link
Member

@jsync-swirlds jsync-swirlds commented Nov 22, 2023 •
edited

  • Fixed typo in ScheduleInfo query handler that resulted in setting expiration time instead of execution time.
  • Enabled the three tests that exercise that bug.
  • Enabled one more schedule create test
  • Adjusted comments for execution tests that rely on monoservice key gathering behavior.

Fixes #9975.

@jsync-swirlds jsync-swirlds self-assigned this Nov 22, 2023
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 22, 2023 •
edited

Node: HAPI Test (Time Consuming) Results

21 tests     9 ✔️  25m 54s ⏱️
  2 suites  12 💤
  2 files      0 ❌

Results for commit c43cb90.

♻️ This comment has been updated with latest results.

@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 23, 2023 •
edited

Node: Unit Test Results

    2 286 files  ±0      2 286 suites  ±0   48m 23s ⏱️ + 1m 3s
118 391 tests ±0  118 357 ✔️ ±0  34 💤 ±0  0 ❌ ±0 
126 763 runs  ±0  126 729 ✔️ ±0  34 💤 ±0  0 ❌ ±0 

Results for commit c43cb90. ± Comparison against base commit a2e0e80.

♻️ This comment has been updated with latest results.

@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 23, 2023 •
edited

Node: HAPI Test (Token) Results

190 tests  ±0   188 ✔️ ±0   19m 36s ⏱️ -6s
  13 suites ±0       2 💤 ±0 
  13 files   ±0       0 ❌ ±0 

Results for commit c43cb90. ± Comparison against base commit a2e0e80.

♻️ This comment has been updated with latest results.

@codecov Codecov
Copy link

codecov bot commented Nov 23, 2023 •
edited

Codecov Report

All modified and coverable lines are covered by tests ✅

❗ No coverage uploaded for pull request base (develop@a2e0e80). Click here to learn what that means.

Additional details and impacted files 
@@            Coverage Diff             @@
##             develop   #10088   +/-   ##
==========================================
  Coverage           ?   63.13%           
  Complexity         ?    30702           
==========================================
  Files              ?     3327           
  Lines              ?   133917           
  Branches           ?    13885           
==========================================
  Hits               ?    84552           
  Misses             ?    46027           
  Partials           ?     3338

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 23, 2023 •
edited

Node: HAPI Test (Crypto) Results

211 tests  ±0   201 ✔️ ±0   18m 45s ⏱️ +44s
  22 suites ±0     10 💤 ±0 
  22 files   ±0       0 ❌ ±0 

Results for commit c43cb90. ± Comparison against base commit a2e0e80.

♻️ This comment has been updated with latest results.

@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 23, 2023 •
edited

Node: HAPI Test (Misc) Results

418 tests  ±0   311 ✔️ +4   25m 51s ⏱️ +49s
  73 suites ±0   107 💤  - 4 
  73 files   ±0       0 ❌ ±0 

Results for commit c43cb90. ± Comparison against base commit a2e0e80.

♻️ This comment has been updated with latest results.

@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 23, 2023 •
edited

Node: E2E Test Results

    1 files      1 suites   22m 32s ⏱️
310 tests 310 ✔️ 0 💤 0 ❌
332 runs  332 ✔️ 0 💤 0 ❌

Results for commit c43cb90.

♻️ This comment has been updated with latest results.

@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 23, 2023 •
edited

Node: Integration Test Results

279 tests  ±0   279 ✔️ ±0   28m 17s ⏱️ +3s
    5 suites ±0       0 💤 ±0 
    5 files   ±0       0 ❌ ±0 

Results for commit c43cb90. ± Comparison against base commit a2e0e80.

♻️ This comment has been updated with latest results.

@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 23, 2023 •
edited

Node: HAPI Test (Smart Contract) Results

411 tests   318 ✔️  43m 39s ⏱️
  56 suites    93 💤
  56 files        0 ❌

Results for commit c43cb90.

♻️ This comment has been updated with latest results.

@jsync-swirlds jsync-swirlds force-pushed the 09975-fix-schedule-info-query branch 4 times, most recently from d42ae1a to 852fe1e Compare November 28, 2023 20:24
@jsync-swirlds
9975 Fix ScheduleExecutionSpecs methods that do not execute
c43cb90 
 * Fix typo in ScheduleInfo query handler that resulted in setting expiration time instead of execution time.
 * Enabled the three tests that exercise that bug.

Signed-off-by: Joseph Sinclair <joseph.sinclair@swirldslabs.com>
@jsync-swirlds jsync-swirlds marked this pull request as ready for review November 28, 2023 22:14
@jsync-swirlds jsync-swirlds requested review from a team as code owners November 28, 2023 22:14
iwsimon
iwsimon approved these changes Nov 28, 2023
View reviewed changes
Copy link
Contributor

@iwsimon iwsimon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jsync-swirlds jsync-swirlds merged commit 54afb65 into develop Nov 29, 2023
24 of 25 checks passed
@jsync-swirlds jsync-swirlds deleted the 09975-fix-schedule-info-query branch November 29, 2023 00:03
agadzhalov pushed a commit that referenced this pull request Dec 1, 2023
@jsync-swirlds @agadzhalov
9975 Fix ScheduleExecutionSpecs methods that do not execute (#10088)
729e6c0 
Signed-off-by: Joseph Sinclair <joseph.sinclair@swirldslabs.com>
agadzhalov pushed a commit that referenced this pull request Dec 1, 2023
@jsync-swirlds @agadzhalov
9975 Fix ScheduleExecutionSpecs methods that do not execute (#10088)
01493c1 
Signed-off-by: Joseph Sinclair <joseph.sinclair@swirldslabs.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iwsimon iwsimon iwsimon approved these changes

@rbair23 rbair23 Awaiting requested review from rbair23 rbair23 is a code owner automatically assigned from hashgraph/hedera-base

Assignees

@jsync-swirlds jsync-swirlds

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix ScheduleExecutionSpecs methods that do not execute
2 participants
@jsync-swirlds @iwsimon