Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add negative X tests scenarios for key verification on token update #10094

Merged
merged 12 commits into from Nov 27, 2023
Merged

Add negative X tests scenarios for key verification on token update #10094

merged 12 commits into from Nov 27, 2023

Conversation

petreze
Copy link
Contributor

@petreze petreze commented Nov 23, 2023 •
edited

Description:
Additional negative X test scenarios in UpdatesXTest, UpdateKeysXTest and UpdatesExpiryXTest

Related issue(s):

Fixes #10047 #10048 #10049

Notes for reviewer:

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

@petreze petreze changed the title Add negative X tests scenarios for key verification for token update Add negative X tests scenarios for token update key verification Nov 23, 2023
@petreze petreze changed the title Add negative X tests scenarios for token update key verification Add negative X tests scenarios for key verification on token update Nov 23, 2023
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 23, 2023 •
edited

Node: HAPI Test (Time Consuming) Results

21 tests     9 ✔️  25m 44s ⏱️
  2 suites  12 💤
  2 files      0 ❌

Results for commit 631786d.

♻️ This comment has been updated with latest results.

This was linked to issues Nov 23, 2023
Add more XTests for key verification for updateTokenKeys #10048
Closed
Add more XTests for key verification for updateTokenExpiryInfo #10049
Closed
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 23, 2023 •
edited

Node: HAPI Test (Crypto) Results

211 tests  ±0   201 ✔️ ±0   20m 0s ⏱️ + 1m 46s
  22 suites ±0     10 💤 ±0 
  22 files   ±0       0 ❌ ±0 

Results for commit 631786d. ± Comparison against base commit b9add91.

♻️ This comment has been updated with latest results.

@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 23, 2023 •
edited

Node: HAPI Test (Token) Results

190 tests   188 ✔️  19m 55s ⏱️
  13 suites      2 💤
  13 files        0 ❌

Results for commit 631786d.

♻️ This comment has been updated with latest results.

@petreze
minor typos
e1b3afa 
Signed-off-by: Petar Tonev <petar.tonev@limechain.tech>
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 23, 2023 •
edited

Node: Unit Test Results

    2 284 files  ±0      2 284 suites  ±0   38m 39s ⏱️ - 13m 6s
118 367 tests ±0  118 333 ✔️ ±0  34 💤 ±0  0 ❌ ±0 
126 683 runs  ±0  126 649 ✔️ ±0  34 💤 ±0  0 ❌ ±0 

Results for commit 631786d. ± Comparison against base commit b9add91.

♻️ This comment has been updated with latest results.

@codecov Codecov
Copy link

codecov bot commented Nov 23, 2023 •
edited

Codecov Report

All modified and coverable lines are covered by tests ✅

❗ No coverage uploaded for pull request base (develop@b9add91). Click here to learn what that means.

Additional details and impacted files 
@@            Coverage Diff             @@
##             develop   #10094   +/-   ##
==========================================
  Coverage           ?   65.29%           
  Complexity         ?    30219           
==========================================
  Files              ?     3330           
  Lines              ?   126926           
  Branches           ?    13198           
==========================================
  Hits               ?    82881           
  Misses             ?    40828           
  Partials           ?     3217

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 23, 2023 •
edited

Node: HAPI Test (Misc) Results

418 tests  ±0   273 ✔️ ±0   20m 59s ⏱️ -49s
  73 suites ±0   145 💤 ±0 
  73 files   ±0       0 ❌ ±0 

Results for commit 631786d. ± Comparison against base commit b9add91.

♻️ This comment has been updated with latest results.

@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 23, 2023 •
edited

Node: E2E Test Results

    1 files      1 suites   20m 59s ⏱️
310 tests 310 ✔️ 0 💤 0 ❌
332 runs  332 ✔️ 0 💤 0 ❌

Results for commit 631786d.

♻️ This comment has been updated with latest results.

@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 23, 2023 •
edited

Node: Integration Test Results

279 tests  ±0   279 ✔️ ±0   28m 30s ⏱️ +12s
    5 suites ±0       0 💤 ±0 
    5 files   ±0       0 ❌ ±0 

Results for commit 631786d. ± Comparison against base commit b9add91.

♻️ This comment has been updated with latest results.

@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 23, 2023 •
edited

Node: HAPI Test (Smart Contract) Results

410 tests   318 ✔️  40m 43s ⏱️
  56 suites    92 💤
  56 files        0 ❌

Results for commit 631786d.

♻️ This comment has been updated with latest results.

@petreze petreze marked this pull request as ready for review November 24, 2023 06:09
@petreze petreze requested a review from a team as a code owner November 24, 2023 06:09
stoyanov-st
stoyanov-st reviewed Nov 24, 2023
View reviewed changes
Copy link
Contributor

@stoyanov-st stoyanov-st left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job! Make sure to add the javadoc comments and negative tests for all selectors.

dikel
dikel previously approved these changes Nov 24, 2023
View reviewed changes
@MrValioBg MrValioBg added the Limechain Work planned for the LimeChain team label Nov 24, 2023
@petreze petreze added the Modularization Issues or PRs related to modularization label Nov 24, 2023
@petreze petreze self-assigned this Nov 24, 2023
@petreze petreze requested review from tinker-michaelj and a team as code owners November 27, 2023 10:26
tinker-michaelj
tinker-michaelj approved these changes Nov 27, 2023
View reviewed changes
Copy link
Collaborator

@tinker-michaelj tinker-michaelj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, ty @petreze !

@petreze petreze merged commit 510bd75 into develop Nov 27, 2023
24 of 25 checks passed
@petreze petreze deleted the 10047-key-verification-update-token branch November 27, 2023 16:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tinker-michaelj tinker-michaelj tinker-michaelj approved these changes

@Neeharika-Sompalli Neeharika-Sompalli Awaiting requested review from Neeharika-Sompalli Neeharika-Sompalli is a code owner automatically assigned from hashgraph/hedera-base

@agadzhalov agadzhalov Awaiting requested review from agadzhalov

@mustafauzunn mustafauzunn Awaiting requested review from mustafauzunn

@stoyanov-st stoyanov-st Awaiting requested review from stoyanov-st

@david-bakin-sl david-bakin-sl Awaiting requested review from david-bakin-sl david-bakin-sl is a code owner automatically assigned from hashgraph/hedera-smart-contracts

@MrValioBg MrValioBg Awaiting requested review from MrValioBg

@dikel dikel Awaiting requested review from dikel

Assignees

@petreze petreze

Labels
Limechain Work planned for the LimeChain team Modularization Issues or PRs related to modularization
Projects
None yet
Milestone
No milestone
5 participants
@petreze @dikel @stoyanov-st @MrValioBg @tinker-michaelj