#10095 Extend Context as preparation for logging PR #10096
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Timo Brandstätter <timo@swirldslabs.com>
timo0
requested review from
poulok,
hendrikebbers,
tomzhenghedera and
nathanklick
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #10096 +/- ##
==========================================
Coverage ? 65.27%
Complexity ? 30204
==========================================
Files ? 3329
Lines ? 126925
Branches ? 13198
==========================================
Hits ? 82848
Misses ? 40863
Partials ? 3214 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
We should add the new unit plugins directly to https://github.com/hashgraph/hedera-services/blob/develop/platform-sdk/docs/base/test-support/test-support.md
platform-sdk/swirlds-base/src/test/java/com/swirlds/base/context/ThreadLocalContextTest.java
Show resolved
Hide resolved
...tFixtures/java/com/swirlds/base/test/fixtures/concurrent/internal/ConcurrentTestSupport.java
Show resolved
Hide resolved
...tFixtures/java/com/swirlds/base/test/fixtures/concurrent/internal/ConcurrentTestSupport.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Timo Brandstätter <timo@swirldslabs.com>
Signed-off-by: Timo Brandstätter <timo@swirldslabs.com>
hendrikebbers
approved these changes
Nov 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #10095