-
Notifications
You must be signed in to change notification settings - Fork 119
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Provide more Delete X tests for Non-payer key verification #10103
Conversation
Signed-off-by: dikel <dikelito@tutamail.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #10103 +/- ##
=============================================
- Coverage 65.27% 62.32% -2.95%
- Complexity 30205 30391 +186
=============================================
Files 3329 3344 +15
Lines 126937 134387 +7450
Branches 13198 13896 +698
=============================================
+ Hits 82853 83759 +906
- Misses 40876 47331 +6455
- Partials 3208 3297 +89 ☔ View full report in Codecov by Sentry. |
Node: E2E Test Results 1 files ± 0 1 suites ±0 22m 6s ⏱️ + 22m 6s Results for commit 59cce88. ± Comparison against base commit 97b8abf. This pull request removes 1 and adds 310 tests. Note that renamed tests count towards both.
♻️ This comment has been updated with latest results. |
hedera-node/hedera-app/src/xtest/java/contract/DeleteXTest.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can add scenarios for fungible and NFT deletion with different keys which we expect to fail
Signed-off-by: dikel <dikelito@tutamail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, ty @dikel !
Description:
Adds additional negative delete X test scenarios for non-payer keys
Related issue(s):
Fixes #10046
Checklist