Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide more Delete X tests for Non-payer key verification #10103

Merged
merged 3 commits into from
Nov 27, 2023

Conversation

dikel
Copy link
Contributor

@dikel dikel commented Nov 24, 2023

Description:
Adds additional negative delete X test scenarios for non-payer keys

Related issue(s):

Fixes #10046

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

Signed-off-by: dikel <dikelito@tutamail.com>
@dikel dikel added the Limechain Work planned for the LimeChain team label Nov 24, 2023
@dikel dikel self-assigned this Nov 24, 2023
@dikel dikel requested a review from a team as a code owner November 24, 2023 12:43
Copy link

github-actions bot commented Nov 24, 2023

Node: Unit Test Results

    2 285 files  +2      2 285 suites  +2   46m 25s ⏱️ - 1m 25s
118 368 tests +3  118 334 ✔️ +3  34 💤 ±0  0 ±0 
126 684 runs  +1  126 650 ✔️ +1  34 💤 ±0  0 ±0 

Results for commit 59cce88. ± Comparison against base commit 97b8abf.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented Nov 24, 2023

Node: HAPI Test (Crypto) Results

211 tests  ±0   201 ✔️ ±0   20m 23s ⏱️ + 3m 24s
  22 suites ±0     10 💤 ±0 
  22 files   ±0       0 ±0 

Results for commit 59cce88. ± Comparison against base commit 97b8abf.

♻️ This comment has been updated with latest results.

Copy link

codecov bot commented Nov 24, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (97b8abf) 65.27% compared to head (59cce88) 62.32%.
Report is 4 commits behind head on develop.

Additional details and impacted files
@@              Coverage Diff              @@
##             develop   #10103      +/-   ##
=============================================
- Coverage      65.27%   62.32%   -2.95%     
- Complexity     30205    30391     +186     
=============================================
  Files           3329     3344      +15     
  Lines         126937   134387    +7450     
  Branches       13198    13896     +698     
=============================================
+ Hits           82853    83759     +906     
- Misses         40876    47331    +6455     
- Partials        3208     3297      +89     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

github-actions bot commented Nov 24, 2023

Node: HAPI Test (Token) Results

190 tests  ±0   188 ✔️ ±0   19m 21s ⏱️ + 1m 38s
  13 suites ±0       2 💤 ±0 
  13 files   ±0       0 ±0 

Results for commit 59cce88. ± Comparison against base commit 97b8abf.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented Nov 24, 2023

Node: HAPI Test (Misc) Results

418 tests  ±0   273 ✔️ ±0   22m 22s ⏱️ + 1m 26s
  73 suites ±0   145 💤 ±0 
  73 files   ±0       0 ±0 

Results for commit 59cce88. ± Comparison against base commit 97b8abf.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented Nov 24, 2023

Node: E2E Test Results

    1 files  ±    0      1 suites  ±0   22m 6s ⏱️ + 22m 6s
310 tests +309  310 ✔️ +310  0 💤 ±0  0  - 1 
332 runs  +331  332 ✔️ +332  0 💤 ±0  0  - 1 

Results for commit 59cce88. ± Comparison against base commit 97b8abf.

This pull request removes 1 and adds 310 tests. Note that renamed tests count towards both.
EndToEndTests ‑ initializationError
EndToEndTests ‑ ADDRESS_BOOK_CONTROLCanUpdateADDRESS_BOOK
EndToEndTests ‑ ADDRESS_BOOK_CONTROLCanUpdateNODE_DETAILS
EndToEndTests ‑ AccountsGetPayerRecordsIfSoConfigured
EndToEndTests ‑ Acct57CanMakeSmallChanges
EndToEndTests ‑ Acct57CantMakeLargeChanges
EndToEndTests ‑ AddingSignaturesToExecutedTxFails
EndToEndTests ‑ AddingSignaturesToExecutedTxFailsWithLongTermEnabled
EndToEndTests ‑ AddingSignaturesToNonExistingTxFails
EndToEndTests ‑ AddingSignaturesToNonExistingTxFailsWithLongTermEnabled
EndToEndTests ‑ AddressAliasIdFuzzing
…

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented Nov 24, 2023

Node: HAPI Test (Time Consuming) Results

21 tests  ±0     9 ✔️ ±0   25m 49s ⏱️ +34s
  2 suites ±0   12 💤 ±0 
  2 files   ±0     0 ±0 

Results for commit 59cce88. ± Comparison against base commit 97b8abf.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented Nov 24, 2023

Node: Integration Test Results

279 tests  ±0   279 ✔️ ±0   28m 35s ⏱️ +21s
    5 suites ±0       0 💤 ±0 
    5 files   ±0       0 ±0 

Results for commit 59cce88. ± Comparison against base commit 97b8abf.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented Nov 24, 2023

Node: HAPI Test (Smart Contract) Results

410 tests  ±0   318 ✔️ ±0   43m 5s ⏱️ +43s
  56 suites ±0     92 💤 ±0 
  56 files   ±0       0 ±0 

Results for commit 59cce88. ± Comparison against base commit 97b8abf.

♻️ This comment has been updated with latest results.

Signed-off-by: dikel <dikelito@tutamail.com>
@dikel dikel requested a review from MrValioBg November 27, 2023 07:44
Copy link
Collaborator

@mustafauzunn mustafauzunn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can add scenarios for fungible and NFT deletion with different keys which we expect to fail

Signed-off-by: dikel <dikelito@tutamail.com>
Copy link
Collaborator

@tinker-michaelj tinker-michaelj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, ty @dikel !

@rbair23 rbair23 merged commit eccf8fd into develop Nov 27, 2023
23 of 25 checks passed
@rbair23 rbair23 deleted the 10046-delete-non-payer-x-tests branch November 27, 2023 18:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Limechain Work planned for the LimeChain team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

deleteToken (DeleteTokenPrecompile) - X tests key verification
5 participants