Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Fix ContractKeysHTSSuite records #10110

Merged
merged 13 commits into from Dec 7, 2023
Merged

chore: Fix ContractKeysHTSSuite records #10110

merged 13 commits into from Dec 7, 2023

Conversation

thenswan
Copy link
Contributor

@thenswan thenswan commented Nov 27, 2023 •
edited

Description:
Fix ContractKeysHTSSuite records

Related issue(s):
Fixes #10099

@thenswan
Fuzzy match mono against mono (WIP)
8a81585 
Signed-off-by: Nikita Lebedev <nikita.lebedev@limechain.tech>
@thenswan
Stabilizing mono vs mono (WIP)
61c9272 
Signed-off-by: Nikita Lebedev <nikita.lebedev@limechain.tech>
@thenswan
Running mod vs mono records (WIP)
06a9abe 
Signed-off-by: Nikita Lebedev <nikita.lebedev@limechain.tech>
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 27, 2023 •
edited

Node: Unit Test Results

    2 293 files  ±0      2 293 suites  ±0   49m 12s ⏱️ + 1m 17s
118 431 tests ±0  118 397 ✔️ ±0  34 💤 ±0  0 ❌ ±0 
126 853 runs  ±0  126 819 ✔️ ±0  34 💤 ±0  0 ❌ ±0 

Results for commit baa8847. ± Comparison against base commit bac40bd.

♻️ This comment has been updated with latest results.

@codecov Codecov
Copy link

codecov bot commented Nov 27, 2023 •
edited

Codecov Report

Attention: 4 lines in your changes are missing coverage. Please review.

Comparison is base (bac40bd) 63.51% compared to head (baa8847) 63.52%.
Report is 7 commits behind head on develop.

Files Patch % Lines
...contract/impl/exec/systemcontracts/FullResult.java 0.00% 2 Missing ⚠️
...t/impl/exec/systemcontracts/HtsSystemContract.java 0.00% 1 Missing ⚠️
...de/app/service/token/impl/RecordFinalizerBase.java 0.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             develop   #10110   +/-   ##
==========================================
  Coverage      63.51%   63.52%           
+ Complexity     30992    30991    -1     
==========================================
  Files           3340     3341    +1     
  Lines         134557   134578   +21     
  Branches       13994    13994           
==========================================
+ Hits           85470    85491   +21     
+ Misses         45727    45726    -1     
- Partials        3360     3361    +1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 27, 2023 •
edited

Node: HAPI Test (Crypto) Results

211 tests  ±0   201 ✔️ ±0   17m 31s ⏱️ - 1m 33s
  22 suites ±0     10 💤 ±0 
  22 files   ±0       0 ❌ ±0 

Results for commit baa8847. ± Comparison against base commit bac40bd.

♻️ This comment has been updated with latest results.

@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 27, 2023 •
edited

Node: HAPI Test (Token) Results

190 tests  ±0   188 ✔️ ±0   17m 48s ⏱️ - 1m 12s
  13 suites ±0       2 💤 ±0 
  13 files   ±0       0 ❌ ±0 

Results for commit baa8847. ± Comparison against base commit bac40bd.

♻️ This comment has been updated with latest results.

@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 27, 2023 •
edited

Node: HAPI Test (Misc) Results

419 tests  ±0   316 ✔️ ±0   27m 17s ⏱️ +46s
  73 suites ±0   103 💤 ±0 
  73 files   ±0       0 ❌ ±0 

Results for commit baa8847. ± Comparison against base commit bac40bd.

♻️ This comment has been updated with latest results.

@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 27, 2023 •
edited

Node: E2E Test Results

    1 files  ±    0      1 suites  ±0   23m 17s ⏱️ + 23m 17s
311 tests +310  311 ✔️ +311  0 💤 ±0  0 ❌  - 1 
333 runs  +332  333 ✔️ +333  0 💤 ±0  0 ❌  - 1 

Results for commit baa8847. ± Comparison against base commit bac40bd.

This pull request removes 1 and adds 311 tests. Note that renamed tests count towards both. 
EndToEndTests ‑ initializationError

EndToEndTests ‑ ADDRESS_BOOK_CONTROLCanUpdateADDRESS_BOOK
EndToEndTests ‑ ADDRESS_BOOK_CONTROLCanUpdateNODE_DETAILS
EndToEndTests ‑ AccountsGetPayerRecordsIfSoConfigured
EndToEndTests ‑ Acct57CanMakeSmallChanges
EndToEndTests ‑ Acct57CantMakeLargeChanges
EndToEndTests ‑ AddingSignaturesToExecutedTxFails
EndToEndTests ‑ AddingSignaturesToExecutedTxFailsWithLongTermEnabled
EndToEndTests ‑ AddingSignaturesToNonExistingTxFails
EndToEndTests ‑ AddingSignaturesToNonExistingTxFailsWithLongTermEnabled
EndToEndTests ‑ AddressAliasIdFuzzing
…

♻️ This comment has been updated with latest results.

@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 27, 2023 •
edited

Node: HAPI Test (Time Consuming) Results

21 tests  ±0     9 ✔️ ±0   25m 33s ⏱️ -59s
  2 suites ±0   12 💤 ±0 
  2 files   ±0     0 ❌ ±0 

Results for commit baa8847. ± Comparison against base commit bac40bd.

♻️ This comment has been updated with latest results.

@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 27, 2023 •
edited

Node: Integration Test Results

279 tests  ±0   279 ✔️ ±0   28m 21s ⏱️ ±0s
    5 suites ±0       0 💤 ±0 
    5 files   ±0       0 ❌ ±0 

Results for commit baa8847. ± Comparison against base commit bac40bd.

♻️ This comment has been updated with latest results.

@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 27, 2023 •
edited

Node: HAPI Test (Smart Contract) Results

396 tests  ±0   349 ✔️ ±0   47m 18s ⏱️ +44s
  55 suites ±0     47 💤 ±0 
  55 files   ±0       0 ❌ ±0 

Results for commit baa8847. ± Comparison against base commit bac40bd.

♻️ This comment has been updated with latest results.

@thenswan
Copy link
Contributor Author

Kindly pinging for support here @Neeharika-Sompalli @tinker-michaelj

@Neeharika-Sompalli
Copy link
Member

Neeharika-Sompalli commented Nov 28, 2023 •
edited

And in cases where we get record count mismatch occasionally (not each run)?

@thenswan It is possible to get mismatches in fees when client sets fees in transaction bodies submitted.
But Mismatched record count should be consistent in my opinion. I re-ran the tests on that suite 5 times with mono-service seem to be stable

@mustafauzunn mustafauzunn added the Limechain Work planned for the LimeChain team label Nov 30, 2023
@thenswan thenswan added the Modularization Issues or PRs related to modularization label Nov 30, 2023
@thenswan thenswan mentioned this pull request Dec 1, 2023
Closed
4 tasks
@Neeharika-Sompalli Neeharika-Sompalli changed the title Fix ContractKeysHTSSuite records chore: Fix ContractKeysHTSSuite records Dec 5, 2023
@Neeharika-Sompalli Neeharika-Sompalli marked this pull request as ready for review December 6, 2023 19:35
@Neeharika-Sompalli Neeharika-Sompalli self-assigned this Dec 6, 2023
Neeharika-Sompalli
Neeharika-Sompalli previously approved these changes Dec 6, 2023
View reviewed changes
Copy link
Member

@Neeharika-Sompalli Neeharika-Sompalli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !

tinker-michaelj
tinker-michaelj previously approved these changes Dec 7, 2023
View reviewed changes
Copy link
Collaborator

@tinker-michaelj tinker-michaelj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Neeharika-Sompalli Neeharika-Sompalli dismissed stale reviews from tinker-michaelj and themself via ab2e8e9 December 7, 2023 13:55
@thenswan
remove comments
baa8847 
Signed-off-by: Nikita Lebedev <nikita.lebedev@limechain.tech>
Neeharika-Sompalli
Neeharika-Sompalli approved these changes Dec 7, 2023
View reviewed changes
Copy link
Member

@Neeharika-Sompalli Neeharika-Sompalli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !

tinker-michaelj
tinker-michaelj approved these changes Dec 7, 2023
View reviewed changes
Copy link
Collaborator

@tinker-michaelj tinker-michaelj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Neeharika-Sompalli Neeharika-Sompalli merged commit 502dd56 into develop Dec 7, 2023
27 of 28 checks passed
@Neeharika-Sompalli Neeharika-Sompalli deleted the 10099-fix-contractkeyshtssuite-records branch December 7, 2023 19:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tinker-michaelj tinker-michaelj tinker-michaelj approved these changes

@Neeharika-Sompalli Neeharika-Sompalli Neeharika-Sompalli approved these changes

@povolev15 povolev15 Awaiting requested review from povolev15 povolev15 is a code owner automatically assigned from hashgraph/hedera-services

@lukelee-sl lukelee-sl Awaiting requested review from lukelee-sl lukelee-sl is a code owner automatically assigned from hashgraph/hedera-smart-contracts

Assignees

@thenswan thenswan

@Neeharika-Sompalli Neeharika-Sompalli

Labels
Limechain Work planned for the LimeChain team Modularization Issues or PRs related to modularization
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix ContractKeysHTSSuite records
4 participants
@thenswan @Neeharika-Sompalli @tinker-michaelj @mustafauzunn