fix: suite test in `TokenAndTypeCheckSuite` #10140

petreze · 2023-11-28T15:12:37Z

Description:
This PR fixes the negative suite test in TokenAndTypeCheckSuite

Related issue(s):

Fixes #10139

Notes for reviewer:

Checklist

Documented (Code comments, README, etc.)
Tested (unit, integration, etc.)

Signed-off-by: Petar Tonev <petar.tonev@limechain.tech>

github-actions · 2023-11-28T15:38:06Z

Node: HAPI Test (Crypto) Results

211 tests ±0 201 ✔️ ±0 20m 50s ⏱️ + 6m 27s
  22 suites ±0   10 💤 ±0
  22 files ±0     0 ❌ ±0

Results for commit df5c648. ± Comparison against base commit 521d5eb.

♻️ This comment has been updated with latest results.

github-actions · 2023-11-28T15:39:27Z

Node: HAPI Test (Token) Results

190 tests ±0 188 ✔️ ±0 19m 14s ⏱️ + 4m 22s
  13 suites ±0     2 💤 ±0
  13 files ±0     0 ❌ ±0

Results for commit df5c648. ± Comparison against base commit 521d5eb.

♻️ This comment has been updated with latest results.

github-actions · 2023-11-28T15:41:03Z

Node: Unit Test Results

    2 290 files ±0     2 290 suites ±0 46m 54s ⏱️ + 8m 17s
118 410 tests ±0 118 376 ✔️ ±0 34 💤 ±0 0 ❌ ±0
126 832 runs ±0 126 798 ✔️ ±0 34 💤 ±0 0 ❌ ±0

Results for commit df5c648. ± Comparison against base commit 521d5eb.

♻️ This comment has been updated with latest results.

codecov · 2023-11-28T15:41:53Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (521d5eb) 63.51% compared to head (df5c648) 63.51%.

Additional details and impacted files

@@            Coverage Diff             @@
##             develop   #10140   +/-   ##
==========================================
  Coverage      63.51%   63.51%           
  Complexity     30956    30956           
==========================================
  Files           3337     3337           
  Lines         134351   134351           
  Branches       13965    13965           
==========================================
  Hits           85336    85336           
+ Misses         45665    45661    -4     
- Partials        3350     3354    +4

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

github-actions · 2023-11-28T15:43:05Z

Node: HAPI Test (Misc) Results

419 tests ±0 313 ✔️ ±0 24m 26s ⏱️ + 4m 9s
  73 suites ±0 106 💤 ±0
  73 files ±0     0 ❌ ±0

Results for commit df5c648. ± Comparison against base commit 521d5eb.

♻️ This comment has been updated with latest results.

github-actions · 2023-11-28T15:44:37Z

Node: E2E Test Results

    1 files ±    0     1 suites ±0 28m 11s ⏱️ + 28m 11s
311 tests +310 311 ✔️ +311 0 💤 ±0 0 ❌ - 1
333 runs +332 333 ✔️ +333 0 💤 ±0 0 ❌ - 1

Results for commit df5c648. ± Comparison against base commit 521d5eb.

This pull request removes 1 and adds 311 tests. Note that renamed tests count towards both.

EndToEndTests ‑ initializationError

EndToEndTests ‑ ADDRESS_BOOK_CONTROLCanUpdateADDRESS_BOOK
EndToEndTests ‑ ADDRESS_BOOK_CONTROLCanUpdateNODE_DETAILS
EndToEndTests ‑ AccountsGetPayerRecordsIfSoConfigured
EndToEndTests ‑ Acct57CanMakeSmallChanges
EndToEndTests ‑ Acct57CantMakeLargeChanges
EndToEndTests ‑ AddingSignaturesToExecutedTxFails
EndToEndTests ‑ AddingSignaturesToExecutedTxFailsWithLongTermEnabled
EndToEndTests ‑ AddingSignaturesToNonExistingTxFails
EndToEndTests ‑ AddingSignaturesToNonExistingTxFailsWithLongTermEnabled
EndToEndTests ‑ AddressAliasIdFuzzing
…

♻️ This comment has been updated with latest results.

github-actions · 2023-11-28T15:46:39Z

Node: HAPI Test (Time Consuming) Results

21 tests ±0   9 ✔️ ±0 24m 53s ⏱️ -29s
  2 suites ±0 12 💤 ±0
  2 files ±0   0 ❌ ±0

Results for commit df5c648. ± Comparison against base commit 521d5eb.

♻️ This comment has been updated with latest results.

github-actions · 2023-11-28T15:50:09Z

Node: Integration Test Results

279 tests ±0 279 ✔️ ±0 28m 28s ⏱️ +36s
    5 suites ±0     0 💤 ±0
    5 files ±0     0 ❌ ±0

Results for commit df5c648. ± Comparison against base commit 521d5eb.

♻️ This comment has been updated with latest results.

github-actions · 2023-11-28T16:03:54Z

Node: HAPI Test (Smart Contract) Results

405 tests ±0 326 ✔️ +1 49m 47s ⏱️ + 15m 22s
  56 suites ±0   79 💤 - 1
  56 files ±0     0 ❌ ±0

Results for commit df5c648. ± Comparison against base commit 521d5eb.

♻️ This comment has been updated with latest results.

Signed-off-by: Petar Tonev <petar.tonev@limechain.tech>

kimbor

lgtm!

agadzhalov

LGTM

.../com/hedera/node/app/service/contract/impl/exec/systemcontracts/hts/istoken/IsTokenCall.java

Signed-off-by: Petar Tonev <petar.tonev@limechain.tech>

tinker-michaelj

LGTM, thx @petreze !

adapt negative suite test in token and type check

edc6499

Signed-off-by: Petar Tonev <petar.tonev@limechain.tech>

petreze added Limechain Work planned for the LimeChain team Modularization Issues or PRs related to modularization labels Nov 28, 2023

petreze self-assigned this Nov 28, 2023

petreze requested review from a team as code owners November 28, 2023 15:12

petreze requested review from jasperpotts, mhess-swl, dikel, tinker-michaelj, agadzhalov and mustafauzunn November 28, 2023 15:12

petreze added 3 commits November 28, 2023 21:38

Merge branch 'develop' into 10139-fix-token-and-type-check-suite

4d22eb8

Merge branch 'develop' into 10139-fix-token-and-type-check-suite

f275d6a

Merge branch 'develop' into 10139-fix-token-and-type-check-suite

41cbec7

petreze marked this pull request as draft November 29, 2023 13:19

petreze added 2 commits November 29, 2023 15:25

Merge branch 'develop' into 10139-fix-token-and-type-check-suite

f9b9256

fix isTokenCall behaviour and enable negative suite test

2a5bcc9

Signed-off-by: Petar Tonev <petar.tonev@limechain.tech>

petreze marked this pull request as ready for review November 29, 2023 16:12

petreze requested a review from a team as a code owner November 29, 2023 16:12

petreze requested a review from david-bakin-sl November 29, 2023 16:12

kimbor previously approved these changes Nov 29, 2023

View reviewed changes

petreze added Limechain Work planned for the LimeChain team Modularization Issues or PRs related to modularization and removed Limechain Work planned for the LimeChain team Modularization Issues or PRs related to modularization labels Nov 30, 2023

petreze changed the title ~~Fix suite test in TokenAndTypeCheckSuite~~ Fix: suite test in TokenAndTypeCheckSuite Dec 1, 2023

petreze changed the title ~~Fix: suite test in TokenAndTypeCheckSuite~~ fix: suite test in TokenAndTypeCheckSuite Dec 1, 2023

mustafauzunn requested review from tinker-michaelj and removed request for tinker-michaelj December 4, 2023 07:25

agadzhalov previously approved these changes Dec 4, 2023

View reviewed changes

mustafauzunn reviewed Dec 5, 2023

View reviewed changes

.../com/hedera/node/app/service/contract/impl/exec/systemcontracts/hts/istoken/IsTokenCall.java Outdated Show resolved Hide resolved

petreze added 2 commits December 5, 2023 10:21

Merge branch 'develop' into 10139-fix-token-and-type-check-suite

244799a

refactor: simplify return expression

df5c648

Signed-off-by: Petar Tonev <petar.tonev@limechain.tech>

petreze dismissed stale reviews from agadzhalov and kimbor via df5c648 December 5, 2023 08:32

petreze requested review from mustafauzunn, kimbor and agadzhalov December 5, 2023 08:32

bibitibooo1 added this to the v0.46 milestone Dec 5, 2023

tinker-michaelj approved these changes Dec 5, 2023

View reviewed changes

agadzhalov approved these changes Dec 6, 2023

View reviewed changes

agadzhalov merged commit 0c23887 into develop Dec 6, 2023
29 of 30 checks passed

agadzhalov deleted the 10139-fix-token-and-type-check-suite branch December 6, 2023 04:30

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: suite test in `TokenAndTypeCheckSuite` #10140

fix: suite test in `TokenAndTypeCheckSuite` #10140

petreze commented Nov 28, 2023 •

edited

Loading

github-actions bot commented Nov 28, 2023 •

edited

Loading

github-actions bot commented Nov 28, 2023 •

edited

Loading

github-actions bot commented Nov 28, 2023 •

edited

Loading

codecov bot commented Nov 28, 2023 •

edited

Loading

github-actions bot commented Nov 28, 2023 •

edited

Loading

github-actions bot commented Nov 28, 2023 •

edited

Loading

github-actions bot commented Nov 28, 2023 •

edited

Loading

github-actions bot commented Nov 28, 2023 •

edited

Loading

github-actions bot commented Nov 28, 2023 •

edited

Loading

kimbor left a comment

agadzhalov left a comment

tinker-michaelj left a comment

fix: suite test in TokenAndTypeCheckSuite #10140

fix: suite test in TokenAndTypeCheckSuite #10140

Conversation

petreze commented Nov 28, 2023 • edited Loading

github-actions bot commented Nov 28, 2023 • edited Loading

Node: HAPI Test (Crypto) Results

github-actions bot commented Nov 28, 2023 • edited Loading

Node: HAPI Test (Token) Results

github-actions bot commented Nov 28, 2023 • edited Loading

Node: Unit Test Results

codecov bot commented Nov 28, 2023 • edited Loading

Codecov Report

github-actions bot commented Nov 28, 2023 • edited Loading

Node: HAPI Test (Misc) Results

github-actions bot commented Nov 28, 2023 • edited Loading

Node: E2E Test Results

github-actions bot commented Nov 28, 2023 • edited Loading

Node: HAPI Test (Time Consuming) Results

github-actions bot commented Nov 28, 2023 • edited Loading

Node: Integration Test Results

github-actions bot commented Nov 28, 2023 • edited Loading

Node: HAPI Test (Smart Contract) Results

kimbor left a comment

Choose a reason for hiding this comment

agadzhalov left a comment

Choose a reason for hiding this comment

tinker-michaelj left a comment

Choose a reason for hiding this comment

fix: suite test in `TokenAndTypeCheckSuite` #10140

fix: suite test in `TokenAndTypeCheckSuite` #10140

petreze commented Nov 28, 2023 •

edited

Loading

github-actions bot commented Nov 28, 2023 •

edited

Loading

github-actions bot commented Nov 28, 2023 •

edited

Loading

github-actions bot commented Nov 28, 2023 •

edited

Loading

codecov bot commented Nov 28, 2023 •

edited

Loading

github-actions bot commented Nov 28, 2023 •

edited

Loading

github-actions bot commented Nov 28, 2023 •

edited

Loading

github-actions bot commented Nov 28, 2023 •

edited

Loading

github-actions bot commented Nov 28, 2023 •

edited

Loading

github-actions bot commented Nov 28, 2023 •

edited

Loading