Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: 09872: MerkleSynchronizationException: Timed out waiting to supply a new leaf to the hashing iterator buffer #10158

Merged
merged 2 commits into from Nov 30, 2023

Conversation

OlegMazurov
Copy link
Contributor

Description:
Do not timeout when adding to an internal queue. If the operation blocks for a very long time it should be considered a performance issue and addresses at the root cause (f.e. flushing).

Related issue(s):

Fixes #9872

Notes for reviewer:

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

Signed-off-by: Oleg Mazurov <oleg.mazurov@swirldslabs.com>
Copy link

github-actions bot commented Nov 29, 2023

Node: HAPI Test (Crypto) Results

211 tests  ±0   201 ✔️ ±0   20m 21s ⏱️ + 3m 5s
  22 suites ±0     10 💤 ±0 
  22 files   ±0       0 ±0 

Results for commit cdcb1b2. ± Comparison against base commit 54afb65.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented Nov 29, 2023

Node: Unit Test Results

    2 288 files  +2      2 288 suites  +2   46m 24s ⏱️ -1s
118 398 tests +7  118 364 ✔️ +7  34 💤 ±0  0 ±0 
126 770 runs  +7  126 736 ✔️ +7  34 💤 ±0  0 ±0 

Results for commit cdcb1b2. ± Comparison against base commit 54afb65.

♻️ This comment has been updated with latest results.

Copy link

codecov bot commented Nov 29, 2023

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (a2e0e80) 63.14% compared to head (cdcb1b2) 63.17%.
Report is 17 commits behind head on develop.

Files Patch % Lines
...ds/virtualmap/internal/merkle/VirtualRootNode.java 50.00% 1 Missing ⚠️
Additional details and impacted files
@@              Coverage Diff              @@
##             develop   #10158      +/-   ##
=============================================
+ Coverage      63.14%   63.17%   +0.03%     
- Complexity     30704    30708       +4     
=============================================
  Files           3327     3328       +1     
  Lines         133917   133941      +24     
  Branches       13885    13879       -6     
=============================================
+ Hits           84561    84618      +57     
+ Misses         46020    45987      -33     
  Partials        3336     3336              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

github-actions bot commented Nov 29, 2023

Node: HAPI Test (Token) Results

190 tests  ±0   188 ✔️ ±0   20m 2s ⏱️ + 2m 14s
  13 suites ±0       2 💤 ±0 
  13 files   ±0       0 ±0 

Results for commit cdcb1b2. ± Comparison against base commit 54afb65.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented Nov 29, 2023

Node: E2E Test Results

    1 files  ±    0      1 suites  ±0   23m 36s ⏱️ + 23m 36s
311 tests +310  311 ✔️ +311  0 💤 ±0  0  - 1 
333 runs  +332  333 ✔️ +333  0 💤 ±0  0  - 1 

Results for commit cdcb1b2. ± Comparison against base commit 54afb65.

This pull request removes 1 and adds 311 tests. Note that renamed tests count towards both.
EndToEndTests ‑ initializationError
EndToEndTests ‑ ADDRESS_BOOK_CONTROLCanUpdateADDRESS_BOOK
EndToEndTests ‑ ADDRESS_BOOK_CONTROLCanUpdateNODE_DETAILS
EndToEndTests ‑ AccountsGetPayerRecordsIfSoConfigured
EndToEndTests ‑ Acct57CanMakeSmallChanges
EndToEndTests ‑ Acct57CantMakeLargeChanges
EndToEndTests ‑ AddingSignaturesToExecutedTxFails
EndToEndTests ‑ AddingSignaturesToExecutedTxFailsWithLongTermEnabled
EndToEndTests ‑ AddingSignaturesToNonExistingTxFails
EndToEndTests ‑ AddingSignaturesToNonExistingTxFailsWithLongTermEnabled
EndToEndTests ‑ AddressAliasIdFuzzing
…

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented Nov 29, 2023

Node: HAPI Test (Time Consuming) Results

21 tests  ±0     9 ✔️ ±0   25m 39s ⏱️ -7s
  2 suites ±0   12 💤 ±0 
  2 files   ±0     0 ±0 

Results for commit cdcb1b2. ± Comparison against base commit 54afb65.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented Nov 29, 2023

Node: HAPI Test (Misc) Results

419 tests  +1   313 ✔️ +2   25m 41s ⏱️ + 2m 34s
  73 suites ±0   106 💤  - 1 
  73 files   ±0       0 ±0 

Results for commit cdcb1b2. ± Comparison against base commit 54afb65.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented Nov 29, 2023

Node: Integration Test Results

279 tests  ±0   279 ✔️ ±0   28m 6s ⏱️ -12s
    5 suites ±0       0 💤 ±0 
    5 files   ±0       0 ±0 

Results for commit cdcb1b2. ± Comparison against base commit 54afb65.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented Nov 29, 2023

Node: HAPI Test (Smart Contract) Results

411 tests  ±0   321 ✔️ +3   48m 27s ⏱️ + 5m 50s
  56 suites ±0     90 💤  - 3 
  56 files   ±0       0 ±0 

Results for commit cdcb1b2. ± Comparison against base commit 54afb65.

♻️ This comment has been updated with latest results.

@poulok poulok added this to the v0.45 milestone Nov 29, 2023
artemananiev
artemananiev previously approved these changes Nov 30, 2023
Signed-off-by: Oleg Mazurov <oleg.mazurov@swirldslabs.com>
@OlegMazurov OlegMazurov changed the title 09872: MerkleSynchronizationException: Timed out waiting to supply a new leaf to the hashing iterator buffer fix: 09872: MerkleSynchronizationException: Timed out waiting to supply a new leaf to the hashing iterator buffer Nov 30, 2023
@OlegMazurov OlegMazurov merged commit fb16d51 into develop Nov 30, 2023
24 of 28 checks passed
@OlegMazurov OlegMazurov deleted the 09872-reconnect-timeout-exception branch November 30, 2023 23:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

MerkleSynchronizationException: Timed out waiting to supply a new leaf to the hashing iterator buffer
4 participants