Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2095 fix redundant unused statements in test code #10163

Conversation

mwb-al
Copy link
Contributor

@mwb-al mwb-al commented Nov 29, 2023

Description:
This PR changes the following:

  • Remove redundant setup() method in OwnershipTrackerTest (JUnit 5 auto-instantiation)
  • Remove redundant metadata assignment in UniqueTokenTest

Related issue(s):
Closes #2095

Signed-off-by: Michał Walczak <michal.walczak@arianelabs.com>
…-instantiation)

Signed-off-by: Michał Walczak <michal.walczak@arianelabs.com>
@mwb-al mwb-al requested review from a team as code owners November 29, 2023 12:11
@mwb-al mwb-al requested a review from netopyr November 29, 2023 12:11
Copy link

codecov bot commented Nov 29, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

❗ No coverage uploaded for pull request base (develop@b9add91). Click here to learn what that means.

Additional details and impacted files
@@            Coverage Diff             @@
##             develop   #10163   +/-   ##
==========================================
  Coverage           ?   63.14%           
  Complexity         ?    30701           
==========================================
  Files              ?     3327           
  Lines              ?   133917           
  Branches           ?    13885           
==========================================
  Hits               ?    84557           
  Misses             ?    46017           
  Partials           ?     3343           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@kimbor kimbor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very straightforward, an easy approval

@rbair23 rbair23 merged commit 7116c8c into hashgraph:develop Nov 30, 2023
16 of 17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix redundant/unused statements in test code.
3 participants