Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ISS detection. #10183

Merged
merged 3 commits into from Nov 30, 2023
Merged

Fix ISS detection. #10183

merged 3 commits into from Nov 30, 2023

Conversation

cody-littley
Copy link
Contributor

Related to #10181

Signed-off-by: Cody Littley <cody@swirldslabs.com>
Copy link

github-actions bot commented Nov 30, 2023

Node: HAPI Test (Crypto) Results

211 tests  ±0   201 ✔️ ±0   20m 45s ⏱️ + 1m 13s
  22 suites ±0     10 💤 ±0 
  22 files   ±0       0 ±0 

Results for commit 9793084. ± Comparison against base commit 17a7b93.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented Nov 30, 2023

Node: Unit Test Results

    2 288 files  ±0      2 288 suites  ±0   47m 2s ⏱️ - 1m 36s
118 399 tests  - 5  118 365 ✔️  - 5  34 💤 ±0  0 ±0 
126 771 runs   - 5  126 737 ✔️  - 5  34 💤 ±0  0 ±0 

Results for commit 9793084. ± Comparison against base commit 17a7b93.

♻️ This comment has been updated with latest results.

Copy link

codecov bot commented Nov 30, 2023

Codecov Report

Attention: 6 lines in your changes are missing coverage. Please review.

Comparison is base (17a7b93) 63.16% compared to head (9793084) 63.16%.
Report is 2 commits behind head on develop.

Files Patch % Lines
...irlds/platform/state/iss/ConsensusHashManager.java 0.00% 4 Missing ⚠️
...rlds/common/system/events/BaseEventHashedData.java 0.00% 1 Missing ⚠️
...irlds/platform/state/signed/StartupStateUtils.java 0.00% 1 Missing ⚠️
Additional details and impacted files
@@              Coverage Diff              @@
##             develop   #10183      +/-   ##
=============================================
- Coverage      63.16%   63.16%   -0.01%     
+ Complexity     30710    30705       -5     
=============================================
  Files           3328     3328              
  Lines         133955   133945      -10     
  Branches       13884    13881       -3     
=============================================
- Hits           84615    84608       -7     
- Misses         45993    45997       +4     
+ Partials        3347     3340       -7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

github-actions bot commented Nov 30, 2023

Node: HAPI Test (Token) Results

190 tests  ±0   188 ✔️ ±0   19m 45s ⏱️ - 2m 44s
  13 suites ±0       2 💤 ±0 
  13 files   ±0       0 ±0 

Results for commit 9793084. ± Comparison against base commit 17a7b93.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented Nov 30, 2023

Node: E2E Test Results

    1 files  ±    0      1 suites  ±0   23m 41s ⏱️ + 23m 41s
311 tests +310  311 ✔️ +311  0 💤 ±0  0  - 1 
333 runs  +332  333 ✔️ +333  0 💤 ±0  0  - 1 

Results for commit 9793084. ± Comparison against base commit 17a7b93.

This pull request removes 1 and adds 311 tests. Note that renamed tests count towards both.
EndToEndTests ‑ initializationError
EndToEndTests ‑ ADDRESS_BOOK_CONTROLCanUpdateADDRESS_BOOK
EndToEndTests ‑ ADDRESS_BOOK_CONTROLCanUpdateNODE_DETAILS
EndToEndTests ‑ AccountsGetPayerRecordsIfSoConfigured
EndToEndTests ‑ Acct57CanMakeSmallChanges
EndToEndTests ‑ Acct57CantMakeLargeChanges
EndToEndTests ‑ AddingSignaturesToExecutedTxFails
EndToEndTests ‑ AddingSignaturesToExecutedTxFailsWithLongTermEnabled
EndToEndTests ‑ AddingSignaturesToNonExistingTxFails
EndToEndTests ‑ AddingSignaturesToNonExistingTxFailsWithLongTermEnabled
EndToEndTests ‑ AddressAliasIdFuzzing
…

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented Nov 30, 2023

Node: HAPI Test (Time Consuming) Results

21 tests  ±0     9 ✔️ ±0   25m 59s ⏱️ +26s
  2 suites ±0   12 💤 ±0 
  2 files   ±0     0 ±0 

Results for commit 9793084. ± Comparison against base commit 17a7b93.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented Nov 30, 2023

Node: HAPI Test (Misc) Results

419 tests  ±0   313 ✔️ ±0   25m 46s ⏱️ -9s
  73 suites ±0   106 💤 ±0 
  73 files   ±0       0 ±0 

Results for commit 9793084. ± Comparison against base commit 17a7b93.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented Nov 30, 2023

Node: Integration Test Results

279 tests  ±0   279 ✔️ +2   28m 22s ⏱️ +19s
    5 suites ±0       0 💤 ±0 
    5 files   ±0       0  - 2 

Results for commit 9793084. ± Comparison against base commit 17a7b93.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented Nov 30, 2023

Node: HAPI Test (Smart Contract) Results

411 tests  ±0   321 ✔️ ±0   46m 5s ⏱️ +56s
  56 suites ±0     90 💤 ±0 
  56 files   ±0       0 ±0 

Results for commit 9793084. ± Comparison against base commit 17a7b93.

♻️ This comment has been updated with latest results.

Signed-off-by: Cody Littley <cody@swirldslabs.com>
Signed-off-by: Cody Littley <cody@swirldslabs.com>
@cody-littley cody-littley merged commit 44ab604 into develop Nov 30, 2023
23 of 25 checks passed
@cody-littley cody-littley deleted the 10181-D-fix-iss-detection branch November 30, 2023 20:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants