Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Handle ArithmeticException in safeFractionMultiply() #10200

Merged
merged 4 commits into from Dec 1, 2023

Conversation

iwsimon
Copy link
Contributor

@iwsimon iwsimon commented Nov 30, 2023

Description:

Related issue(s):

Fixes #9690

Notes for reviewer:

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

Signed-off-by: Iris Simon <iris.simon@swirldslabs.com>
@iwsimon iwsimon self-assigned this Nov 30, 2023
@iwsimon iwsimon requested review from a team as code owners November 30, 2023 19:25
Signed-off-by: Iris Simon <iris.simon@swirldslabs.com>
Copy link

github-actions bot commented Nov 30, 2023

Node: HAPI Test (Crypto) Results

211 tests  ±0   201 ✔️ +57   19m 29s ⏱️ + 4m 23s
  22 suites ±0     10 💤 ±  0 
  22 files   ±0       0  - 57 

Results for commit d169ef1. ± Comparison against base commit 8edfb51.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented Nov 30, 2023

Node: HAPI Test (Token) Results

190 tests  ±0   188 ✔️ ±0   22m 16s ⏱️ + 2m 28s
  13 suites ±0       2 💤 ±0 
  13 files   ±0       0 ±0 

Results for commit d169ef1. ± Comparison against base commit 8edfb51.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented Nov 30, 2023

Node: Unit Test Results

    2 288 files  ±0      2 288 suites  ±0   45m 9s ⏱️ -48s
118 398 tests ±0  118 364 ✔️ ±0  34 💤 ±0  0 ±0 
126 770 runs  ±0  126 736 ✔️ ±0  34 💤 ±0  0 ±0 

Results for commit d169ef1. ± Comparison against base commit 8edfb51.

♻️ This comment has been updated with latest results.

Copy link

codecov bot commented Nov 30, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

❗ No coverage uploaded for pull request base (develop@8edfb51). Click here to learn what that means.

Additional details and impacted files
@@            Coverage Diff             @@
##             develop   #10200   +/-   ##
==========================================
  Coverage           ?   63.16%           
  Complexity         ?    30708           
==========================================
  Files              ?     3329           
  Lines              ?   133981           
  Branches           ?    13884           
==========================================
  Hits               ?    84630           
  Misses             ?    46010           
  Partials           ?     3341           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

github-actions bot commented Nov 30, 2023

Node: HAPI Test (Time Consuming) Results

21 tests     9 ✔️  26m 13s ⏱️
  2 suites  12 💤
  2 files      0

Results for commit d169ef1.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented Nov 30, 2023

Node: E2E Test Results

    1 files      1 suites   21m 9s ⏱️
311 tests 311 ✔️ 0 💤 0
333 runs  333 ✔️ 0 💤 0

Results for commit d169ef1.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented Nov 30, 2023

Node: HAPI Test (Misc) Results

419 tests  ±0   313 ✔️ ±0   28m 8s ⏱️ + 3m 53s
  73 suites ±0   106 💤 ±0 
  73 files   ±0       0 ±0 

Results for commit d169ef1. ± Comparison against base commit 8edfb51.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented Nov 30, 2023

Node: Integration Test Results

279 tests  ±0   279 ✔️ +1   28m 23s ⏱️ -2s
    5 suites ±0       0 💤 ±0 
    5 files   ±0       0  - 1 

Results for commit d169ef1. ± Comparison against base commit 8edfb51.

♻️ This comment has been updated with latest results.

Copy link
Member

@Neeharika-Sompalli Neeharika-Sompalli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ! Seems there are HAPI test failures

Copy link

github-actions bot commented Nov 30, 2023

Node: HAPI Test (Smart Contract) Results

405 tests  ±0   324 ✔️ ±0   43m 41s ⏱️ - 1m 51s
  56 suites ±0     81 💤 ±0 
  56 files   ±0       0 ±0 

Results for commit d169ef1. ± Comparison against base commit 8edfb51.

♻️ This comment has been updated with latest results.

@iwsimon iwsimon merged commit ba16e00 into develop Dec 1, 2023
26 of 27 checks passed
@iwsimon iwsimon deleted the 9690-safeFractionMultiply branch December 1, 2023 18:26
mhess-swl pushed a commit that referenced this pull request Dec 4, 2023
Signed-off-by: Iris Simon <iris.simon@swirldslabs.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Handle ArithmeticException in safeFractionMultiply()
2 participants