New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Handle ArithmeticException in safeFractionMultiply() #10200
Conversation
Signed-off-by: Iris Simon <iris.simon@swirldslabs.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #10200 +/- ##
==========================================
Coverage ? 63.16%
Complexity ? 30708
==========================================
Files ? 3329
Lines ? 133981
Branches ? 13884
==========================================
Hits ? 84630
Misses ? 46010
Partials ? 3341 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM ! Seems there are HAPI test failures
Signed-off-by: Iris Simon <iris.simon@swirldslabs.com>
Description:
Related issue(s):
Fixes #9690
Notes for reviewer:
Checklist