test: Fix transferFailsWithIncorrectAmounts test #10214
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Node: E2E Test Results 1 files ± 0 1 suites ±0 24m 56s ⏱️ + 24m 56s Results for commit 48a2a4a. ± Comparison against base commit 3a99e37. This pull request removes 1 and adds 311 tests. Note that renamed tests count towards both.♻️ This comment has been updated with latest results. |
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## develop #10214 +/- ##
=============================================
- Coverage 63.01% 62.99% -0.02%
+ Complexity 30824 30816 -8
=============================================
Files 3363 3363
Lines 135414 135419 +5
Branches 14092 14091 -1
=============================================
- Hits 85325 85305 -20
- Misses 46730 46754 +24
- Partials 3359 3360 +1 ☔ View full report in Codecov by Sentry. |
netopyr
previously approved these changes
Dec 11, 2023
tinker-michaelj
requested changes
Dec 11, 2023
Signed-off-by: Stanimir Stoyanov <stanimir.stoyanov@limechain.tech>
Signed-off-by: Stanimir Stoyanov <stanimir.stoyanov@limechain.tech>
Signed-off-by: Stanimir Stoyanov <stanimir.stoyanov@limechain.tech>
Signed-off-by: Stanimir Stoyanov <stanimir.stoyanov@limechain.tech>
Signed-off-by: Stanimir Stoyanov <stanimir.stoyanov@limechain.tech>
Signed-off-by: Stanimir Stoyanov <stanimir.stoyanov@limechain.tech>
Signed-off-by: Stanimir Stoyanov <stanimir.stoyanov@limechain.tech>
Signed-off-by: Stanimir Stoyanov <stanimir.stoyanov@limechain.tech>
stoyanov-st
force-pushed
the
09396-fix-transfer-fails-with-incorrect-amounts
branch
from
f47ab20
to
388f163
Compare
Signed-off-by: Stanimir Stoyanov <stanimir.stoyanov@limechain.tech>
Signed-off-by: Stanimir Stoyanov <stanimir.stoyanov@limechain.tech>
Signed-off-by: Stanimir Stoyanov <stanimir.stoyanov@limechain.tech>
…mounts # Conflicts: # hedera-node/test-clients/src/main/java/com/hedera/services/bdd/suites/leaky/LeakyContractTestsSuite.java
Signed-off-by: Stanimir Stoyanov <stanimir.stoyanov@limechain.tech>
tinker-michaelj
approved these changes
Dec 14, 2023
There was a problem hiding this comment.
I think it's more general and readable to add a @Nullable ResponseCodeEnum preemptingFailureStatus to the ClassicTransfersCall constructor; and set it based on the 3rd argument being negative.
But this works for now, tyvm @stoyanov-st !
tinker-michaelj
requested changes
Dec 14, 2023
There was a problem hiding this comment.
Hmm actually this change has unintended consequences and breaks other specs.
I'd suggest adding the @Nullable ResponseCodeEnum preemptingFailureStatus.
Signed-off-by: Stanimir Stoyanov <stanimir.stoyanov@limechain.tech>
Signed-off-by: Stanimir Stoyanov <stanimir.stoyanov@limechain.tech>
Signed-off-by: Stanimir Stoyanov <stanimir.stoyanov@limechain.tech>
tinker-michaelj
approved these changes
Dec 18, 2023
stoyanov-st
deleted the
09396-fix-transfer-fails-with-incorrect-amounts
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Added a missing check for the amounts to be transferred while executing the classic token transfer function.
Related issue(s):
Fixes #
#9396
Notes for reviewer:
Checklist