feat(migration): Migrate contract store (contract's slots) from monservice to modular-service representation #10252
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
david-bakin-sl
requested review from
Neeharika-Sompalli,
povolev15,
tomzhenghedera and
leninmehedy
2 tasks
david-bakin-sl
force-pushed
the
10210-contract-store-migration
branch
from
b557afc
to
d38705a
Compare
david-bakin-sl
force-pushed
the
10210-contract-store-migration
branch
from
d38705a
to
4044026
Compare
…service to modular-service representation
New class `ContractStateMigrator` will migrate from a mono service's contract store representation to a modular
service's contract store (given by a `WritableKVStore`).
Can optionally perform a validation on the resulting migrated state, ensuring that it is consistent in some ways
* has same number of entries as original state
* all linked lists of slots are still linked
Shown correct by enhancing the contract store dumper to (optionally) migrate the contract store before dumping it.
Diff on the two dumps (without migration and with migration) shows only the summary line changes: and that only to
include a migration flag (to distinguish them).
Has code that commits the migration-in-progress modular store every 10000 items added (to force flush-to-disk). Tricky
thing there is there doesn't appear currently to be any access path from a `WritableKVState` to get to the point where
you can `copy()` the underlying `VirtualMap`/`MerkleMap`. But the _caller_ must have access to the underlying
structure. And so the caller passes in an operator that does the commit + copy and returns the new store to work with.
An example command line for the dumper:
```
./services-cli.sh signed-state -f states/2023-10-29T03:18:19Z/151988064/SignedState.swh dump contract-stores -k -s \
--migration --validate-migration \
-o 2023-10-29T03:18:19Z-151988064.contract-stores.new.txt
```
Fixes #10210
Signed-off-by: David S Bakin <117694041+david-bakin-sl@users.noreply.github.com>
david-bakin-sl
force-pushed
the
10210-contract-store-migration
branch
from
4044026
to
b2cb512
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #10252 +/- ##
==========================================
Coverage ? 63.53%
Complexity ? 30933
==========================================
Files ? 3331
Lines ? 134235
Branches ? 13951
==========================================
Hits ? 85286
Misses ? 45592
Partials ? 3357 ☔ View full report in Codecov by Sentry. |
... mainly to kick the Github DCO service to get its act together Signed-off-by: David S Bakin <117694041+david-bakin-sl@users.noreply.github.com>
jeromy-cannon
previously approved these changes
Dec 4, 2023
jeromy-cannon
approved these changes
Dec 4, 2023
mhess-swl
approved these changes
Dec 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
New class
ContractStateMigratorwill migrate from a mono service's contract store representation to a modular service's contract store (given by aWritableKVStore).Can optionally perform a validation on the resulting migrated state, ensuring that it is consistent in some ways
Shown correct by enhancing the contract store dumper to (optionally) migrate the contract store before dumping it. Diff on the two dumps (without migration and with migration) shows only the summary line changes: and that only to include a migration flag (to distinguish them).
Has code that commits the migration-in-progress modular store every 10000 items added (to force flush-to-disk). Tricky thing there is there doesn't appear currently to be any access path from a
WritableKVStateto get to the point where you cancopy()the underlyingVirtualMap/MerkleMap. But the caller must have access to the underlying structure. And so the caller passes in an operator that does the commit + copy and returns the new store to work with.An example command line for the dumper:
Related issue(s):
Fixes #10210
Checklist