Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: fix some sonar bugs and suppress others #10261

Merged
merged 7 commits into from Dec 7, 2023
Merged

fix: fix some sonar bugs and suppress others #10261

merged 7 commits into from Dec 7, 2023

Conversation

povolev15
Copy link
Contributor

@povolev15 povolev15 commented Dec 4, 2023 •
edited by kimbor

@povolev15 povolev15 self-assigned this Dec 4, 2023
@povolev15 povolev15 changed the title fix solar bugs and supress some fix solar bugs and suppress some Dec 4, 2023
@povolev15 povolev15 changed the title fix solar bugs and suppress some bug: fix solar bugs and suppress some Dec 4, 2023
@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 4, 2023 •
edited

Node: HAPI Test (Crypto) Results

211 tests  ±0   201 ✔️ ±0   18m 9s ⏱️ +47s
  22 suites ±0     10 💤 ±0 
  22 files   ±0       0 ❌ ±0 

Results for commit 922fd0b. ± Comparison against base commit 1d6aedd.

♻️ This comment has been updated with latest results.

jsync-swirlds
jsync-swirlds reviewed Dec 4, 2023
View reviewed changes
Copy link
Member

@jsync-swirlds jsync-swirlds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One nit and a couple question items.

hedera-node/test-clients/src/main/java/com/hedera/services/bdd/junit/InProcessHapiTestNode.java Outdated Show resolved Hide resolved
hedera-node/hedera-app/src/main/java/com/hedera/node/app/fees/FeeManager.java Show resolved Hide resolved
hedera-node/hedera-app/src/main/java/com/hedera/node/app/workflows/SolvencyPreCheck.java Show resolved Hide resolved
@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 4, 2023 •
edited

Node: HAPI Test (Token) Results

190 tests  ±0   188 ✔️ ±0   20m 13s ⏱️ + 1m 13s
  13 suites ±0       2 💤 ±0 
  13 files   ±0       0 ❌ ±0 

Results for commit 922fd0b. ± Comparison against base commit 1d6aedd.

♻️ This comment has been updated with latest results.

@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 4, 2023 •
edited

Node: Unit Test Results

    2 293 files  ±0      2 293 suites  ±0   48m 46s ⏱️ + 3m 25s
118 431 tests ±0  118 397 ✔️ ±0  34 💤 ±0  0 ❌ ±0 
126 853 runs  ±0  126 819 ✔️ ±0  34 💤 ±0  0 ❌ ±0 

Results for commit 922fd0b. ± Comparison against base commit 1d6aedd.

♻️ This comment has been updated with latest results.

@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 4, 2023 •
edited

Node: HAPI Test (Misc) Results

419 tests  ±0   316 ✔️ ±0   25m 22s ⏱️ - 1m 21s
  73 suites ±0   103 💤 ±0 
  73 files   ±0       0 ❌ ±0 

Results for commit 922fd0b. ± Comparison against base commit 1d6aedd.

♻️ This comment has been updated with latest results.

@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 4, 2023 •
edited

Node: E2E Test Results

    1 files  ±    0      1 suites  ±0   23m 31s ⏱️ + 23m 31s
311 tests +310  311 ✔️ +311  0 💤 ±0  0 ❌  - 1 
333 runs  +332  333 ✔️ +333  0 💤 ±0  0 ❌  - 1 

Results for commit 922fd0b. ± Comparison against base commit 1d6aedd.

This pull request removes 1 and adds 311 tests. Note that renamed tests count towards both. 
EndToEndTests ‑ initializationError

EndToEndTests ‑ ADDRESS_BOOK_CONTROLCanUpdateADDRESS_BOOK
EndToEndTests ‑ ADDRESS_BOOK_CONTROLCanUpdateNODE_DETAILS
EndToEndTests ‑ AccountsGetPayerRecordsIfSoConfigured
EndToEndTests ‑ Acct57CanMakeSmallChanges
EndToEndTests ‑ Acct57CantMakeLargeChanges
EndToEndTests ‑ AddingSignaturesToExecutedTxFails
EndToEndTests ‑ AddingSignaturesToExecutedTxFailsWithLongTermEnabled
EndToEndTests ‑ AddingSignaturesToNonExistingTxFails
EndToEndTests ‑ AddingSignaturesToNonExistingTxFailsWithLongTermEnabled
EndToEndTests ‑ AddressAliasIdFuzzing
…

♻️ This comment has been updated with latest results.

@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 4, 2023 •
edited

Node: HAPI Test (Time Consuming) Results

21 tests  ±0     9 ✔️ ±0   24m 48s ⏱️ - 1m 8s
  2 suites ±0   12 💤 ±0 
  2 files   ±0     0 ❌ ±0 

Results for commit 922fd0b. ± Comparison against base commit 1d6aedd.

♻️ This comment has been updated with latest results.

@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 4, 2023 •
edited

Node: HAPI Test (Smart Contract) Results

396 tests  ±0   349 ✔️ ±0   48m 45s ⏱️ + 1m 9s
  55 suites ±0     47 💤 ±0 
  55 files   ±0       0 ❌ ±0 

Results for commit 922fd0b. ± Comparison against base commit 1d6aedd.

♻️ This comment has been updated with latest results.

@jsync-swirlds jsync-swirlds changed the title bug: fix solar bugs and suppress some fix: fix solar bugs and suppress some Dec 4, 2023
@jsync-swirlds jsync-swirlds changed the title fix: fix solar bugs and suppress some fix: fix some sonar bugs and suppress others Dec 4, 2023
kimbor
kimbor previously approved these changes Dec 6, 2023
View reviewed changes
netopyr
netopyr previously approved these changes Dec 7, 2023
View reviewed changes
@povolev15
fix solar bugs and supress some
964cbeb 
Signed-off-by: Lev Povolotsky <lev@swirldslabs.com>
@povolev15
spotless and pr comments
3208093 
Signed-off-by: Lev Povolotsky <lev@swirldslabs.com>
@povolev15
fix bug
7ad3297 
Signed-off-by: Lev Povolotsky <lev@swirldslabs.com>
@povolev15
address pr comments
f74b5d0 
Signed-off-by: Lev Povolotsky <lev@swirldslabs.com>
@povolev15
remove the exception
2c8ffae 
Signed-off-by: Lev Povolotsky <lev@swirldslabs.com>
@povolev15
fix pr comments
7d726bf 
Signed-off-by: Lev Povolotsky <lev@swirldslabs.com>
@povolev15
fix NPE
922fd0b 
Signed-off-by: Lev Povolotsky <lev@swirldslabs.com>
tinker-michaelj
tinker-michaelj approved these changes Dec 7, 2023
View reviewed changes
Copy link
Collaborator

@tinker-michaelj tinker-michaelj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@povolev15 povolev15 merged commit 726aeb2 into develop Dec 7, 2023
32 of 33 checks passed
@povolev15 povolev15 deleted the 9898-fix-bugs branch December 7, 2023 15:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timo0 timo0 timo0 approved these changes

@tinker-michaelj tinker-michaelj tinker-michaelj approved these changes

@Nana-EC Nana-EC Nana-EC approved these changes

@cody-littley cody-littley cody-littley approved these changes

@mxtartaglia-sl mxtartaglia-sl Awaiting requested review from mxtartaglia-sl mxtartaglia-sl is a code owner automatically assigned from hashgraph/platform-base

@lukelee-sl lukelee-sl Awaiting requested review from lukelee-sl lukelee-sl is a code owner automatically assigned from hashgraph/hedera-smart-contracts

@jsync-swirlds jsync-swirlds Awaiting requested review from jsync-swirlds

@kimbor kimbor Awaiting requested review from kimbor

@anthony-swirldslabs anthony-swirldslabs Awaiting requested review from anthony-swirldslabs

@netopyr netopyr Awaiting requested review from netopyr

@edward-swirldslabs edward-swirldslabs Awaiting requested review from edward-swirldslabs

Assignees

@povolev15 povolev15

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix bugs reported by Sonar
10 participants
@povolev15 @kimbor @timo0 @netopyr @tinker-michaelj @Nana-EC @cody-littley @jsync-swirlds @edward-swirldslabs @anthony-swirldslabs