New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: remove incompatible ip printing in linux #10296
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mxtartaglia-sl
requested review from
poulok and
cody-littley
and removed request for
poulok
December 5, 2023 19:23
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #10296 +/- ##
=============================================
+ Coverage 63.51% 63.54% +0.03%
- Complexity 30953 30968 +15
=============================================
Files 3337 3337
Lines 134351 134397 +46
Branches 13965 13965
=============================================
+ Hits 85334 85408 +74
+ Misses 45661 45639 -22
+ Partials 3356 3350 -6 ☔ View full report in Codecov by Sentry. |
mxtartaglia-sl
force-pushed
the
10295-fix-ui-linux
branch
2 times, most recently
from
December 5, 2023 20:40
f57f473
to
7f9036c
Compare
cody-littley
approved these changes
Dec 5, 2023
Signed-off-by: Maxi Tartaglia <maxi@swirldslabs.com>
mxtartaglia-sl
force-pushed
the
10295-fix-ui-linux
branch
from
December 5, 2023 21:00
7f9036c
to
3bc267d
Compare
mxtartaglia-sl
changed the title
Remove incompatible ip printing in linux
fix: remove incompatible ip printing in linux
Dec 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This pr removes the ip printing for the ui. When executed in a linux environment it was introducing an invalid character in the string interpreted as a format character that ended up in the following exception after:
Checklist