Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove incompatible ip printing in linux #10296

Merged
merged 1 commit into from Dec 6, 2023

Conversation

mxtartaglia-sl
Copy link
Contributor

@mxtartaglia-sl mxtartaglia-sl commented Dec 5, 2023

Description:
This pr removes the ip printing for the ui. When executed in a linux environment it was introducing an invalid character in the string interpreted as a format character that ended up in the following exception after:

java.util.UnknownFormatConversionException: Conversion = 'w'
        at java.base/java.util.Formatter$FormatSpecifier.conversion(Formatter.java:2855) ~[?:?]
        at java.base/java.util.Formatter$FormatSpecifier.<init>(Formatter.java:2891) ~[?:?]
        at java.base/java.util.Formatter.parse(Formatter.java:2747) ~[?:?]
        at java.base/java.util.Formatter.format(Formatter.java:2671) ~[?:?]
        at java.base/java.util.Formatter.format(Formatter.java:2625) ~[?:?]
        at java.base/java.lang.String.format(String.java:4145) ~[?:?]
        at com.swirlds.demo.hashgraph.HashgraphDemoMain$Picture.print(HashgraphDemoMain.java:221) ~[?:?]
        at com.swirlds.demo.hashgraph.HashgraphDemoMain$Picture.paintComponent(HashgraphDemoMain.java:258) ~[?:?]

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

@mxtartaglia-sl mxtartaglia-sl requested a review from a team as a code owner December 5, 2023 19:23
@mxtartaglia-sl mxtartaglia-sl requested review from poulok and cody-littley and removed request for poulok December 5, 2023 19:23
Copy link

github-actions bot commented Dec 5, 2023

Node: Unit Test Results

    2 290 files  ±0      2 290 suites  ±0   45m 53s ⏱️ - 2m 1s
118 414 tests ±0  118 380 ✔️ ±0  34 💤 ±0  0 ±0 
126 836 runs  ±0  126 802 ✔️ ±0  34 💤 ±0  0 ±0 

Results for commit 3bc267d. ± Comparison against base commit 968068f.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented Dec 5, 2023

Node: HAPI Test (Crypto) Results

211 tests   201 ✔️  16m 44s ⏱️
  22 suites    10 💤
  22 files        0

Results for commit 3bc267d.

♻️ This comment has been updated with latest results.

Copy link

codecov bot commented Dec 5, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (3b0ea4f) 63.51% compared to head (3bc267d) 63.54%.
Report is 3 commits behind head on develop.

Additional details and impacted files
@@              Coverage Diff              @@
##             develop   #10296      +/-   ##
=============================================
+ Coverage      63.51%   63.54%   +0.03%     
- Complexity     30953    30968      +15     
=============================================
  Files           3337     3337              
  Lines         134351   134397      +46     
  Branches       13965    13965              
=============================================
+ Hits           85334    85408      +74     
+ Misses         45661    45639      -22     
+ Partials        3356     3350       -6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

github-actions bot commented Dec 5, 2023

Node: HAPI Test (Token) Results

190 tests   188 ✔️  21m 18s ⏱️
  13 suites      2 💤
  13 files        0

Results for commit 3bc267d.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented Dec 5, 2023

Node: E2E Test Results

    1 files      1 suites   26m 59s ⏱️
311 tests 311 ✔️ 0 💤 0
333 runs  333 ✔️ 0 💤 0

Results for commit 3bc267d.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented Dec 5, 2023

Node: HAPI Test (Time Consuming) Results

21 tests     9 ✔️  26m 22s ⏱️
  2 suites  12 💤
  2 files      0

Results for commit 3bc267d.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented Dec 5, 2023

Node: HAPI Test (Misc) Results

419 tests   313 ✔️  28m 28s ⏱️
  73 suites  106 💤
  73 files        0

Results for commit 3bc267d.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented Dec 5, 2023

Node: Integration Test Results

279 tests   279 ✔️  28m 1s ⏱️
    5 suites      0 💤
    5 files        0

Results for commit 3bc267d.

♻️ This comment has been updated with latest results.

@mxtartaglia-sl mxtartaglia-sl force-pushed the 10295-fix-ui-linux branch 2 times, most recently from f57f473 to 7f9036c Compare December 5, 2023 20:40
@mxtartaglia-sl mxtartaglia-sl linked an issue Dec 5, 2023 that may be closed by this pull request
Signed-off-by: Maxi Tartaglia <maxi@swirldslabs.com>
@mxtartaglia-sl mxtartaglia-sl changed the title Remove incompatible ip printing in linux fix: remove incompatible ip printing in linux Dec 5, 2023
Copy link

github-actions bot commented Dec 5, 2023

Node: HAPI Test (Smart Contract) Results

405 tests   325 ✔️  52m 16s ⏱️
  56 suites    80 💤
  56 files        0

Results for commit 3bc267d.

@mxtartaglia-sl mxtartaglia-sl merged commit 719f074 into develop Dec 6, 2023
26 of 28 checks passed
@mxtartaglia-sl mxtartaglia-sl deleted the 10295-fix-ui-linux branch December 6, 2023 10:38
@mxtartaglia-sl mxtartaglia-sl self-assigned this Dec 7, 2023
@mxtartaglia-sl mxtartaglia-sl added this to the v0.46 milestone Dec 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix UI to be compatible with linux
2 participants