fix: ERC approve and remove scenarios #10325
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Mustafa Uzun <mustafa.uzun@limechain.tech>
Signed-off-by: Mustafa Uzun <mustafa.uzun@limechain.tech>
Signed-off-by: Mustafa Uzun <mustafa.uzun@limechain.tech>
Signed-off-by: Mustafa Uzun <mustafa.uzun@limechain.tech>
Signed-off-by: Mustafa Uzun <mustafa.uzun@limechain.tech>
Signed-off-by: Mustafa Uzun <mustafa.uzun@limechain.tech>
Signed-off-by: Mustafa Uzun <mustafa.uzun@limechain.tech>
…0188-fix-approve-and-remove-scenarios
Signed-off-by: Mustafa Uzun <mustafa.uzun@limechain.tech>
Signed-off-by: Mustafa Uzun <mustafa.uzun@limechain.tech>
Node: E2E Test Results 1 files ± 0 1 suites ±0 24m 16s ⏱️ + 24m 16s Results for commit 0344f31. ± Comparison against base commit c81d6f3. This pull request removes 1 and adds 311 tests. Note that renamed tests count towards both.♻️ This comment has been updated with latest results. |
Signed-off-by: Mustafa Uzun <mustafa.uzun@limechain.tech>
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## develop #10325 +/- ##
=============================================
- Coverage 63.04% 63.03% -0.01%
- Complexity 30838 30851 +13
=============================================
Files 3363 3363
Lines 135487 135549 +62
Branches 14096 14104 +8
=============================================
+ Hits 85416 85450 +34
- Misses 46714 46731 +17
- Partials 3357 3368 +11 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Mustafa Uzun <mustafa.uzun@limechain.tech>
Signed-off-by: Mustafa Uzun <mustafa.uzun@limechain.tech>
Signed-off-by: Mustafa Uzun <mustafa.uzun@limechain.tech>
Signed-off-by: Mustafa Uzun <mustafa.uzun@limechain.tech>
Signed-off-by: Mustafa Uzun <mustafa.uzun@limechain.tech>
Signed-off-by: Mustafa Uzun <mustafa.uzun@limechain.tech>
Signed-off-by: Mustafa Uzun <mustafa.uzun@limechain.tech>
Signed-off-by: Mustafa Uzun <mustafa.uzun@limechain.tech>
Signed-off-by: Stanimir Stoyanov <stanimir.stoyanov@limechain.tech>
mustafauzunn
requested review from
a team and
tinker-michaelj
as code owners
Signed-off-by: Mustafa Uzun <mustafa.uzun@limechain.tech>
Signed-off-by: Mustafa Uzun <mustafa.uzun@limechain.tech>
Signed-off-by: Mustafa Uzun <mustafa.uzun@limechain.tech>
Signed-off-by: Stanimir Stoyanov <stanimir.stoyanov@limechain.tech>
Signed-off-by: Stanimir Stoyanov <stanimir.stoyanov@limechain.tech>
.../main/java/com/hedera/node/app/service/token/impl/handlers/CryptoDeleteAllowanceHandler.java
Outdated
Show resolved
Hide resolved
.../service/contract/impl/exec/systemcontracts/hts/grantapproval/AbstractGrantApprovalCall.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Stanimir Stoyanov <stanimir.stoyanov@limechain.tech>
# Conflicts: # hedera-node/hedera-smart-contract-service-impl/src/main/java/com/hedera/node/app/service/contract/impl/utils/SystemContractUtils.java
.../main/java/com/hedera/node/app/service/token/impl/handlers/CryptoDeleteAllowanceHandler.java
Outdated
Show resolved
Hide resolved
tinker-michaelj
previously approved these changes
Dec 19, 2023
There was a problem hiding this comment.
There is one if condition we need to remove because it would break an HTS CryptoDeleteAllowance edge case.
But overall with all checks passing, LGTM! tyvm @mustafauzunn
Signed-off-by: Stanimir Stoyanov <stanimir.stoyanov@limechain.tech>
…narios' into 10188-fix-approve-and-remove-scenarios
tinker-michaelj
approved these changes
Dec 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Fix ERC approve and remove scenarios
Related issue(s):
Fixes #10188
Notes for reviewer:
Checklist