Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Implement lazyCreationCostInGas method #10337

Merged
merged 3 commits into from Dec 7, 2023

Conversation

lukelee-sl
Copy link
Member

Description:
Implement the lazyCreationCostInGas method in the HandleHederaOperations class.

Related issue(s):

Fixes #10336

Notes for reviewer:
This was part of a larger pr but is pulled out to potentially unblock some HAPI tests that depend on this functionality.

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

Signed-off-by: lukelee-sl <luke.lee@swirldslabs.com>
Signed-off-by: lukelee-sl <luke.lee@swirldslabs.com>
@lukelee-sl lukelee-sl requested a review from a team as a code owner December 6, 2023 19:29
Copy link

github-actions bot commented Dec 6, 2023

Node: Unit Test Results

    2 293 files  ±0      2 293 suites  ±0   45m 36s ⏱️ - 2m 19s
118 431 tests ±0  118 397 ✔️ ±0  34 💤 ±0  0 ±0 
126 853 runs  ±0  126 819 ✔️ ±0  34 💤 ±0  0 ±0 

Results for commit 06e5ab1. ± Comparison against base commit bac40bd.

♻️ This comment has been updated with latest results.

Copy link

codecov bot commented Dec 6, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (bac40bd) 63.51% compared to head (06e5ab1) 63.51%.

Additional details and impacted files
@@              Coverage Diff              @@
##             develop   #10337      +/-   ##
=============================================
- Coverage      63.51%   63.51%   -0.01%     
+ Complexity     30992    30988       -4     
=============================================
  Files           3340     3340              
  Lines         134557   134576      +19     
  Branches       13994    13994              
=============================================
+ Hits           85470    85481      +11     
- Misses         45727    45731       +4     
- Partials        3360     3364       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

github-actions bot commented Dec 6, 2023

Node: HAPI Test (Crypto) Results

211 tests  ±0   201 ✔️ ±0   20m 53s ⏱️ + 1m 49s
  22 suites ±0     10 💤 ±0 
  22 files   ±0       0 ±0 

Results for commit 06e5ab1. ± Comparison against base commit bac40bd.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented Dec 6, 2023

Node: HAPI Test (Token) Results

190 tests  ±0   188 ✔️ ±0   19m 22s ⏱️ +22s
  13 suites ±0       2 💤 ±0 
  13 files   ±0       0 ±0 

Results for commit 06e5ab1. ± Comparison against base commit bac40bd.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented Dec 6, 2023

Node: E2E Test Results

    1 files  ±    0      1 suites  ±0   23m 32s ⏱️ + 23m 32s
311 tests +310  311 ✔️ +311  0 💤 ±0  0  - 1 
333 runs  +332  333 ✔️ +333  0 💤 ±0  0  - 1 

Results for commit 06e5ab1. ± Comparison against base commit bac40bd.

This pull request removes 1 and adds 311 tests. Note that renamed tests count towards both.
EndToEndTests ‑ initializationError
EndToEndTests ‑ ADDRESS_BOOK_CONTROLCanUpdateADDRESS_BOOK
EndToEndTests ‑ ADDRESS_BOOK_CONTROLCanUpdateNODE_DETAILS
EndToEndTests ‑ AccountsGetPayerRecordsIfSoConfigured
EndToEndTests ‑ Acct57CanMakeSmallChanges
EndToEndTests ‑ Acct57CantMakeLargeChanges
EndToEndTests ‑ AddingSignaturesToExecutedTxFails
EndToEndTests ‑ AddingSignaturesToExecutedTxFailsWithLongTermEnabled
EndToEndTests ‑ AddingSignaturesToNonExistingTxFails
EndToEndTests ‑ AddingSignaturesToNonExistingTxFailsWithLongTermEnabled
EndToEndTests ‑ AddressAliasIdFuzzing
…

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented Dec 6, 2023

Node: HAPI Test (Misc) Results

419 tests  ±0   316 ✔️ ±0   25m 34s ⏱️ -57s
  73 suites ±0   103 💤 ±0 
  73 files   ±0       0 ±0 

Results for commit 06e5ab1. ± Comparison against base commit bac40bd.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented Dec 6, 2023

Node: Integration Test Results

279 tests  ±0   279 ✔️ ±0   28m 2s ⏱️ -19s
    5 suites ±0       0 💤 ±0 
    5 files   ±0       0 ±0 

Results for commit 06e5ab1. ± Comparison against base commit bac40bd.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented Dec 6, 2023

Node: HAPI Test (Smart Contract) Results

396 tests  ±0   349 ✔️ ±0   51m 0s ⏱️ + 4m 26s
  55 suites ±0     47 💤 ±0 
  55 files   ±0       0 ±0 

Results for commit 06e5ab1. ± Comparison against base commit bac40bd.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented Dec 6, 2023

Node: HAPI Test (Time Consuming) Results

21 tests  ±0     9 ✔️ ±0   26m 25s ⏱️ -7s
  2 suites ±0   12 💤 ±0 
  2 files   ±0     0 ±0 

Results for commit 06e5ab1. ± Comparison against base commit bac40bd.

♻️ This comment has been updated with latest results.

david-bakin-sl
david-bakin-sl previously approved these changes Dec 6, 2023
Copy link
Member

@david-bakin-sl david-bakin-sl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - with one minor comment.

Signed-off-by: lukelee-sl <luke.lee@swirldslabs.com>
Copy link
Collaborator

@tinker-michaelj tinker-michaelj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All looks right to me, tyvm @lukelee-sl !

@lukelee-sl lukelee-sl merged commit f070221 into develop Dec 7, 2023
26 of 27 checks passed
@lukelee-sl lukelee-sl deleted the 10336-implement-lazyCreationCostInGas branch December 7, 2023 01:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement lazyCreationCostInGas method
3 participants