Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: change glibc malloc behavior to help reduce memory consumption #10359

Merged
merged 2 commits into from Dec 7, 2023

Conversation

nathanklick
Copy link
Member

Description

This pull request changes the following:

  • Adds the MALLOC_ARENA_MAX=4 environment variable to the docker container definitions.
  • Cleans up several apt-get commands to support better layer reusability and determinism.

Related Issues

Signed-off-by: Nathan Klick <nathan@swirldslabs.com>
Signed-off-by: Nathan Klick <nathan@swirldslabs.com>
Copy link
Contributor

@iwsimon iwsimon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

@mattp-swirldslabs mattp-swirldslabs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

Copy link

github-actions bot commented Dec 7, 2023

Node: HAPI Test (Crypto) Results

211 tests   201 ✔️  19m 25s ⏱️
  22 suites    10 💤
  22 files        0

Results for commit 310b7ab.

Copy link

github-actions bot commented Dec 7, 2023

Node: HAPI Test (Token) Results

190 tests   188 ✔️  19m 38s ⏱️
  13 suites      2 💤
  13 files        0

Results for commit 310b7ab.

Copy link

github-actions bot commented Dec 7, 2023

Node: HAPI Test (Misc) Results

419 tests   316 ✔️  23m 49s ⏱️
  73 suites  103 💤
  73 files        0

Results for commit 310b7ab.

Copy link

github-actions bot commented Dec 7, 2023

Node: HAPI Test (Time Consuming) Results

21 tests     9 ✔️  26m 1s ⏱️
  2 suites  12 💤
  2 files      0

Results for commit 310b7ab.

Copy link

github-actions bot commented Dec 7, 2023

Node: E2E Test Results

    1 files      1 suites   24m 41s ⏱️
311 tests 311 ✔️ 0 💤 0
333 runs  333 ✔️ 0 💤 0

Results for commit 310b7ab.

Copy link

github-actions bot commented Dec 7, 2023

Node: Integration Test Results

279 tests   279 ✔️  28m 48s ⏱️
    5 suites      0 💤
    5 files        0

Results for commit 310b7ab.

Copy link
Member

@Neeharika-Sompalli Neeharika-Sompalli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !

Copy link

github-actions bot commented Dec 7, 2023

Node: Unit Test Results

    2 293 files  ±0      2 293 suites  ±0   50m 9s ⏱️ + 1m 6s
118 430 tests  - 1  118 396 ✔️  - 1  34 💤 ±0  0 ±0 
126 852 runs   - 1  126 818 ✔️  - 1  34 💤 ±0  0 ±0 

Results for commit 310b7ab. ± Comparison against base commit ca4fbea.

Copy link

github-actions bot commented Dec 7, 2023

Node: HAPI Test (Smart Contract) Results

396 tests   350 ✔️  46m 40s ⏱️
  55 suites    46 💤
  55 files        0

Results for commit 310b7ab.

@nathanklick nathanklick merged commit d2f59e4 into develop Dec 7, 2023
25 checks passed
@nathanklick nathanklick deleted the 10028-Fix-Malloc-Issue branch December 7, 2023 22:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Node OOM killed during performance testing
6 participants