Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: suite tests in ERC721ContractInteractions #10377

Merged

Conversation

dikel
Copy link
Contributor

@dikel dikel commented Dec 8, 2023

Description:
This PR fixes the callsERC721ContractInteractions suite test in ERC721ContractInteractions

Related issue(s):

Fixes #10274
Fixes #10371

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

dikel and others added 4 commits December 6, 2023 17:02
Signed-off-by: dikel <dikelito@tutamail.com>
Signed-off-by: Michael Tinker <michael.tinker@swirldslabs.com>
…ontract-interactions-suite' into 10274-fix-erc-721-contract-interactions-suite
@dikel dikel added Limechain Work planned for the LimeChain team Modularization Issues or PRs related to modularization labels Dec 8, 2023
@dikel dikel self-assigned this Dec 8, 2023
@dikel dikel requested review from a team as code owners December 8, 2023 07:33
@dikel dikel requested a review from povolev15 December 8, 2023 07:34
Copy link

github-actions bot commented Dec 8, 2023

Node: HAPI Test (Crypto) Results

211 tests  ±0   201 ✔️ ±0   18m 31s ⏱️ + 1m 29s
  22 suites ±0     10 💤 ±0 
  22 files   ±0       0 ±0 

Results for commit 6729343. ± Comparison against base commit d2f59e4.

Copy link

github-actions bot commented Dec 8, 2023

Node: Unit Test Results

    2 294 files  ±0      2 294 suites  ±0   47m 51s ⏱️ + 1m 13s
118 434 tests +1  118 400 ✔️ +1  34 💤 ±0  0 ±0 
126 856 runs  +1  126 822 ✔️ +1  34 💤 ±0  0 ±0 

Results for commit 6729343. ± Comparison against base commit d2f59e4.

Copy link

codecov bot commented Dec 8, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (1d6aedd) 63.52% compared to head (6729343) 63.52%.
Report is 11 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##             develop   #10377    +/-   ##
===========================================
  Coverage      63.52%   63.52%            
- Complexity     30990    31011    +21     
===========================================
  Files           3341     3342     +1     
  Lines         134577   134701   +124     
  Branches       13994    14006    +12     
===========================================
+ Hits           85484    85568    +84     
- Misses         45736    45774    +38     
- Partials        3357     3359     +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

github-actions bot commented Dec 8, 2023

Node: HAPI Test (Token) Results

189 tests  ±0   189 ✔️ ±0   22m 7s ⏱️ + 3m 43s
  13 suites ±0       0 💤 ±0 
  13 files   ±0       0 ±0 

Results for commit 6729343. ± Comparison against base commit d2f59e4.

Copy link

github-actions bot commented Dec 8, 2023

Node: E2E Test Results

    1 files  ±    0      1 suites  ±0   22m 25s ⏱️ + 22m 25s
311 tests +310  311 ✔️ +311  0 💤 ±0  0  - 1 
333 runs  +332  333 ✔️ +333  0 💤 ±0  0  - 1 

Results for commit 6729343. ± Comparison against base commit d2f59e4.

This pull request removes 1 and adds 311 tests. Note that renamed tests count towards both.
EndToEndTests ‑ initializationError
EndToEndTests ‑ ADDRESS_BOOK_CONTROLCanUpdateADDRESS_BOOK
EndToEndTests ‑ ADDRESS_BOOK_CONTROLCanUpdateNODE_DETAILS
EndToEndTests ‑ AccountsGetPayerRecordsIfSoConfigured
EndToEndTests ‑ Acct57CanMakeSmallChanges
EndToEndTests ‑ Acct57CantMakeLargeChanges
EndToEndTests ‑ AddingSignaturesToExecutedTxFails
EndToEndTests ‑ AddingSignaturesToExecutedTxFailsWithLongTermEnabled
EndToEndTests ‑ AddingSignaturesToNonExistingTxFails
EndToEndTests ‑ AddingSignaturesToNonExistingTxFailsWithLongTermEnabled
EndToEndTests ‑ AddressAliasIdFuzzing
…

Copy link

github-actions bot commented Dec 8, 2023

Node: HAPI Test (Time Consuming) Results

21 tests  ±0     9 ✔️ ±0   26m 29s ⏱️ +38s
  2 suites ±0   12 💤 ±0 
  2 files   ±0     0 ±0 

Results for commit 6729343. ± Comparison against base commit d2f59e4.

Copy link

github-actions bot commented Dec 8, 2023

Node: HAPI Test (Misc) Results

419 tests  ±0   316 ✔️ ±0   27m 6s ⏱️ + 1m 21s
  73 suites ±0   103 💤 ±0 
  73 files   ±0       0 ±0 

Results for commit 6729343. ± Comparison against base commit d2f59e4.

Copy link

github-actions bot commented Dec 8, 2023

Node: Integration Test Results

279 tests  ±0   279 ✔️ ±0   28m 18s ⏱️ +8s
    5 suites ±0       0 💤 ±0 
    5 files   ±0       0 ±0 

Results for commit 6729343. ± Comparison against base commit d2f59e4.

Copy link
Contributor

@agadzhalov agadzhalov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

github-actions bot commented Dec 8, 2023

Node: HAPI Test (Smart Contract) Results

396 tests  ±0   351 ✔️ +1   50m 50s ⏱️ + 3m 12s
  55 suites ±0     45 💤  - 1 
  55 files   ±0       0 ±0 

Results for commit 6729343. ± Comparison against base commit d2f59e4.

Copy link
Collaborator

@mustafauzunn mustafauzunn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@tinker-michaelj tinker-michaelj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@tinker-michaelj tinker-michaelj merged commit 575da81 into develop Dec 8, 2023
34 checks passed
@tinker-michaelj tinker-michaelj deleted the 10274-fix-erc-721-contract-interactions-suite branch December 8, 2023 16:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Limechain Work planned for the LimeChain team Modularization Issues or PRs related to modularization
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ERC721ContractInteractions.callsERC721ContractInteractions() Fix ERC721ContractInteractions suite tests
5 participants