fix: clear "side-effect fields" after switch a child record from SUCCESS to REVERTED_SUCCESS #10385
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@tinker-michaelj can you please take a look? |
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## develop #10385 +/- ##
=============================================
+ Coverage 63.02% 63.03% +0.01%
- Complexity 30803 30813 +10
=============================================
Files 3359 3361 +2
Lines 135279 135392 +113
Branches 14074 14086 +12
=============================================
+ Hits 85256 85347 +91
- Misses 46683 46690 +7
- Partials 3340 3355 +15 ☔ View full report in Codecov by Sentry. |
Node: HAPI Test (Misc) Results419 tests - 1 320 ✔️ ±0 27m 26s ⏱️ + 3m 23s Results for commit a4fd7a1. ± Comparison against base commit 6f00b68. This pull request removes 1 test.This pull request skips 1 and un-skips 1 tests.♻️ This comment has been updated with latest results. |
Node: E2E Test Results 1 files ± 0 1 suites ±0 23m 20s ⏱️ + 23m 20s Results for commit a4fd7a1. ± Comparison against base commit 6f00b68. This pull request removes 1 and adds 311 tests. Note that renamed tests count towards both.♻️ This comment has been updated with latest results. |
thenswan
added
Limechain
.../hedera-app/src/main/java/com/hedera/node/app/workflows/handle/record/RecordListBuilder.java
Outdated
Show resolved
Hide resolved
.../hedera-app/src/main/java/com/hedera/node/app/workflows/handle/record/RecordListBuilder.java
Outdated
Show resolved
Hide resolved
tinker-michaelj
requested changes
Dec 11, 2023
thenswan
requested review from
edward-swirldslabs,
mxtartaglia-sl,
anthony-swirldslabs,
kimbor and
acuarica
thenswan
force-pushed
the
10308-clear-side-effects-after-REVERTED_SUCCESS
branch
from
4ffac75
to
45e1092
Compare
…ESS to REVERTED_SUCCESS Signed-off-by: Nikita Lebedev <nikita.lebedev@limechain.tech>
thenswan
force-pushed
the
10308-clear-side-effects-after-REVERTED_SUCCESS
branch
from
45e1092
to
cc51672
Compare
…ESS to REVERTED_SUCCESS Signed-off-by: Nikita Lebedev <nikita.lebedev@limechain.tech>
Signed-off-by: Nikita Lebedev <nikita.lebedev@limechain.tech>
tinker-michaelj
approved these changes
Dec 14, 2023
tinker-michaelj
deleted the
10308-clear-side-effects-after-REVERTED_SUCCESS
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Clear "side-effect fields" after switch a child record from
SUCCESStoREVERTED_SUCCESS.Related issue(s):
Fixes #10308
Notes for reviewer:
At first, I followed this strategy to remove side-effect fields:
REVERTED_SUCCESSWhat did I check:
ContractMintHTSSuite.rollbackOnFailedMintAfterFungibleTransfer()— side-effect fields removed in prev PRContractDeleteSuite.cannotUseMoreThanChildContractLimit()— checked records and didn’t find any side-effect fields underREVERTED_SUCCESSLazyCreateThroughPrecompileSuite.erc20TransferLazyCreate()— checked and removedautomatic_token_associationsunderREVERTED_SUCCESSLazyCreateThroughPrecompileSuite.erc721TransferFromLazyCreate()— checked records and didn’t find any side-effect fields underREVERTED_SUCCESSLazyCreateThroughPrecompileSuite.erc20TransferFromLazyCreate()is still WIP and I can’t check itCreate2OperationSuite.canUseAliasesInPrecompilesAndContractKeys()is still WIP and I can’t check itOther side-effect fields were mentioned in the issue (ones I that didnt encounter while did relevant spec fuzzy matching, like: transferList, created ids in the transactionReceipt, etc.) I added anyway from from mono
TxnReceipt#Builder.revert()andExpirableTxnRecord#Builder.nullOutSideEffectFields().Checklist