Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: only enable TargetNetworkPrep suite #10410

Merged
merged 1 commit into from Dec 11, 2023

Conversation

petreze
Copy link
Contributor

@petreze petreze commented Dec 11, 2023

Description:
This PR only adds HapiTest annotation to TargetNetworkPrep suite

Related issue(s):

Fixes #8900

Notes for reviewer:

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

Signed-off-by: Petar Tonev <petar.tonev@limechain.tech>
@petreze petreze self-assigned this Dec 11, 2023
@petreze petreze requested review from a team as code owners December 11, 2023 08:27
@petreze petreze added Limechain Work planned for the LimeChain team Modularization Issues or PRs related to modularization labels Dec 11, 2023
Copy link
Contributor

@agadzhalov agadzhalov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

Node: Unit Test Results

    2 293 files  ±0      2 293 suites  ±0   49m 44s ⏱️ + 14m 9s
118 428 tests ±0  118 394 ✔️ ±0  34 💤 ±0  0 ±0 
126 849 runs  ±0  126 815 ✔️ ±0  34 💤 ±0  0 ±0 

Results for commit d8b969c. ± Comparison against base commit c84281d.

Copy link

codecov bot commented Dec 11, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (c84281d) 62.96% compared to head (d8b969c) 62.96%.

Additional details and impacted files
@@            Coverage Diff             @@
##             develop   #10410   +/-   ##
==========================================
  Coverage      62.96%   62.96%           
+ Complexity     30791    30790    -1     
==========================================
  Files           3356     3356           
  Lines         135216   135216           
  Branches       14076    14076           
==========================================
+ Hits           85140    85141    +1     
- Misses         46737    46740    +3     
+ Partials        3339     3335    -4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

Node: HAPI Test (Crypto) Results

211 tests  ±0   201 ✔️ ±0   20m 6s ⏱️ + 2m 34s
  22 suites ±0     10 💤 ±0 
  22 files   ±0       0 ±0 

Results for commit d8b969c. ± Comparison against base commit c84281d.

Copy link

Node: HAPI Test (Token) Results

189 tests  ±0   189 ✔️ ±0   22m 9s ⏱️ + 4m 27s
  13 suites ±0       0 💤 ±0 
  13 files   ±0       0 ±0 

Results for commit d8b969c. ± Comparison against base commit c84281d.

Copy link

Node: E2E Test Results

    1 files  ±    0      1 suites  ±0   23m 29s ⏱️ + 23m 29s
311 tests +310  311 ✔️ +311  0 💤 ±0  0  - 1 
333 runs  +332  333 ✔️ +333  0 💤 ±0  0  - 1 

Results for commit d8b969c. ± Comparison against base commit c84281d.

This pull request removes 1 and adds 311 tests. Note that renamed tests count towards both.
EndToEndTests ‑ initializationError
EndToEndTests ‑ ADDRESS_BOOK_CONTROLCanUpdateADDRESS_BOOK
EndToEndTests ‑ ADDRESS_BOOK_CONTROLCanUpdateNODE_DETAILS
EndToEndTests ‑ AccountsGetPayerRecordsIfSoConfigured
EndToEndTests ‑ Acct57CanMakeSmallChanges
EndToEndTests ‑ Acct57CantMakeLargeChanges
EndToEndTests ‑ AddingSignaturesToExecutedTxFails
EndToEndTests ‑ AddingSignaturesToExecutedTxFailsWithLongTermEnabled
EndToEndTests ‑ AddingSignaturesToNonExistingTxFails
EndToEndTests ‑ AddingSignaturesToNonExistingTxFailsWithLongTermEnabled
EndToEndTests ‑ AddressAliasIdFuzzing
…

Copy link

Node: HAPI Test (Time Consuming) Results

21 tests  ±0     9 ✔️ ±0   24m 41s ⏱️ -46s
  2 suites ±0   12 💤 ±0 
  2 files   ±0     0 ±0 

Results for commit d8b969c. ± Comparison against base commit c84281d.

Copy link

Node: HAPI Test (Misc) Results

420 tests  ±0   319 ✔️ +1   27m 5s ⏱️ + 3m 14s
  74 suites ±0   101 💤  - 1 
  74 files   ±0       0 ±0 

Results for commit d8b969c. ± Comparison against base commit c84281d.

Copy link

Node: HAPI Test (Smart Contract) Results

397 tests  ±0   356 ✔️ ±0   49m 33s ⏱️ + 4m 30s
  55 suites ±0     41 💤 ±0 
  55 files   ±0       0 ±0 

Results for commit d8b969c. ± Comparison against base commit c84281d.

@petreze petreze changed the title fix: enable TargetNetworkPrep suite fix: only enable TargetNetworkPrep suite Dec 11, 2023
Copy link
Contributor

@stoyanov-st stoyanov-st left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

Node: Integration Test Results

279 tests  ±0   279 ✔️ ±0   27m 57s ⏱️ -20s
    5 suites ±0       0 💤 ±0 
    5 files   ±0       0 ±0 

Results for commit d8b969c. ± Comparison against base commit c84281d.

@petreze petreze merged commit ff96c7f into develop Dec 11, 2023
35 checks passed
@petreze petreze deleted the 8900-target-network-prep-suite branch December 11, 2023 15:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Limechain Work planned for the LimeChain team Modularization Issues or PRs related to modularization
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TargetNetworkPrep
5 participants