feat: design roster interfaces #10428
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
edward-swirldslabs
requested review from
lpetrovic05,
cody-littley,
poulok and
alittley
edward-swirldslabs
requested review from
anthony-swirldslabs,
mxtartaglia-sl and
OlegMazurov
edward-swirldslabs
changed the base branch from
develop
to
09577-DAB-Documentation
edward-swirldslabs
requested review from
a team and
tinker-michaelj
as code owners
edward-swirldslabs
requested review from
JeffreyDallas,
jeromy-cannon,
povolev15 and
quiet-node
edward-swirldslabs
changed the base branch from
09577-DAB-Documentation
to
develop
edward-swirldslabs
dismissed stale reviews from jeromy-cannon and alittley
via
03edb12
alittley
previously approved these changes
Dec 13, 2023
jeromy-cannon
previously approved these changes
Dec 13, 2023
cody-littley
previously approved these changes
Dec 14, 2023
Signed-off-by: Edward Wertz <edward@swirldslabs.com>
edward-swirldslabs
dismissed stale reviews from cody-littley, jeromy-cannon, and alittley
via
e968967
edward-swirldslabs
changed the title
edward-swirldslabs
requested review from
alittley,
cody-littley and
jeromy-cannon
Signed-off-by: Edward Wertz <edward@swirldslabs.com>
alittley
previously approved these changes
Dec 18, 2023
...wirlds-platform-core/src/main/java/com/swirlds/platform/roster/legacy/AddressBookRoster.java
Outdated
Show resolved
Hide resolved
...wirlds-platform-core/src/main/java/com/swirlds/platform/roster/legacy/AddressBookRoster.java
Outdated
Show resolved
Hide resolved
...wirlds-platform-core/src/main/java/com/swirlds/platform/roster/legacy/AddressBookRoster.java
Show resolved
Hide resolved
...wirlds-platform-core/src/main/java/com/swirlds/platform/roster/legacy/AddressBookRoster.java
Outdated
Show resolved
Hide resolved
...wirlds-platform-core/src/main/java/com/swirlds/platform/roster/legacy/AddressBookRoster.java
Outdated
Show resolved
Hide resolved
...wirlds-platform-core/src/main/java/com/swirlds/platform/roster/legacy/AddressBookRoster.java
Outdated
Show resolved
Hide resolved
...wirlds-platform-core/src/main/java/com/swirlds/platform/roster/legacy/AddressBookRoster.java
Outdated
Show resolved
Hide resolved
...irlds-platform-core/src/main/java/com/swirlds/platform/roster/legacy/AddressRosterEntry.java
Outdated
Show resolved
Hide resolved
...irlds-platform-core/src/main/java/com/swirlds/platform/roster/legacy/AddressRosterEntry.java
Outdated
Show resolved
Hide resolved
...irlds-platform-core/src/main/java/com/swirlds/platform/roster/legacy/AddressRosterEntry.java
Outdated
Show resolved
Hide resolved
...wirlds-platform-core/src/main/java/com/swirlds/platform/roster/legacy/AddressBookRoster.java
Outdated
Show resolved
Hide resolved
...wirlds-platform-core/src/main/java/com/swirlds/platform/roster/legacy/AddressBookRoster.java
Outdated
Show resolved
Hide resolved
...wirlds-platform-core/src/main/java/com/swirlds/platform/roster/legacy/AddressBookRoster.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Edward Wertz <edward@swirldslabs.com>
alittley
approved these changes
Dec 19, 2023
lpetrovic05
approved these changes
Dec 20, 2023
cody-littley
approved these changes
Dec 20, 2023
edward-swirldslabs
deleted the
10421-design-Roster-and-MutableRoster-interfaces
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #10421
Fixes #10494