Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: merge the dual state into the platform state #10429

Merged
merged 20 commits into from Dec 28, 2023

Conversation

cody-littley
Copy link
Contributor

Closes #10414

Signed-off-by: Cody Littley <cody@swirldslabs.com>
@cody-littley cody-littley self-assigned this Dec 11, 2023
@cody-littley cody-littley changed the title Merge the dual state into the platform state. chore: merge the dual state into the platform state Dec 11, 2023
Copy link

github-actions bot commented Dec 11, 2023

Node: HAPI Test (Crypto) Results

210 tests  ±0   208 ✔️ ±0   16m 12s ⏱️ - 1m 23s
  22 suites ±0       2 💤 ±0 
  22 files   ±0       0 ±0 

Results for commit 18cb760. ± Comparison against base commit 85d1006.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented Dec 11, 2023

Node: HAPI Test (Token) Results

189 tests  ±0   189 ✔️ ±0   17m 13s ⏱️ -6s
  13 suites ±0       0 💤 ±0 
  13 files   ±0       0 ±0 

Results for commit 18cb760. ± Comparison against base commit 85d1006.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented Dec 11, 2023

Node: Unit Test Results

    2 291 files  ±0      2 291 suites  ±0   53m 50s ⏱️ + 5m 10s
118 627 tests +9  118 592 ✔️ +9  35 💤 ±0  0 ±0 
127 044 runs  +9  127 009 ✔️ +9  35 💤 ±0  0 ±0 

Results for commit 18cb760. ± Comparison against base commit 85d1006.

♻️ This comment has been updated with latest results.

Copy link

codecov bot commented Dec 11, 2023

Codecov Report

Attention: 150 lines in your changes are missing coverage. Please review.

Comparison is base (85d1006) 62.82% compared to head (18cb760) 62.79%.
Report is 4 commits behind head on develop.

Files Patch % Lines
...rc/main/java/com/swirlds/platform/state/State.java 31.70% 27 Missing and 1 partial ⚠️
...java/com/swirlds/platform/state/PlatformState.java 73.00% 23 Missing and 4 partials ⚠️
...om/swirlds/platform/state/LegacyPlatformState.java 9.52% 19 Missing ⚠️
...irlds/platform/recovery/EventRecoveryWorkflow.java 5.88% 16 Missing ⚠️
.../platform/eventhandling/ConsensusRoundHandler.java 0.00% 14 Missing ⚠️
...om/swirlds/platform/state/GenesisStateBuilder.java 0.00% 8 Missing ⚠️
...ain/java/com/swirlds/platform/SwirldsPlatform.java 0.00% 6 Missing ⚠️
...wirlds/demo/platform/PlatformTestingToolState.java 0.00% 5 Missing ⚠️
...com/swirlds/platform/state/SwirldStateManager.java 37.50% 5 Missing ⚠️
...com/swirlds/platform/state/signed/SignedState.java 28.57% 5 Missing ⚠️
... and 11 more
Additional details and impacted files
@@              Coverage Diff              @@
##             develop   #10429      +/-   ##
=============================================
- Coverage      62.82%   62.79%   -0.03%     
+ Complexity     30903    30890      -13     
=============================================
  Files           3376     3379       +3     
  Lines         136425   136498      +73     
  Branches       14220    14219       -1     
=============================================
+ Hits           85710    85719       +9     
- Misses         47311    47389      +78     
+ Partials        3404     3390      -14     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

github-actions bot commented Dec 11, 2023

Node: HAPI Test (Time Consuming) Results

21 tests  ±0     9 ✔️ ±0   25m 6s ⏱️ +18s
  2 suites ±0   12 💤 ±0 
  2 files   ±0     0 ±0 

Results for commit 18cb760. ± Comparison against base commit 85d1006.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented Dec 11, 2023

Node: Integration Test Results

280 tests  ±0   280 ✔️ ±0   28m 47s ⏱️ +11s
    5 suites ±0       0 💤 ±0 
    5 files   ±0       0 ±0 

Results for commit 18cb760. ± Comparison against base commit 85d1006.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented Dec 11, 2023

Node: HAPI Test (Smart Contract) Results

411 tests  ±0   402 ✔️ +1   48m 59s ⏱️ - 2m 24s
  55 suites ±0       9 💤  - 1 
  55 files   ±0       0 ±0 

Results for commit 18cb760. ± Comparison against base commit 85d1006.

♻️ This comment has been updated with latest results.

Signed-off-by: Cody Littley <cody@swirldslabs.com>
Signed-off-by: Cody Littley <cody@swirldslabs.com>
Copy link

github-actions bot commented Dec 12, 2023

Node: HAPI Test (Misc) Results

421 tests  ±0   355 ✔️ +3   28m 25s ⏱️ +44s
  73 suites ±0     66 💤  - 3 
  73 files   ±0       0 ±0 

Results for commit 18cb760. ± Comparison against base commit 85d1006.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented Dec 12, 2023

Node: E2E Test Results

    1 files  ±    0      1 suites  ±0   21m 46s ⏱️ + 21m 46s
311 tests +310  311 ✔️ +311  0 💤 ±0  0  - 1 
333 runs  +332  333 ✔️ +333  0 💤 ±0  0  - 1 

Results for commit 18cb760. ± Comparison against base commit 85d1006.

This pull request removes 1 and adds 311 tests. Note that renamed tests count towards both.
EndToEndTests ‑ initializationError
EndToEndTests ‑ ADDRESS_BOOK_CONTROLCanUpdateADDRESS_BOOK
EndToEndTests ‑ ADDRESS_BOOK_CONTROLCanUpdateNODE_DETAILS
EndToEndTests ‑ AccountsGetPayerRecordsIfSoConfigured
EndToEndTests ‑ Acct57CanMakeSmallChanges
EndToEndTests ‑ Acct57CantMakeLargeChanges
EndToEndTests ‑ AddingSignaturesToExecutedTxFails
EndToEndTests ‑ AddingSignaturesToExecutedTxFailsWithLongTermEnabled
EndToEndTests ‑ AddingSignaturesToNonExistingTxFails
EndToEndTests ‑ AddingSignaturesToNonExistingTxFailsWithLongTermEnabled
EndToEndTests ‑ AddressAliasIdFuzzing
…

♻️ This comment has been updated with latest results.

Signed-off-by: Cody Littley <cody@swirldslabs.com>
Signed-off-by: Cody Littley <cody@swirldslabs.com>
Signed-off-by: Cody Littley <cody@swirldslabs.com>
Signed-off-by: Cody Littley <cody@swirldslabs.com>
Signed-off-by: Cody Littley <cody@swirldslabs.com>
Signed-off-by: Cody Littley <cody@swirldslabs.com>
Signed-off-by: Cody Littley <cody@swirldslabs.com>
Signed-off-by: Cody Littley <cody@swirldslabs.com>
Signed-off-by: Cody Littley <cody@swirldslabs.com>
Signed-off-by: Cody Littley <cody@swirldslabs.com>
Signed-off-by: Cody Littley <cody@swirldslabs.com>
Signed-off-by: Cody Littley <cody@swirldslabs.com>
Signed-off-by: Cody Littley <cody@swirldslabs.com>
Signed-off-by: Cody Littley <cody@swirldslabs.com>
Signed-off-by: Cody Littley <cody@swirldslabs.com>
Signed-off-by: Cody Littley <cody@swirldslabs.com>
Signed-off-by: Cody Littley <cody@swirldslabs.com>
Copy link
Collaborator

@tinker-michaelj tinker-michaelj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for Services changes, thx @cody-littley !

@cody-littley cody-littley merged commit 78b1fe3 into develop Dec 28, 2023
36 of 37 checks passed
@cody-littley cody-littley deleted the 10414-remove-dual-state branch December 28, 2023 15:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Merge Platform State and Dual State
4 participants