chore: Remove throw arg null #10433

mxtartaglia-sl · 2023-12-11T22:42:44Z

Description:
Removing usage of methods throwArgNull and throwArgBlank from the commons module

Related issue(s):

Fixes # #6704

Notes for reviewer:
Given the limited amount of files, we extended the removal to the whole project

mxtartaglia-sl · 2023-12-12T01:53:12Z

pushed the merge conflict solution but after, build is failing locally

> Task :app:compileJmhJava FAILED

It only happened after rebasing develop into this branch.
It seems something changed with the jmh module and is triggered when modifying CountPerSecond.java

Figured it out, I needed to add the base module as dependency for fcqueue and remove the module from build.gradle.kts

github-actions · 2023-12-12T02:16:10Z

Node: Unit Test Results

    2 293 files ±0     2 293 suites ±0 50m 1s ⏱️ - 3m 35s
118 448 tests ±0 118 414 ✔️ ±0 34 💤 ±0 0 ❌ ±0
126 865 runs ±0 126 831 ✔️ ±0 34 💤 ±0 0 ❌ ±0

Results for commit c2eaf34. ± Comparison against base commit 628226f.

♻️ This comment has been updated with latest results.

github-actions · 2023-12-12T02:16:57Z

Node: HAPI Test (Crypto) Results

211 tests 204 ✔️ 18m 1s ⏱️
  22 suites     7 💤
  22 files     0 ❌

Results for commit c2eaf34.

♻️ This comment has been updated with latest results.

codecov · 2023-12-12T02:17:29Z

Codecov Report

All modified and coverable lines are covered by tests ✅

❗ No coverage uploaded for pull request base (develop@628226f). Click here to learn what that means.

❗ Current head 5d74c25 differs from pull request most recent head c2eaf34. Consider uploading reports for the commit c2eaf34 to get more accurate results

Additional details and impacted files

@@            Coverage Diff             @@
##             develop   #10433   +/-   ##
==========================================
  Coverage           ?   63.00%           
  Complexity         ?    30816           
==========================================
  Files              ?     3363           
  Lines              ?   135403           
  Branches           ?    14088           
==========================================
  Hits               ?    85304           
  Misses             ?    46739           
  Partials           ?     3360

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

github-actions · 2023-12-12T02:19:12Z

Node: HAPI Test (Token) Results

189 tests 189 ✔️ 17m 45s ⏱️
  13 suites     0 💤
  13 files     0 ❌

Results for commit c2eaf34.

♻️ This comment has been updated with latest results.

github-actions · 2023-12-12T02:22:39Z

Node: HAPI Test (Misc) Results

420 tests 330 ✔️ 28m 45s ⏱️
  74 suites   90 💤
  74 files     0 ❌

Results for commit c2eaf34.

♻️ This comment has been updated with latest results.

github-actions · 2023-12-12T02:23:22Z

Node: E2E Test Results

    1 files     1 suites 22m 38s ⏱️
311 tests 311 ✔️ 0 💤 0 ❌
333 runs 333 ✔️ 0 💤 0 ❌

Results for commit c2eaf34.

♻️ This comment has been updated with latest results.

github-actions · 2023-12-12T02:24:37Z

Node: HAPI Test (Time Consuming) Results

21 tests   9 ✔️ 24m 45s ⏱️
  2 suites 12 💤
  2 files   0 ❌

Results for commit c2eaf34.

♻️ This comment has been updated with latest results.

github-actions · 2023-12-12T02:28:51Z

Node: Integration Test Results

278 tests ±0 278 ✔️ ±0 26m 50s ⏱️ -2s
    5 suites ±0     0 💤 ±0
    5 files ±0     0 ❌ ±0

Results for commit c2eaf34. ± Comparison against base commit 628226f.

♻️ This comment has been updated with latest results.

github-actions · 2023-12-12T02:46:41Z

Node: HAPI Test (Smart Contract) Results

398 tests 368 ✔️ 45m 20s ⏱️
  55 suites   30 💤
  55 files     0 ❌

Results for commit c2eaf34.

♻️ This comment has been updated with latest results.

jsync-swirlds

Some possible minor improvements or nitpick items, but the functional changes are good.

platform-sdk/swirlds-jasperdb/src/main/java/com/swirlds/merkledb/MerkleDbStatistics.java

...orm-sdk/swirlds-common/src/main/java/com/swirlds/common/metrics/platform/DefaultMetrics.java

...form-sdk/swirlds-common/src/main/java/com/swirlds/common/metrics/platform/SnapshotEvent.java

...-core/src/main/java/com/swirlds/platform/recovery/internal/MultiFileRunningHashIterator.java

Signed-off-by: Maxi Tartaglia <maxi@swirldslabs.com>

… string hardcoded message instead Signed-off-by: Maxi Tartaglia <maxi@swirldslabs.com>

Signed-off-by: Maxi Tartaglia <maxi@swirldslabs.com>

Signed-off-by: Maxi Tartaglia <maxi@swirldslabs.com> Signed-off-by: Maxi Tartaglia <maxi@swirldslabs.com>

…to one Signed-off-by: Maxi Tartaglia <maxi@swirldslabs.com> Signed-off-by: Maxi Tartaglia <maxi@swirldslabs.com>

Signed-off-by: Maxi Tartaglia <maxi@swirldslabs.com> Signed-off-by: Maxi Tartaglia <maxi@swirldslabs.com>

mxtartaglia-sl added this to the v0.46 milestone Dec 11, 2023

mxtartaglia-sl self-assigned this Dec 11, 2023

mxtartaglia-sl requested review from a team as code owners December 11, 2023 22:42

mxtartaglia-sl requested review from anthony-swirldslabs, OlegMazurov, poulok and timo0 December 11, 2023 22:42

mxtartaglia-sl changed the title ~~chore!: Remove throw arg null~~ chore: Remove throw arg null Dec 12, 2023

mxtartaglia-sl force-pushed the 6704_remove_throwArgNull branch from f8ab674 to 635b00d Compare December 12, 2023 01:53

mxtartaglia-sl linked an issue Dec 12, 2023 that may be closed by this pull request

Remove throwArgNull in metrics package #6704

Closed

mxtartaglia-sl requested review from a team as code owners December 12, 2023 02:47

mxtartaglia-sl requested review from tomzhenghedera and jeromy-cannon December 12, 2023 02:47

mxtartaglia-sl force-pushed the 6704_remove_throwArgNull branch from 000853a to f240cf2 Compare December 12, 2023 11:48

nathanklick force-pushed the develop branch from d971a0f to 6353aeb Compare December 12, 2023 14:05

mxtartaglia-sl requested a review from a team as a code owner December 12, 2023 14:05

mxtartaglia-sl force-pushed the 6704_remove_throwArgNull branch from c5b8935 to 5d74c25 Compare December 15, 2023 15:07

hendrikebbers previously approved these changes Dec 18, 2023

View reviewed changes

jsync-swirlds previously approved these changes Dec 18, 2023

View reviewed changes

mxtartaglia-sl added 14 commits December 18, 2023 14:38

change uses of throwArgNull for Objects.requireNonNull

360d216

Signed-off-by: Maxi Tartaglia <maxi@swirldslabs.com>

use ERROR_ARGUMENT_NULL constant instead of literal string

719d3dc

Signed-off-by: Maxi Tartaglia <maxi@swirldslabs.com>

remove deprecated method

39613bc

Signed-off-by: Maxi Tartaglia <maxi@swirldslabs.com>

replace CommonUtils#throwArgBlank usages for ArgumentUtils#throwArgBlank

739f7ec

Signed-off-by: Maxi Tartaglia <maxi@swirldslabs.com>

remove deprecated method CommonUtils#throwArgBlank

39946f1

Signed-off-by: Maxi Tartaglia <maxi@swirldslabs.com>

add base package to swirlds-fcqueue

69c5aaf

Signed-off-by: Maxi Tartaglia <maxi@swirldslabs.com>

add base package to swirlds-fcqueue not as transitive

242858f

Signed-off-by: Maxi Tartaglia <maxi@swirldslabs.com>

remove base module from build.gradle.kts

ace9f65

Signed-off-by: Maxi Tartaglia <maxi@swirldslabs.com>

in order to reduce the performance impact, change string#format for a…

70c384e

… string hardcoded message instead Signed-off-by: Maxi Tartaglia <maxi@swirldslabs.com>

Revert module changes to swirlds-fcqueue

24bb06d

Signed-off-by: Maxi Tartaglia <maxi@swirldslabs.com>

rolling back unrelated change

c080d2a

Signed-off-by: Maxi Tartaglia <maxi@swirldslabs.com> Signed-off-by: Maxi Tartaglia <maxi@swirldslabs.com>

javadocs with multiple @throws NullPointerException lines combined in…

e147916

…to one Signed-off-by: Maxi Tartaglia <maxi@swirldslabs.com> Signed-off-by: Maxi Tartaglia <maxi@swirldslabs.com>

fixing parameter name from comment

939f7bf

Signed-off-by: Maxi Tartaglia <maxi@swirldslabs.com> Signed-off-by: Maxi Tartaglia <maxi@swirldslabs.com>

Combining assignation and requireNonNull in single statement

c2eaf34

Signed-off-by: Maxi Tartaglia <maxi@swirldslabs.com> Signed-off-by: Maxi Tartaglia <maxi@swirldslabs.com>

mxtartaglia-sl dismissed stale reviews from jsync-swirlds and hendrikebbers via c2eaf34 December 18, 2023 17:39

mxtartaglia-sl force-pushed the 6704_remove_throwArgNull branch from 5d74c25 to c2eaf34 Compare December 18, 2023 17:39

jsync-swirlds approved these changes Dec 18, 2023

View reviewed changes

mxtartaglia-sl requested a review from hendrikebbers December 19, 2023 13:13

hendrikebbers approved these changes Dec 19, 2023

View reviewed changes

mxtartaglia-sl requested review from edward-swirldslabs and removed request for poulok and anthony-swirldslabs December 20, 2023 12:37

lpetrovic05 approved these changes Dec 20, 2023

View reviewed changes

mxtartaglia-sl merged commit 65fab23 into develop Dec 20, 2023
37 checks passed

mxtartaglia-sl deleted the 6704_remove_throwArgNull branch December 20, 2023 13:29

mxtartaglia-sl mentioned this pull request Dec 20, 2023

It is preferred to use Objects.requireNonNull to for null checks. #6139

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

chore: Remove throw arg null #10433

chore: Remove throw arg null #10433

mxtartaglia-sl commented Dec 11, 2023 •

edited

mxtartaglia-sl commented Dec 12, 2023 •

edited

github-actions bot commented Dec 12, 2023 •

edited

github-actions bot commented Dec 12, 2023 •

edited

codecov bot commented Dec 12, 2023 •

edited

github-actions bot commented Dec 12, 2023 •

edited

github-actions bot commented Dec 12, 2023 •

edited

github-actions bot commented Dec 12, 2023 •

edited

github-actions bot commented Dec 12, 2023 •

edited

github-actions bot commented Dec 12, 2023 •

edited

github-actions bot commented Dec 12, 2023 •

edited

jsync-swirlds left a comment

chore: Remove throw arg null #10433

chore: Remove throw arg null #10433

Conversation

mxtartaglia-sl commented Dec 11, 2023 • edited

mxtartaglia-sl commented Dec 12, 2023 • edited

github-actions bot commented Dec 12, 2023 • edited

Node: Unit Test Results

github-actions bot commented Dec 12, 2023 • edited

Node: HAPI Test (Crypto) Results

codecov bot commented Dec 12, 2023 • edited

Codecov Report

github-actions bot commented Dec 12, 2023 • edited

Node: HAPI Test (Token) Results

github-actions bot commented Dec 12, 2023 • edited

Node: HAPI Test (Misc) Results

github-actions bot commented Dec 12, 2023 • edited

Node: E2E Test Results

github-actions bot commented Dec 12, 2023 • edited

Node: HAPI Test (Time Consuming) Results

github-actions bot commented Dec 12, 2023 • edited

Node: Integration Test Results

github-actions bot commented Dec 12, 2023 • edited

Node: HAPI Test (Smart Contract) Results

jsync-swirlds left a comment

Choose a reason for hiding this comment

mxtartaglia-sl commented Dec 11, 2023 •

edited

mxtartaglia-sl commented Dec 12, 2023 •

edited

github-actions bot commented Dec 12, 2023 •

edited

github-actions bot commented Dec 12, 2023 •

edited

codecov bot commented Dec 12, 2023 •

edited

github-actions bot commented Dec 12, 2023 •

edited

github-actions bot commented Dec 12, 2023 •

edited

github-actions bot commented Dec 12, 2023 •

edited

github-actions bot commented Dec 12, 2023 •

edited

github-actions bot commented Dec 12, 2023 •

edited

github-actions bot commented Dec 12, 2023 •

edited