Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Issue305Spec test #10437

Merged
merged 6 commits into from Dec 24, 2023
Merged

Conversation

dikel
Copy link
Contributor

@dikel dikel commented Dec 12, 2023

Description:
Adds @HapiTest annotation to congestionMultipliersRefreshOnPropertyUpdate

Related issue(s):

Fixes #8774

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

@dikel dikel added Limechain Work planned for the LimeChain team Modularization Issues or PRs related to modularization labels Dec 12, 2023
@dikel dikel self-assigned this Dec 12, 2023
@dikel dikel requested review from a team as code owners December 12, 2023 10:21
@dikel dikel requested a review from mhess-swl December 12, 2023 10:21
agadzhalov
agadzhalov previously approved these changes Dec 12, 2023
Copy link
Contributor

@agadzhalov agadzhalov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

github-actions bot commented Dec 12, 2023

Node: HAPI Test (Crypto) Results

211 tests  ±0   205 ✔️ ±0   17m 26s ⏱️ +42s
  22 suites ±0       6 💤 ±0 
  22 files   ±0       0 ±0 

Results for commit 573d4fe. ± Comparison against base commit 0f965a4.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented Dec 12, 2023

Node: Unit Test Results

    2 291 files  ±0      2 291 suites  ±0   52m 27s ⏱️ + 6m 34s
118 613 tests ±0  118 578 ✔️ ±0  35 💤 ±0  0 ±0 
127 030 runs  ±0  126 995 ✔️ ±0  35 💤 ±0  0 ±0 

Results for commit 573d4fe. ± Comparison against base commit 0f965a4.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented Dec 12, 2023

Node: HAPI Test (Token) Results

189 tests  ±0   189 ✔️ ±0   17m 34s ⏱️ + 1m 4s
  13 suites ±0       0 💤 ±0 
  13 files   ±0       0 ±0 

Results for commit 573d4fe. ± Comparison against base commit 0f965a4.

♻️ This comment has been updated with latest results.

Copy link

codecov bot commented Dec 12, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (0f965a4) 62.79% compared to head (573d4fe) 62.79%.

Additional details and impacted files
@@              Coverage Diff              @@
##             develop   #10437      +/-   ##
=============================================
- Coverage      62.79%   62.79%   -0.01%     
+ Complexity     30884    30881       -3     
=============================================
  Files           3375     3375              
  Lines         136336   136336              
  Branches       14206    14206              
=============================================
- Hits           85615    85607       -8     
- Misses         47326    47331       +5     
- Partials        3395     3398       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

github-actions bot commented Dec 12, 2023

Node: E2E Test Results

    1 files  ±    0      1 suites  ±0   23m 36s ⏱️ + 23m 36s
311 tests +310  311 ✔️ +311  0 💤 ±0  0  - 1 
333 runs  +332  333 ✔️ +333  0 💤 ±0  0  - 1 

Results for commit 573d4fe. ± Comparison against base commit 0f965a4.

This pull request removes 1 and adds 311 tests. Note that renamed tests count towards both.
EndToEndTests ‑ initializationError
EndToEndTests ‑ ADDRESS_BOOK_CONTROLCanUpdateADDRESS_BOOK
EndToEndTests ‑ ADDRESS_BOOK_CONTROLCanUpdateNODE_DETAILS
EndToEndTests ‑ AccountsGetPayerRecordsIfSoConfigured
EndToEndTests ‑ Acct57CanMakeSmallChanges
EndToEndTests ‑ Acct57CantMakeLargeChanges
EndToEndTests ‑ AddingSignaturesToExecutedTxFails
EndToEndTests ‑ AddingSignaturesToExecutedTxFailsWithLongTermEnabled
EndToEndTests ‑ AddingSignaturesToNonExistingTxFails
EndToEndTests ‑ AddingSignaturesToNonExistingTxFailsWithLongTermEnabled
EndToEndTests ‑ AddressAliasIdFuzzing
…

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented Dec 12, 2023

Node: HAPI Test (Time Consuming) Results

21 tests  ±0     9 ✔️ ±0   26m 37s ⏱️ + 1m 9s
  2 suites ±0   12 💤 ±0 
  2 files   ±0     0 ±0 

Results for commit 573d4fe. ± Comparison against base commit 0f965a4.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented Dec 12, 2023

Node: HAPI Test (Misc) Results

420 tests  ±0   347 ✔️ ±0   27m 30s ⏱️ +59s
  73 suites ±0     72 💤  - 1 
  73 files   ±0       1 +1 

For more details on these failures, see this check.

Results for commit 573d4fe. ± Comparison against base commit 0f965a4.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented Dec 12, 2023

Node: Integration Test Results

280 tests  ±0   280 ✔️ ±0   28m 39s ⏱️ +17s
    5 suites ±0       0 💤 ±0 
    5 files   ±0       0 ±0 

Results for commit 573d4fe. ± Comparison against base commit 0f965a4.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented Dec 12, 2023

Node: HAPI Test (Smart Contract) Results

412 tests  ±0   397 ✔️ +1   51m 42s ⏱️ + 4m 46s
  55 suites ±0     15 💤 ±0 
  55 files   ±0       0  - 1 

Results for commit 573d4fe. ± Comparison against base commit 0f965a4.

♻️ This comment has been updated with latest results.

Signed-off-by: dikel <dikelito@tutamail.com>
@dikel dikel force-pushed the 08774-fix-issue-305-spec-tests branch from bd04743 to 19cfbc0 Compare December 12, 2023 14:55
Signed-off-by: dikel <dikelito@tutamail.com>
Copy link
Contributor

@stoyanov-st stoyanov-st left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@tinker-michaelj tinker-michaelj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will be fixed by #10640 (need to ensure gas throttling is ON).

@tinker-michaelj tinker-michaelj merged commit 6cd87bc into develop Dec 24, 2023
35 of 37 checks passed
@tinker-michaelj tinker-michaelj deleted the 08774-fix-issue-305-spec-tests branch December 24, 2023 21:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Limechain Work planned for the LimeChain team Modularization Issues or PRs related to modularization
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Resolve Issue305Spec errors
5 participants